Gradle / subprojects / model-core / src / testFixtures / groovy / org / gradle / model

internal

Clone Tools

Stats

Commits this week: 0
Total Committers: 15
Last Commit:
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 17 Jul
8:31 am

Lőrinc Pap

Apply `Anonymous type can be replaced with lambda` inspection the whole project

Options
    • -19
    • +11
    ./fixture/ModelActionBuilder.java
    • -80
    • +28
    ./fixture/ModelRegistryHelperExtension.java
  3. … 665 more files in changeset.
8:17 am

Lőrinc Pap

Apply `Explicit type can be replaced with <>` inspection the whole project

Options
    • -3
    • +10
    ./fixture/ModelActionBuilder.java
    • -5
    • +5
    ./fixture/ModelRegistryHelperExtension.java
  3. … 908 more files in changeset.
Tuesday 21 May
2:12 pm

Lőrinc Pap

Use method reference, where applicable

Options
    • -1
    • +1
    ./fixture/ModelActionBuilder.java
  2. … 169 more files in changeset.
2:12 pm

Lőrinc Pap

Use method reference, where applicable

Options
    • -1
    • +1
    ./fixture/ModelActionBuilder.java
  2. … 167 more files in changeset.
1:58 pm

Lőrinc Pap

Organize imports

Options
    • -1
    • +8
    ./fixture/ModelActionBuilder.java
    • -1
    • +0
    ./fixture/ModelRegistryHelperExtension.java
  3. … 338 more files in changeset.
1:10 pm

Lőrinc Pap

Replace anonymous classes with lambdas

Options
    • -19
    • +11
    ./fixture/ModelActionBuilder.java
    • -80
    • +28
    ./fixture/ModelRegistryHelperExtension.java
  3. … 710 more files in changeset.
1:10 pm

Lőrinc Pap

Replace anonymous classes with lambdas

Options
    • -18
    • +3
    ./fixture/ModelActionBuilder.java
    • -79
    • +28
    ./fixture/ModelRegistryHelperExtension.java
  3. … 694 more files in changeset.
Tuesday 11 Jul 2017
6:50 am

Lóránt Pintér

Replace usages of org.gradle.api.Nullable

With javax.annotation.Nullable.

Options
    • -2
    • +16
    ./fixture/ModelRegistryHelperExtension.java
  2. … 460 more files in changeset.
Friday 15 Jul 2016
3:36 am

Stefan Wolf

Initialize native services for ProjectRegistrySpec

Options
    • -1
    • +1
    ./fixture/ProjectRegistrySpec.groovy
3:32 am

Stefan Wolf

Cleanup static directory

Options
    • -1
    • +5
    ./fixture/ProjectRegistrySpec.groovy
2:22 am

Stefan Wolf

Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

Options
    • -3
    • +4
    ./fixture/ProjectRegistrySpec.groovy
  2. … 97 more files in changeset.
Monday 08 Feb 2016
5:44 am

Lóránt Pintér

Simplify setting target for new reference node

+review REVIEW-5821

Options
    • -4
    • +1
    ./fixture/ModelRegistryHelperExtension.java
  2. … 6 more files in changeset.
Tuesday 02 Feb 2016
5:29 pm

Cédric Champeau

Contextualize debug messages with project path

Options
    • -2
    • +2
    ./fixture/ModelRegistryHelper.java
  2. … 6 more files in changeset.
Wednesday 06 Jan 2016
6:09 am

Chris Beams <chris@gradle.com>

Revert "Promote o.g.model/{internal/core/rule/describe=>}/ModelRuleDescriptor"

This reverts commit de9e06338062d7ff2933717e1c30fbf0fb6c50d2 following a

review in which we determined that letting the indirect cycle persist is

a lesser evil that promoting ModelRuleDescriptor to public status.

Note again that the original commit, nor this reversion of it has any

impact on Classycle errors, as it appears to be incapable of detecting

this kind of (very common) cycle.

Options
    • -1
    • +1
    ./fixture/ModelActionBuilder.java
  2. … 85 more files in changeset.
Tuesday 05 Jan 2016
8:24 am

Lóránt Pintér

Expose struct bindings store to node initializer registry

+review REVIEW-5761

Options
    • -6
    • +10
    ./fixture/ProjectRegistrySpec.groovy
  2. … 4 more files in changeset.
7:25 am

Chris Beams <chris@gradle.com>

Coalesce o.g.m.{collection.internal=>internal.core}

This change removes a "feedback dependency" at the package level, which

is an indirect form of a package cycle.

In this case, collection.internal.ModelMapModelProjection depended on

internal.manage.instance.ManagedInstance while at the same time types in

internal.manage.extract depended on

collection.internal.ChildNodeInitializerStrategy* types.

So while there was no direct cycle between any two packages, there was

a an indirect cycle or between different subpackages of

collection.internal and collection.manage.

Indirect cycles are just as indicative of a design problem as their

direct counterparts, but unfortunately it appears that Classycle is not

capable of detecting them. Fortunately, other tools are. This screenshot

taken from Structure101 Studio visualizes the indirect cycle described

above: https://imgur.com/00FyduF.

It appears that the presence of these types in collection.internal was

probably an oversight to begin with. This package did start out with

proper collection types such as DefaultManagedSet and

DefaultCollectionBuilder, but these were removed quite some time ago in

commit 699abb21985e8126742007cb2e0daeae34316756. As such, this commit

resolves the indirect cycle simply by moving the offending types from

collection.internal into internal.core, where they look to be a better

fit anyway.

Options
    • -2
    • +0
    ./fixture/ModelRegistryHelperExtension.java
  2. … 13 more files in changeset.
7:05 am

Chris Beams <chris@gradle.com>

Promote o.g.model/{internal/core/rule/describe=>}/ModelRuleDescriptor

Much like the previous commit, this change resolves an indirect package

cycle. Unlike the previous commit, however, it does so by promoting a

previously intenal type (ModelRuleDescriptor) to public API status.

There are several exception types resident in org.gradle.model that

depend on ModelRuleDescriptor and expose that dependency through their

constructors. This alone provides a rationale for promoting

ModelRuleDescriptor to public status, and resolving the cycle is now an

additional motivation.

Note that while the package structure within on the internal side was

org.gradle.model.internal.core.rule.describe, ModelRuleDescriptor has

been promoted here directly to org.gradle.model, i.e. the

core.rule.describe subpackaging has not been mirrored into the public

package structure. The reason for doing this is to avoid introducing a

dependency from a higher level package (org.gradle.model) to a

subpackage. In general, package dependencies should always flow upward

from subpackages to parent packages in a given hierarchy, and not the

other way around. There are many counterexamples of this throughout the

codebase today, but that is no reason to perpetuate the practice.

Options
    • -1
    • +1
    ./fixture/ModelActionBuilder.java
  2. … 83 more files in changeset.
Sunday 03 Jan 2016
8:21 pm

Adam Murdoch

Merged `ModelPromise.canBeViewedAsMutable()` and `canBeViewedAsImmutable()` as the set of types is always the same.

This avoids doing a compatibility check twice on non match (once for immutable and once for mutable). This check is a hotspot at configuration time.

Options
    • -3
    • +3
    ./fixture/ModelRegistryHelperExtension.java
  2. … 22 more files in changeset.
1:12 am

Adam Murdoch

Added a rough implementation of `MutableModeNode.applyToSelf()` for reference model nodes.

Options
    • -6
    • +5
    ./fixture/ModelRegistryHelperExtension.java
  2. … 8 more files in changeset.
Thursday 31 Dec 2015
1:18 am

Adam Murdoch

`ModelAction` no longer needs to be parameterized.

Options
    • -14
    • +14
    ./fixture/ModelActionBuilder.java
    • -11
    • +11
    ./fixture/ModelRegistryHelperExtension.java
  3. … 34 more files in changeset.
Wednesday 30 Dec 2015
9:56 pm

Adam Murdoch

Treat `@RuleInput` properties on `RuleSource` types as references to implicit inputs for all rules on the rule source.

Moved responsibility for applying a rule to a particular scope up from `ModelRegistry` to `ModelRuleExtractor`. Now, all `RuleAction` instances applied to a `ModelRegistry` are applied relative to the root element, and it is the caller's responsibility to scope the action as required before registering it.

+review REVIEW-5756

Options
    • -2
    • +6
    ./fixture/ModelActionBuilder.java
  2. … 16 more files in changeset.
Saturday 12 Dec 2015
9:51 pm

Adam Murdoch

Reuse various global test services in `ProjectRegistrySpec`, to ensure same proxy generator instance is used for all tests.

+review REVIEW-5756

Options
    • -6
    • +14
    ./fixture/ProjectRegistrySpec.groovy
8:52 pm

Adam Murdoch

Reused some test singletons.

+review REVIEW-5756

Options
    • -4
    • +1
    ./fixture/ModelRegistryHelper.java
    • -0
    • +4
    ./fixture/ProjectRegistrySpec.groovy
  3. … 2 more files in changeset.
8:10 pm

Adam Murdoch

Moved a bunch of singletons off several prod classes to live on `ProjectRegistrySpec`.

+review REVIEW-5756

Options
    • -1
    • +2
    ./fixture/ModelRegistryHelper.java
    • -18
    • +12
    ./fixture/ProjectRegistrySpec.groovy
    • -28
    • +0
    ./fixture/TestNodeInitializerRegistry.java
  4. … 28 more files in changeset.
Thursday 10 Dec 2015
10:17 am

Lóránt Pintér

Simplify by using static method

+review REVIEW-5752

Options
    • -1
    • +2
    ./fixture/ModelRegistryHelperExtension.java
    • -11
    • +0
    ./fixture/TestNodeInitializerRegistry.java
  3. … 7 more files in changeset.
Tuesday 08 Dec 2015
12:54 pm

Lóránt Pintér

Don't expose node method

+review REVIEW-5738

Options
    • -1
    • +1
    ./fixture/ModelRegistryHelperExtension.java
  2. … 3 more files in changeset.
12:23 pm

Lóránt Pintér

Apply rules to links via predicates

Extends the filtering options when applying rules to the children of a

node by allowing evaluating child nodes via a Predicate (instead of

matching them against a single type).

+review REVIEW-5738

Options
    • -6
    • +2
    ./fixture/ModelRegistryHelperExtension.java
  2. … 24 more files in changeset.
Monday 07 Dec 2015
3:49 pm

Lóránt Pintér

Add type parameter to ModelAction

AbstractModelAction already had a type parameter, so ModelAction should

have one too.

+review REVIEW-5738

Options
    • -14
    • +14
    ./fixture/ModelActionBuilder.java
    • -13
    • +12
    ./fixture/ModelRegistryHelperExtension.java
  3. … 35 more files in changeset.
Saturday 05 Dec 2015
10:04 pm

Lóránt Pintér

Clarify purpose of method

+review REVIEW-5738

Options
    • -1
    • +1
    ./fixture/ModelRegistryHelperExtension.java
  2. … 4 more files in changeset.
10:02 pm

Lóránt Pintér

Simplify the use of ModelRegistryHelperExtension

+review REVIEW-5738

Options
    • -72
    • +82
    ./fixture/ModelRegistryHelperExtension.java
    • -4
    • +4
    ./fixture/ProjectRegistrySpec.groovy
  3. … 8 more files in changeset.