Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

  1. … 12 more files in changeset.
Some unit tests and fixes for determining whether to eagerly evaluate a `Provider` instance when serializing to the instant execution cache.

Also fixed an issue where `map { }` could not be called from the Groovy DSL on the result of `Provider.map { }`.

  1. … 12 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

    • -1
    • +1
    ./rules/DefaultRuleAwarePolymorphicNamedEntityInstantiator.java
  1. … 909 more files in changeset.
Some refactoring of the collection and map property implementations.

  1. … 4 more files in changeset.
Some refactoring of the collection and map property implementations.

  1. … 4 more files in changeset.
Change the behaviour of `Property.set(null)` so that the property's convention is used, if defined, instead of using 'not defined'.

  1. … 8 more files in changeset.
Change the behaviour of `Property.set(null)` so that the property's convention is used, if defined, instead of using 'not defined'.

  1. … 8 more files in changeset.
Consolidated some `FileSystemLocation` implementations and added some unit test coverage.

    • -0
    • +1066
    ./provider/PropertySpec.groovy
    • -0
    • +299
    ./provider/ProviderSpec.groovy
  1. … 11 more files in changeset.
Consolidated some `FileSystemLocation` implementations and added some unit test coverage.

    • -0
    • +1066
    ./provider/PropertySpec.groovy
    • -0
    • +299
    ./provider/ProviderSpec.groovy
  1. … 11 more files in changeset.
Revert "Promote o.g.model/{internal/core/rule/describe=>}/ModelRuleDescriptor"

This reverts commit de9e06338062d7ff2933717e1c30fbf0fb6c50d2 following a

review in which we determined that letting the indirect cycle persist is

a lesser evil that promoting ModelRuleDescriptor to public status.

Note again that the original commit, nor this reversion of it has any

impact on Classycle errors, as it appears to be incapable of detecting

this kind of (very common) cycle.

    • -1
    • +1
    ./rules/DefaultRuleAwareNamedDomainObjectFactoryRegistry.java
    • -1
    • +1
    ./rules/DefaultRuleAwarePolymorphicNamedEntityInstantiator.java
    • -1
    • +1
    ./rules/RuleAwareNamedDomainObjectFactoryRegistry.java
  1. … 83 more files in changeset.
Promote o.g.model/{internal/core/rule/describe=>}/ModelRuleDescriptor

Much like the previous commit, this change resolves an indirect package

cycle. Unlike the previous commit, however, it does so by promoting a

previously intenal type (ModelRuleDescriptor) to public API status.

There are several exception types resident in org.gradle.model that

depend on ModelRuleDescriptor and expose that dependency through their

constructors. This alone provides a rationale for promoting

ModelRuleDescriptor to public status, and resolving the cycle is now an

additional motivation.

Note that while the package structure within on the internal side was

org.gradle.model.internal.core.rule.describe, ModelRuleDescriptor has

been promoted here directly to org.gradle.model, i.e. the

core.rule.describe subpackaging has not been mirrored into the public

package structure. The reason for doing this is to avoid introducing a

dependency from a higher level package (org.gradle.model) to a

subpackage. In general, package dependencies should always flow upward

from subpackages to parent packages in a given hierarchy, and not the

other way around. There are many counterexamples of this throughout the

codebase today, but that is no reason to perpetuate the practice.

    • -1
    • +1
    ./rules/DefaultRuleAwareNamedDomainObjectFactoryRegistry.java
    • -1
    • +1
    ./rules/DefaultRuleAwarePolymorphicNamedEntityInstantiator.java
    • -1
    • +1
    ./rules/RuleAwareNamedDomainObjectFactoryRegistry.java
  1. … 81 more files in changeset.
Removed some legacy model map infrastructure, and move some more to 'testfixtures'

    • -0
    • +64
    ./rules/DefaultRuleAwareNamedDomainObjectFactoryRegistry.java
    • -0
    • +58
    ./rules/DefaultRuleAwarePolymorphicNamedEntityInstantiator.java
    • -0
    • +25
    ./rules/RuleAwareNamedDomainObjectFactoryRegistry.java
    • -0
    • +23
    ./rules/RuleAwarePolymorphicNamedEntityInstantiator.java
  1. … 8 more files in changeset.