Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Test for conflicting annotations on field and method

Make the detection of Groovy-generated getters generic

We don't want DefaultTypeAnnotationMetadataStore to depend directly on Groovy. Instead, we can inject code that detects Groovy generated 'is'-getters.

  1. … 8 more files in changeset.
Remove unused test class

Also split another test case to better capture what's going on with ignored properties.

  1. … 1 more file in changeset.
Handle cases when we have both 'is'-getters and 'get'-getters

Groovy generates both an 'is' and a 'get'-getter for boolean properties, and we shouldn't warn in this case. However, if the user defines both getter methods, we should require at least one of them to be explicitly ignored.

We need to figure out which method we need to call to get the value of the property. In the Groovy-generated case we can safely pick the 'get'-getter, because they both do exactly the same. In the user-specified case we need to be told which (if any) to use, as we have no means to make this decision on our own.

  1. … 3 more files in changeset.
Allow Groovy-generated boolean getters to exist without warning

  1. … 1 more file in changeset.
Test warning when ignored property has other annotations

  1. … 1 more file in changeset.
Test warnings for annotated non-getter methods

  1. … 1 more file in changeset.
Handle Inject annotation on fields

Unlike other property type annotations, we allow `@Inject` to be present on fields without a getter.

  1. … 2 more files in changeset.
Fix tests

Also report type validation problems in a nicer way.

  1. … 3 more files in changeset.
Fix tests

Also report type validation problems in a nicer way.

  1. … 3 more files in changeset.
Scan methods first

  1. … 23 more files in changeset.
Intermediate step to method-based annotation metadata collection

  1. … 30 more files in changeset.
Intermediate step to method-based annotation metadata collection

  1. … 30 more files in changeset.
Intermediate step to method-based annotation metadata collection

  1. … 30 more files in changeset.
Intermediate step to method-based annotation metadata collection

  1. … 30 more files in changeset.
Intermediate step to method-based annotation metadata collection

  1. … 30 more files in changeset.
Handle Internal annotation in TypeAnnotationMetadataStore

  1. … 8 more files in changeset.
Handle Internal annotation in TypeAnnotationMetadataStore

  1. … 8 more files in changeset.
Handle Internal annotation in TypeAnnotationMetadataStore

  1. … 8 more files in changeset.
Handle Internal annotation in TypeAnnotationMetadataStore

  1. … 8 more files in changeset.
Handle Internal annotation in TypeAnnotationMetadataStore

  1. … 8 more files in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Merge annotations from is- and get-getter

Previously we didn't do this, and we just accidentally got the right annotation for RunTestExecutable.ignoreFailures.

  1. … 1 more file in changeset.
Fix class cycle

  1. … 8 more files in changeset.
Fix class cycle

  1. … 8 more files in changeset.
Fix class cycle

  1. … 8 more files in changeset.