DefaultModelSchemaExtractorTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moved checking for custom constructors and fields in managed types to bindings discovery

+review REVIEW-5761

    • -207
    • +0
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 13 more files in changeset.
Collect rule source problems in specific class

We want to collect other types of validation errors later, thus the

rule-specific errors need to be moved out of ValidationProblemCollector.

+review REVIEW-5761

    • -9
    • +9
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 18 more files in changeset.
Remove restrictions on overridden/overloaded methods in `@Managed` types

We know how to handle these now when generating proxies.

+review REVIEW-5761

    • -65
    • +1
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 5 more files in changeset.
Move more struct validation to bindings discovery

+review REVIEW-5761

    • -43
    • +0
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 6 more files in changeset.
Moving more property validation to bindings discovery

Making managed and unmanaged schemas the same by a validator at a time.

+review REVIEW-5761

    • -211
    • +6
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 9 more files in changeset.
Move some struct validation to bindings discovery

First step in moving all struct validation to bindings discovery. The

goal here is to make managed and unmanaged struct schemas the same

incrementally.

+review REVIEW-5761

    • -60
    • +0
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 12 more files in changeset.
Store all property accessors individually

+review REVIEW-5761

    • -1
    • +2
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 8 more files in changeset.
Enhance javabean spec compliance tests by actually using Introspector

Theses tests remain @NotYetImplemented

    • -3
    • +4
    ./DefaultModelSchemaExtractorTest.groovy
Collect failures inspecting `ModelMap` and `ModelSet` types, rather than failing on first problem.

+review REVIEW-5756

    • -21
    • +29
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 3 more files in changeset.
Deferred complaining about subtypes of non-final scalar types until the context of their use is known.

Refactored to use a consistent approach to deciding whether a type is a scalar type or not.

Added some more int test coverage for these types.

+review REVIEW-5756

    • -18
    • +11
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 8 more files in changeset.
Removed some constraints from model element type validation which are no longer required:

- Removed constraint that given `ModelMap<T>` then `T` cannot be any `ModelMap<?>`

- Removed constraint that given `ModelSet<T>` then `T` cannot be any `ModelSet<?>`.

Added some test coverage for these cases.

+review REVIEW-5756

    • -3
    • +6
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 6 more files in changeset.
Collect problems with fields and non-public methods on `@Managed` types, rather than failing on the first problem.

Also use consistent checks for fields on `RuleSource` types and fields on `@Managed` types.

+review REVIEW-5756

    • -20
    • +66
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 9 more files in changeset.
Some changes for line endings in schema validation error messages.

+review REVIEW-5756

    • -3
    • +2
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 2 more files in changeset.
Collect problems with constructors of `@Managed` type, rather than failing on first problem.

Also fixed traversal of type hierarchy of a `@Managed` type so that super-types are visited once rather than potentially many times.

+review REVIEW-5756

    • -8
    • +32
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 3 more files in changeset.
Started to collect the problems discovered during model element type inspection, rather than failing on the first problem found.

Only a couple of problems are handled this way currently.

Also use consistent formatting for model type problems and rule source problems.

+review REVIEW-5756

    • -4
    • +29
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 8 more files in changeset.
Reworked `DefaultModelSchemaExtractor` construction so that default extraction strategies are included only when requested.

This allows a consumer to select which strategies are relevant to that consumer.

+review REVIEW-5756

    • -20
    • +8
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 17 more files in changeset.
Revert "Simplify aspect extraction in schema"

This reverts commit 55800ef7855af00c2e60b93bb76177db2ca86562.

+review REVIEW-5761

    • -2
    • +2
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 8 more files in changeset.
Simplify aspect extraction in schema

No need for an extra type to hold property extraction information,

since ModelProperty already holds the same.

+review REVIEW-5761

    • -2
    • +2
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 8 more files in changeset.
Turned ModelSchemaExtractor into an interface.

+review REVIEW-5756

    • -0
    • +1550
    ./DefaultModelSchemaExtractorTest.groovy
  1. … 4 more files in changeset.