Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use parameter types in method descriptor

+review REVIEW-5921

    • -11
    • +9
    ./MethodModelRuleDescriptorTest.groovy
  1. … 27 more files in changeset.
Removed method that was only used in tests

    • -2
    • +11
    ./MethodModelRuleDescriptorTest.groovy
  1. … 2 more files in changeset.
Remove SingleNodeBinding and StandardDescriptorFactory

These types have been unused in production since commits

6532972aa70c82a0d4505911f20a2532e891ca57 and

3d77d71cf7b6c0fecc630a94ef89fc851e0c349d respectively.

    • -38
    • +0
    ./StandardDescriptorFactoryTest.groovy
  1. … 2 more files in changeset.
Rename ModelType.getSimpleName() to getDisplayName()

Because it is not analogous to Class.getSimpleName(), it needs its own

name. The purpose is to generate a name to be displayed to humans,

hence getDisplayName().

+review REVIEW-5651

    • -1
    • +1
    ./MethodModelRuleDescriptorTest.groovy
  1. … 12 more files in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -2
    • +3
    ./MethodModelRuleDescriptorTest.groovy
  1. … 30 more files in changeset.
Shows more concise names for rule source method rules

+review

    • -6
    • +21
    ./MethodModelRuleDescriptorTest.groovy
  1. … 32 more files in changeset.
Expose components.«component».source.«sourceSet» to the model.

+review REVIEW-5469

    • -0
    • +38
    ./StandardDescriptorFactoryTest.groovy
  1. … 8 more files in changeset.
Revert "Revert "Prepare for caching extracted model rules - don't hold strong references to methods and thus rule types in DefaultMethodRuleDefinition" because it fails the build on Java 8."

This reverts commit 6bfdf13e5e567fec178fe5b04f574878a3441415.

Conflicts:

subprojects/model-core/src/main/java/org/gradle/model/internal/inspect/DefaultMethodRuleDefinition.java

    • -1
    • +1
    ./MethodModelRuleDescriptorTest.groovy
  1. … 10 more files in changeset.
Revert "Prepare for caching extracted model rules - don't hold strong references to methods and thus rule types in DefaultMethodRuleDefinition" because it fails the build on Java 8.

This reverts commit ef81d6f699a8a681794f4e1929e5d5f2ab4798e5.

    • -1
    • +1
    ./MethodModelRuleDescriptorTest.groovy
  1. … 10 more files in changeset.
Prepare for caching extracted model rules - don't hold strong references to methods and thus rule types in DefaultMethodRuleDefinition

+review REVIEW-5335

    • -1
    • +1
    ./MethodModelRuleDescriptorTest.groovy
  1. … 10 more files in changeset.
unit test for MethodModelRuleDescriptor.

+review REVIEW-5034.

    • -0
    • +46
    ./MethodModelRuleDescriptorTest.groovy