InstanceBackedModelCreatorTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename ModelRegistry.create() to register() +review REVIEW-5678

    • -56
    • +0
    ./InstanceBackedModelCreatorTest.groovy
  1. … 67 more files in changeset.
Rename readonly to immutable and writable to mutable to better describe the intent

+review REVIEW-5608

    • -4
    • +4
    ./InstanceBackedModelCreatorTest.groovy
  1. … 16 more files in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -1
    • +1
    ./InstanceBackedModelCreatorTest.groovy
  1. … 30 more files in changeset.
Reimplements the format of rule binding errors - removes file seperator from build script location

+review REVIEW-5556

    • -1
    • +1
    ./InstanceBackedModelCreatorTest.groovy
  1. … 29 more files in changeset.
Pull the error for trying to create model nodes as scopes other than root “up”.

+review REVIEW-5353

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 26 more files in changeset.
Push the class to rule extractor into the registry, to allow nodes etc. to accept RuleSource classes.

While it bothers me slightly that we are pushing knowledge of a particular type of rule representation into the registry, it saves having to cart some extra stuff around.

+review REVIEW-5353

    • -1
    • +1
    ./InstanceBackedModelCreatorTest.groovy
  1. … 38 more files in changeset.
Collection mutation rule specifies input taking mutation rule for particular model element

+review REVIEW-5353

    • -3
    • +3
    ./InstanceBackedModelCreatorTest.groovy
  1. … 68 more files in changeset.
Liberate some model registry test support from DefaultModelRegistryTest.

Includes some new/renamed API on ModelRegistry.

+review REVIEW-5350

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 21 more files in changeset.
Revert selective task closing work.

Too much breakage.

+review REVIEW-5350

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 67 more files in changeset.
Wire the model registry into the “task selector”, effectively enabling configure-on-demand for rule based task declarations.

Rather than eagerly “realize” the whole task container and its contents, we now only realize the container itself.

This means that we know of all the tasks that will exist without actually creating them.

If a task (declared by rules) is not needed for a build (i.e. not selected, not depended on) it will not be created.

However, our rule based plugins at this time contain coarse rules that don't allow this feature to be leveraged.

Benefits will only be seen right now for contrived domains.

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 63 more files in changeset.
Renamed methods on ModelPromise to match the names used on ModelProjection.

    • -4
    • +4
    ./InstanceBackedModelCreatorTest.groovy
  1. … 4 more files in changeset.
Change model registry storage from being a table of opaque objects, to a graph of properties.

This doesn't quite satisfy the story goal of being able to target rules to nested properties, because we don't know about the nested properties until we create the objects. If we are using by-type bindings then we don't know that we need to create the parent object. To solve this we need to start populating the graph when something is registered (i.e. insert it in a kind of pending state, with its links also in a pending state) and then only populate the data when the node is “initialised”.

We are also only respecting one level of depth at the moment. That is, we treat (as far as the model graph is concerned) the properties of managed elements as unmanaged. Later stories will make this fully “transitive”.

+review

    • -2
    • +3
    ./InstanceBackedModelCreatorTest.groovy
  1. … 123 more files in changeset.
Introduce a builder for model creators. Bring back some test coverage.

+review REVIEW-5204

    • -3
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 17 more files in changeset.
Consolidate ModelCreator implementations

+review REVIEW-5204

    • -2
    • +3
    ./InstanceBackedModelCreatorTest.groovy
  1. … 27 more files in changeset.
Initial implementation of reporting on model rules that fail to bind.

It's not entirely accurate yet and the error output is insufficient.

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 37 more files in changeset.
Simplify name.

    • -2
    • +2
    ./InstanceBackedModelCreatorTest.groovy
  1. … 31 more files in changeset.
Add support for a write only view of a polymorphic domain object container, which we are using to project a controlled API of the task container for model rules.

    • -0
    • +55
    ./InstanceBackedModelCreatorTest.groovy
  1. … 49 more files in changeset.