Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Apply `Anonymous type can be replaced with lambda` inspection the whole project

  1. … 665 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

  1. … 909 more files in changeset.
Imports

  1. … 17 more files in changeset.
Imports

  1. … 17 more files in changeset.
Extract anonymous classes to static inner classes

    • -10
    • +18
    ./SimpleModelRuleDescriptor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -11
    • +19
    ./SimpleModelRuleDescriptor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -10
    • +18
    ./SimpleModelRuleDescriptor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -10
    • +18
    ./SimpleModelRuleDescriptor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -10
    • +18
    ./SimpleModelRuleDescriptor.java
  1. … 146 more files in changeset.
Use method reference, where applicable

  1. … 169 more files in changeset.
Use method reference, where applicable

  1. … 167 more files in changeset.
Organize imports

  1. … 339 more files in changeset.
Replace anonymous classes with lambdas

  1. … 710 more files in changeset.
Replace anonymous classes with lambdas

  1. … 694 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 890 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 897 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Convert net.jcip.annotations to javax.annotation.concurrent annotations

  1. … 64 more files in changeset.
Make bridged task description lazy

Every task is bridged into the new model and needs a descriptor there.

This descriptor was eagerly allocated so far. It is now computed lazily.

  1. … 1 more file in changeset.
Since we're caching the descriptors, it is not necessary to intern the description anymore

+review REVIEW-5921

Use parameter types in method descriptor

+review REVIEW-5921

    • -32
    • +20
    ./MethodModelRuleDescriptor.java
  1. … 27 more files in changeset.
Fix failure to generate a method descriptor for an overloaded method

For now, we simply don't cache the descriptors for overloaded methods.

It may be preferable to instead cache based on some key generated

from the method name and parameter types. Or perhaps even a single weak

hash map keyed on class/method/params.

I'm leaving further improvements for @melix to verify using a profiler

before proceeding.

    • -11
    • +22
    ./MethodModelRuleDescriptor.java
Removed method that was only used in tests

  1. … 2 more files in changeset.
Avoid constructing `MethodModelRuleDescriptor` for interning

+review REVIEW-5921

    • -25
    • +50
    ./MethodModelRuleDescriptor.java
Cache hashCode so that it's not computed several times when interning

  1. … 1 more file in changeset.
Reduce memory footprint by interning strings, model path and model references.

With this change, memory consumption for "big empty" multi-project goes from 700MB to 611MB.

  1. … 9 more files in changeset.
Add @Override where missing in production software model sources

Prior to this change, the affected submodules had 2044 occurrences of

the @Override annotation. With this commit, there are now 3492

occurrences. This suggests some divergence in IDE settings, either

across developers, across time, or both. At the moment, it appears that

IDEA (15 CE) is configured correctly to add @Override automatically.

This same refactoring should probably be done globally acrosse the

Gradle codebase, but has been constrained here to software model-related

submodules (a) because it is what the author is responsible for and (b)

because significant refactoring of type hierarchies is underway there

right now--the kind of work most likely to benefit from the compiler

checks that proper use of @Override affords.

Should this same refactoring be applied globally, it would be worth

looking into enforcing consistent use of @Override via checkstyle or

similar at the same time.

  1. … 417 more files in changeset.