Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove synthetic accessors for internal private symbol references

    • -4
    • +4
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 897 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -4
    • +4
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -4
    • +4
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 902 more files in changeset.
Do not cache type annotation metadata across builds

We only use it in DefaultTypeMetadataStore that is already cached across builds (and even that might not be worth it).

    • -10
    • +10
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -29
    • +14
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -37
    • +35
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -41
    • +32
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Simplify `DefaultTypeAnnotationMetadataStore#validateSetterForMutableType` using the newly defined non-generic `propertyNameFor`

    • -21
    • +11
    ./impl/DefaultTypeAnnotationMetadataStore.java
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -0
    • +36
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -0
    • +28
    ./impl/DefaultTypeAnnotationMetadataStore.java
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -8
    • +53
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -0
    • +36
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -0
    • +24
    ./impl/DefaultTypeAnnotationMetadataStore.java
Add `PropertyValidationAccess#validateMutableNonFinalField` to encourage final fields in tasks

    • -0
    • +36
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Address review comments

    • -8
    • +8
    ./impl/DefaultTypeAnnotationMetadataStore.java
Document how the type annotation metadata store works

    • -11
    • +22
    ./impl/DefaultTypeAnnotationMetadataStore.java
Make the detection of Groovy-generated getters generic

We don't want DefaultTypeAnnotationMetadataStore to depend directly on Groovy. Instead, we can inject code that detects Groovy generated 'is'-getters.

    • -3
    • +6
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Make PropertyMetadata API nicer and safer to work with

    • -11
    • +14
    ./impl/DefaultPropertyAnnotationMetadata.java
  1. … 9 more files in changeset.
Handle cases when we have both 'is'-getters and 'get'-getters

Groovy generates both an 'is' and a 'get'-getter for boolean properties, and we shouldn't warn in this case. However, if the user defines both getter methods, we should require at least one of them to be explicitly ignored.

We need to figure out which method we need to call to get the value of the property. In the Groovy-generated case we can safely pick the 'get'-getter, because they both do exactly the same. In the user-specified case we need to be told which (if any) to use, as we have no means to make this decision on our own.

    • -8
    • +37
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 3 more files in changeset.
Allow Groovy-generated boolean getters to exist without warning

    • -0
    • +6
    ./impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Remove unnecessary newline

    • -1
    • +0
    ./impl/DefaultTypeAnnotationMetadataStore.java