Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Display nice type names consistently for validation warnings

Also use the new expectDeprecationWarning(String) to check for emitted runtime validation warnings.

    • -2
    • +4
    ./MessageFormattingTypeValidationContext.java
  1. … 3 more files in changeset.
Address review comments

  1. … 2 more files in changeset.
Move WorkValidationException to :execution

  1. … 8 more files in changeset.
Consistently check for path sensitivity warnings during runtime

    • -5
    • +14
    ./DefaultTypeValidationContext.java
  1. … 14 more files in changeset.
Correctly report everything

    • -1
    • +11
    ./DefaultTypeValidationContext.java
    • -4
    • +22
    ./MessageFormattingTypeValidationContext.java
    • -11
    • +13
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 16 more files in changeset.
Correctly report everything

    • -1
    • +11
    ./DefaultTypeValidationContext.java
    • -10
    • +24
    ./MessageFormattingTypeValidationContext.java
    • -11
    • +12
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 16 more files in changeset.
Consolidate type validation

Use ValidateContext with a few standard implementations instead of the many different interfaces and implementations we used to collect valdiation problems before. This fixes issues with types being displayed inconsistently.

The implementation is not fully correct yet: we now fail to display the correct type for problems that are bound to a type instead of a property.

    • -0
    • +36
    ./DefaultTypeValidationContext.java
    • -0
    • +49
    ./MessageFormattingTypeValidationContext.java
    • -0
    • +104
    ./TypeValidationContext.java
    • -4
    • +0
    ./annotations/PropertyAnnotationMetadata.java
    • -3
    • +2
    ./annotations/TypeAnnotationMetadata.java
    • -2
    • +2
    ./annotations/TypeAnnotationMetadataStore.java
    • -11
    • +1
    ./annotations/impl/DefaultPropertyAnnotationMetadata.java
    • -9
    • +7
    ./annotations/impl/DefaultTypeAnnotationMetadata.java
    • -55
    • +45
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 37 more files in changeset.
Explicitly return no annotation metadata for primitive types, arrays and annotations

    • -0
    • +4
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Guard against null package

    • -3
    • +6
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
Ignore supported script language base packages for property inspection

We don't want to inspect any of the types from java.*, groovy.* or kotlin.*.

    • -0
    • +17
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Ignore supported script language base packages for property inspection

We don't want to inspect any of the types from java.*, groovy.* or kotlin.*.

    • -0
    • +17
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 8 more files in changeset.
Rename TaskValidationException to WorkValidationException

And move it to :model-core.

    • -0
    • +33
    ./WorkValidationException.java
  1. … 7 more files in changeset.
Rename ParameterValidationContext to WorkValidationContext

    • -0
    • +71
    ./WorkValidationContext.java
    • -2
    • +2
    ./annotations/PropertyAnnotationMetadata.java
    • -2
    • +2
    ./annotations/TypeAnnotationMetadata.java
    • -1
    • +3
    ./annotations/TypeAnnotationMetadataStore.java
    • -2
    • +2
    ./annotations/impl/DefaultPropertyAnnotationMetadata.java
    • -2
    • +2
    ./annotations/impl/DefaultTypeAnnotationMetadata.java
    • -2
    • +2
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 33 more files in changeset.
Merge branch 'master' into lptr/model/interface-annotations-take-precedence-over-superclass

    • -31
    • +39
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Revert "Make it a strict error if a method is both replaced and declares a type"

This reverts commit ae4f4169cb1130345dcdf78d52a0ebc3747a299c.

    • -10
    • +4
    ./annotations/impl/DefaultPropertyAnnotationMetadata.java
    • -13
    • +5
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Make annotations inherited from interface take precedence over superclass

    • -22
    • +48
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 1 more file in changeset.
Make it a strict error if a method is both replaced and declares a type

    • -4
    • +10
    ./annotations/impl/DefaultPropertyAnnotationMetadata.java
    • -5
    • +13
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 2 more files in changeset.
Do not check for conflicting annotations when there's only one

    • -9
    • +9
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
Ignore methods annotated with ReplacedBy

    • -35
    • +44
    ./annotations/impl/DefaultTypeAnnotationMetadataStore.java
  1. … 10 more files in changeset.
Some more Java 8 changes

    • -1
    • +1
    ./annotations/impl/DefaultTypeAnnotationMetadata.java
  1. … 1 more file in changeset.
Rename visit{Error -> Warning} and visit{ErrorStrict -> Error}

    • -14
    • +14
    ./ParameterValidationContext.java
    • -1
    • +1
    ./annotations/impl/DefaultPropertyAnnotationMetadata.java
    • -1
    • +1
    ./annotations/impl/DefaultTypeAnnotationMetadata.java
  1. … 13 more files in changeset.
Provide better messages for strict validation errors

  1. … 2 more files in changeset.
WIP

  1. … 8 more files in changeset.
Make all validation warnings errors

  1. … 10 more files in changeset.
Add integration tests for validating non-getter methods

These were left off somehow.

    • -2
    • +1
    ./annotations/impl/DefaultTypeAnnotationMetadata.java
  1. … 1 more file in changeset.
Apply `Anonymous type can be replaced with lambda` inspection the whole project

  1. … 664 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

  1. … 906 more files in changeset.
Upgrade commons-lang{->3} replacing packages

  1. … 174 more files in changeset.
Change ArrayLists, used as Queues to ArrayDeques and LinkedLists

removing the first element is linear in an ArrayList

  1. … 9 more files in changeset.
Change ArrayLists, used as Queues to ArrayDeques and LinkedLists

removing the first element is linear in an ArrayList

  1. … 9 more files in changeset.