Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -5
    • +5
    ./AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -3
    • +3
    ./CyclicalManagedTypeIntegrationTest.groovy
    • -2
    • +2
    ./EnumsInManagedModelIntegrationTest.groovy
    • -6
    • +6
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
    • -3
    • +3
    ./InvalidManagedModelRuleIntegrationTest.groovy
    • -8
    • +8
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
    • -6
    • +6
    ./ManagedModelMapIntegrationTest.groovy
    • -7
    • +7
    ./ManagedModelPropertyTargetingRuleIntegrationTest.groovy
    • -2
    • +2
    ./ManagedTypeImplementationClassCachingSpec.groovy
    • -3
    • +3
    ./ManagedTypeReferencesIntegrationTest.groovy
    • -3
    • +3
    ./ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
    • -10
    • +10
    ./ModelSetIntegrationTest.groovy
    • -3
    • +3
    ./NestedManagedTypeIntegrationTest.groovy
    • -6
    • +6
    ./PolymorphicManagedTypeIntegrationTest.groovy
    • -13
    • +13
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 858 more files in changeset.
Annotate integ tests failing with instant execution in various projects

after second round of CI feedback

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +6
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 32 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -0
    • +3
    ./CyclicalManagedTypeIntegrationTest.groovy
    • -0
    • +2
    ./EnumsInManagedModelIntegrationTest.groovy
    • -0
    • +3
    ./InvalidManagedModelRuleIntegrationTest.groovy
    • -0
    • +8
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
    • -0
    • +6
    ./ManagedModelMapIntegrationTest.groovy
    • -0
    • +7
    ./ManagedModelPropertyTargetingRuleIntegrationTest.groovy
    • -0
    • +2
    ./ManagedTypeImplementationClassCachingSpec.groovy
    • -0
    • +3
    ./ManagedTypeReferencesIntegrationTest.groovy
    • -0
    • +3
    ./ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
    • -0
    • +3
    ./NestedManagedTypeIntegrationTest.groovy
    • -0
    • +6
    ./PolymorphicManagedTypeIntegrationTest.groovy
    • -0
    • +14
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 13 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -0
    • +3
    ./CyclicalManagedTypeIntegrationTest.groovy
    • -0
    • +2
    ./EnumsInManagedModelIntegrationTest.groovy
    • -0
    • +3
    ./InvalidManagedModelRuleIntegrationTest.groovy
    • -0
    • +8
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
    • -0
    • +6
    ./ManagedModelMapIntegrationTest.groovy
    • -0
    • +7
    ./ManagedModelPropertyTargetingRuleIntegrationTest.groovy
    • -0
    • +2
    ./ManagedTypeImplementationClassCachingSpec.groovy
    • -0
    • +3
    ./ManagedTypeReferencesIntegrationTest.groovy
    • -0
    • +3
    ./ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
    • -0
    • +3
    ./NestedManagedTypeIntegrationTest.groovy
    • -0
    • +6
    ./PolymorphicManagedTypeIntegrationTest.groovy
    • -0
    • +14
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 13 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./AbstractClassBackedManagedTypeIntegrationTest.groovy
    • -0
    • +3
    ./CyclicalManagedTypeIntegrationTest.groovy
    • -0
    • +2
    ./EnumsInManagedModelIntegrationTest.groovy
    • -0
    • +3
    ./InvalidManagedModelRuleIntegrationTest.groovy
    • -0
    • +8
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
    • -0
    • +6
    ./ManagedModelMapIntegrationTest.groovy
    • -0
    • +7
    ./ManagedModelPropertyTargetingRuleIntegrationTest.groovy
    • -0
    • +2
    ./ManagedTypeImplementationClassCachingSpec.groovy
    • -0
    • +3
    ./ManagedTypeReferencesIntegrationTest.groovy
    • -0
    • +3
    ./ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
    • -0
    • +3
    ./NestedManagedTypeIntegrationTest.groovy
    • -0
    • +6
    ./PolymorphicManagedTypeIntegrationTest.groovy
    • -0
    • +14
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 13 more files in changeset.
Replace 'Matchers' with 'CoreMatchers'

So we do not require 'org.hamcrest:hamcrest-library' as additional

dependency anymore. Which was only available for most of the tests

because it leaked onto the test compile classpath.

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 162 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 283 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 286 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 284 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 285 more files in changeset.
Use 'implementation' dependencies everywhere

    • -1
    • +1
    ./ManagedModelGroovyScalarConfigurationIntegrationTest.groovy
  1. … 285 more files in changeset.
Remove excluded-tests.kt

Tests excluded in excluded-tests.kt can easily be neglected. This commit moves

them to @Requires annotation on test classes.

    • -0
    • +5
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 4 more files in changeset.
Make software model tasks accessible using abbreviated names again

This was broken by a refactoring towards lazy task configuration,

because we had no test coverage for this case.

    • -1
    • +1
    ./ManagedModelMapIntegrationTest.groovy
  1. … 4 more files in changeset.
Change `DefaultNamedDomainObjectCollection` to better handle elements added using a provider, in particular when locating elements by name.

Change `DefaultTaskContainer` to use this to implement `createLater()` rather than the existing placeholder actions, to make deferred task creation less of a special case.

    • -1
    • +1
    ./ManagedModelMapIntegrationTest.groovy
  1. … 9 more files in changeset.
Use the correct, immutable, view for @RuleInput properties attached to a RuleSource when running a rule method from the RuleSourec.

  1. … 2 more files in changeset.
Added some move test coverage for mutation of subject of `@Validate` rules.

    • -0
    • +35
    ./InvalidManagedModelMutationIntegrationTest.groovy
    • -1
    • +38
    ./ManagedScalarCollectionsIntegrationTest.groovy
Pass an immutable (and readable) view of the subject to `@Validate` rules.

Also added a new exception type to distinguish between mutating a read only view and mutating a closed view.

    • -6
    • +6
    ./InvalidManagedModelMutationIntegrationTest.groovy
    • -3
    • +75
    ./ManagedModelMapIntegrationTest.groovy
    • -6
    • +6
    ./ManagedScalarCollectionsIntegrationTest.groovy
    • -2
    • +2
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 12 more files in changeset.
Allow scalar collections and bridged tasks to be viewed as `ModelElement`.

    • -0
    • +43
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 7 more files in changeset.
Allow managed and unmanaged model elements to be viewed as `ModelElement`.

    • -0
    • +38
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
    • -0
    • +43
    ./ManagedTypeWithUnmanagedPropertiesIntegrationTest.groovy
  1. … 7 more files in changeset.
Reworked display name for views of `ModelMap` and `ModelSet` (and subtypes) elements so that the same display name for a given element is used regardless of the view type.

Added some test coverage for viewing these elements as various types.

  1. … 11 more files in changeset.
Added `ModelElement` interface, which is a view that provides some basic meta-data for a particular model element. Currently supported by `ModelMap` and `ModelSet` elements.

Also changed the generated display name for `ModelSet` views to be consistent with that provided for `ModelMap` views.

  1. … 14 more files in changeset.
Use parameter types in method descriptor

+review REVIEW-5921

    • -8
    • +8
    ./InvalidManagedModelMutationIntegrationTest.groovy
    • -5
    • +5
    ./InvalidManagedModelRuleIntegrationTest.groovy
    • -5
    • +5
    ./ManagedModelMapIntegrationTest.groovy
    • -2
    • +2
    ./ManagedScalarCollectionsIntegrationTest.groovy
    • -2
    • +2
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 22 more files in changeset.
Refactor collection of scalar types views now that writable state of properties is known when creating projections

This commit introduces a cleaner implementation of managed scalar type collections, by introducing custom view types that perform the appropriate checks. The `ManagedModelProjection` class no longer calls internal APIs of scalar collection types, but rather knows about the specific view type of scalar collections. For consistency, and to avoid having to explicitly create an empty list when calling `add` on a read-write list that has not been explicitly initialized, getting the value of a read-write property if the list is mutable will now return the empty list instead of `null`.

+review REVIEW-5803

    • -5
    • +1
    ./ManagedScalarCollectionsIntegrationTest.groovy
  1. … 6 more files in changeset.
Fixed tests

+review REVIEW-5801

    • -1
    • +1
    ./ManagedModelMapIntegrationTest.groovy
Explicitly forbid non-getter/setter default methods

This was a regression introduced by moving struct schema extraction

validation to bindings extraction.

+review REVIEW-5761

    • -3
    • +2
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 1 more file in changeset.
Explicitly forbid non-getter/setter default methods

This was a regression introduced by moving struct schema extraction

validation to bindings extraction.

    • -3
    • +2
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 1 more file in changeset.
Moved checking for custom constructors and fields in managed types to bindings discovery

+review REVIEW-5761

    • -1
    • +2
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
  1. … 13 more files in changeset.
Fixed tests

+review REVIEW-5761

    • -1
    • +2
    ./ScalarTypesInManagedModelIntegrationTest.groovy
  1. … 1 more file in changeset.
Fixed tests

+review REVIEW-5761

    • -1
    • +3
    ./InterfaceBackedManagedTypeIntegrationTest.groovy
    • -2
    • +2
    ./ScalarTypesInManagedModelIntegrationTest.groovy