ScopedRuleSourceIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Renamed a couple of test classes.

+review REVIEW-5739

    • -158
    • +0
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 3 more files in changeset.
Minor test rename.

+review REVIEW-5739

    • -2
    • +1
    ./ScopedRuleSourceIntegrationTest.groovy
Collect several more `RuleSource` validation problems rather than failing on first problem.

In particular, problems with `@Model` and type registration rules are collected.

Also defer validation for whether the subject of a `@Model` rule can be created or not, until we know the set of element types that can be constructed.

+review REVIEW-5739

    • -2
    • +2
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 18 more files in changeset.
Fix test

We need to explicitly realize the task for the Defaults rule to run

that in turn applies the RuleSource with the offending rule

+review REVIEW-5752

    • -1
    • +1
    ./ScopedRuleSourceIntegrationTest.groovy
Some changes to apply consistent formatting for how methods are referred to in rule source validation error messages, plus applied consistent capitalization for the error messages.

+review REVIEW-5739

    • -2
    • +3
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 16 more files in changeset.
More improvements to validation of a RuleSource type.

- Fixed NPE when a rule method has no parameters.

- Collect more kinds of validation failures, rather than failing on first of these kinds of failures.

- Validate that the first parameter of a `@Rules` metod is assignable to `RuleSource`

+review REVIEW-5739

    • -1
    • +2
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 19 more files in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -8
    • +8
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 30 more files in changeset.
Reimplements the format of rule binding errors - removes file seperator from build script location

+review REVIEW-5556

    • -4
    • +5
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 29 more files in changeset.
Improves the format of model rule bind exceptions * Adds release notes for recent model changes * Normalizes line separotors to be consistent with InProcessGradleExecuter * Removes an unused class

+review REVIEW-5556

    • -4
    • +6
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 14 more files in changeset.
Renames mutable & immutable to subject & inputs, respectively - Adds some options to the spec

+review

    • -2
    • +2
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 9 more files in changeset.
Shows more concise names for rule source method rules

+review

    • -4
    • +4
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 32 more files in changeset.
Remove some obsolete imports in integration tests.

+review REVIEW-5491

    • -12
    • +0
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 41 more files in changeset.
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

    • -5
    • +5
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 117 more files in changeset.
Wrap exceptions thrown by self closing task container and realizing tasks when selecting tasks for execution in ProjectConfigurationException

+review REVIEW-5370

    • -1
    • +1
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 20 more files in changeset.
Don't graph-close task container model node when selecting tasks for execution

+review REVIEW-5370

    • -1
    • +1
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 37 more files in changeset.
More test coverage for applying rule sources in scope of collection elements.

+review REVIEW-5353

    • -0
    • +166
    ./ScopedRuleSourceIntegrationTest.groovy
  1. … 6 more files in changeset.