RuleSourceAppliedByRuleMethodIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -4
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 26 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 26 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 26 more files in changeset.
Make software model tasks accessible using abbreviated names again

This was broken by a refactoring towards lazy task configuration,

because we had no test coverage for this case.

    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 4 more files in changeset.
Change `DefaultNamedDomainObjectCollection` to better handle elements added using a provider, in particular when locating elements by name.

Change `DefaultTaskContainer` to use this to implement `createLater()` rather than the existing placeholder actions, to make deferred task creation less of a special case.

    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 9 more files in changeset.
Use the correct, immutable, view for @RuleInput properties attached to a RuleSource when running a rule method from the RuleSourec.

    • -0
    • +66
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 2 more files in changeset.
Use parameter types in method descriptor

+review REVIEW-5921

    • -1
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 27 more files in changeset.
Fix integration test

+review REVIEW-5921

    • -2
    • +2
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Format test sources for readability

    • -378
    • +380
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Fixed a couple of typos in test names

    • -2
    • +2
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Added `@RuleTarget` annotation, which can be attached to a `RuleSource` property to denote the target for the rule source.

+review REVIEW-5756

    • -1
    • +87
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 6 more files in changeset.
Treat `@RuleInput` properties on `RuleSource` types as references to implicit inputs for all rules on the rule source.

Moved responsibility for applying a rule to a particular scope up from `ModelRegistry` to `ModelRuleExtractor`. Now, all `RuleAction` instances applied to a `ModelRegistry` are applied relative to the root element, and it is the caller's responsibility to scope the action as required before registering it.

+review REVIEW-5756

    • -0
    • +69
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 16 more files in changeset.
Retain the property values specified on a `RuleSource` when it is defined by a `@Rules` rule, so that the values are available when rules on the `RuleSource` are executed.

Currently a lot of validation missing. Also these property values are not treated as inputs to the rules, they are currently simply treated as values to ship across to the rules.

+review REVIEW-5756

    • -4
    • +1
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 3 more files in changeset.
Generate an implementation for abstract properties on `RuleSource` classes.

These implementations don't do anything useful and the values are discarded once the current method returns.

+review REVIEW-5756

    • -3
    • +7
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 4 more files in changeset.
Some very initial support for input properties on a `RuleSource` implementation.

Property getters and setters can be declared, but they don't do anything other than fail at the moment. This change really just removes some validation, pending a more robust implementation.

+review REVIEW-5756

    • -0
    • +52
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 5 more files in changeset.
Fix up `equals()` and `hashCode()` implementation for abstract `RuleSource` instances.

Also added some coverage for these methods on model element views.

+review REVIEW-5756

    • -0
    • +3
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 6 more files in changeset.
Fix up `toString()` implementation for abstract `RuleSource` instances.

Reworked `ManagedProxyFactory` to support views of things that may only have state (eg abstract `RuleSource`) and views of things that may have state plus identity (eg views of model elements).

+review REVIEW-5756

    • -0
    • +3
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 7 more files in changeset.
Some initial support for abstract `RuleSource` implementations.

+review REVIEW-5756

    • -2
    • +0
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 6 more files in changeset.
Reuse the logic for creating a `RuleSource` instance in a couple of locations: when invoking an instance rule method, and when supplying an instance as a parameter to a `@Rule` method.

+review REVIEW-5756

    • -0
    • +33
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 7 more files in changeset.
Changed handling of `@Rules` methods so that the requested `RuleSource` type is validated prior to execution of the rule method.

This validation could potentially happen as part of inspection of the defining `RuleSource` type, as all the details are statically available at that time.

+review REVIEW-5756

    • -1
    • +4
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 1 more file in changeset.
Added some test coverage for rule sources applied by a `@Rules` method.

+review REVIEW-5756

    • -1
    • +109
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Added some more test coverage for `@Rules` methods.

+review REVIEW-5739

    • -1
    • +111
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
Renamed a couple of test classes.

+review REVIEW-5739

    • -0
    • +123
    ./RuleSourceAppliedByRuleMethodIntegrationTest.groovy
  1. … 3 more files in changeset.