PluginRuleSourceIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Renamed a test class.

+review REVIEW-5756

    • -407
    • +0
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 1 more file in changeset.
Some changes to apply consistent formatting for how methods are referred to in rule source validation error messages, plus applied consistent capitalization for the error messages.

+review REVIEW-5739

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 16 more files in changeset.
Collect all validation problems when inspecting a `RuleSource` type, rather than failing on the first problem.

Reuses the same validation problem collection and formatting logic that is used for those problems found while inspecting rule source instances provided for dependency resolution rules, making the behaviour for both kinds of rule source a little more consistent.

+review REVIEW-5739

    • -4
    • +8
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 9 more files in changeset.
Require that rule methods in a `RuleSource` must not be private, and that all methods that are not rule methods must be private.

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 5 more files in changeset.
Replaced a bunch of usages of `$('p')` with `$.p`

    • -4
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 32 more files in changeset.
Changed the descriptor for DSL rules so that it more closely matches the expression used in the code to reference the subject.

This change also detangles the subject path from the DSL rule descriptor, so that they can be different.

    • -5
    • +7
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 25 more files in changeset.
Rename ModelRegistry.create() to register() +review REVIEW-5678

    • -1
    • +1
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 67 more files in changeset.
Remove test fixture that enables transformed model rules DSL. Not required any more.

    • -5
    • +0
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 43 more files in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -4
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 30 more files in changeset.
Shows more concise names for rule source method rules

+review

    • -4
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 32 more files in changeset.
Remove some obsolete imports in integration tests.

+review REVIEW-5491

    • -28
    • +0
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 41 more files in changeset.
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

    • -4
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 117 more files in changeset.
Wrap exceptions thrown by self closing task container and realizing tasks when selecting tasks for execution in ProjectConfigurationException

+review REVIEW-5370

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 20 more files in changeset.
Don't graph-close task container model node when selecting tasks for execution

+review REVIEW-5370

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 37 more files in changeset.
Change rule source marking from annotation to base class

+review REVIEW-5359

    • -30
    • +15
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 73 more files in changeset.
Move model registry validation (as it is) to the point where we realize the task container.

This follows the precedent of CoD in that configuration problems in projects that aren't required won't surface.

This is also not the final state of meta model validation, but restores some parity after recent selective task closing changes.

+review REVIEW-5335

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 24 more files in changeset.
Realize the task container on demand.

+review REVIEW-5335

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 21 more files in changeset.
Revert selective task closing work.

Too much breakage.

+review REVIEW-5350

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 67 more files in changeset.
Wire the model registry into the “task selector”, effectively enabling configure-on-demand for rule based task declarations.

Rather than eagerly “realize” the whole task container and its contents, we now only realize the container itself.

This means that we know of all the tasks that will exist without actually creating them.

If a task (declared by rules) is not needed for a build (i.e. not selected, not depended on) it will not be created.

However, our rule based plugins at this time contain coarse rules that don't allow this feature to be leveraged.

Benefits will only be seen right now for contrived domains.

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 63 more files in changeset.
Eagerly instantiate rule source classes at extraction time to make sure that it can be done

+review REVIEW-5341

    • -0
    • +24
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 3 more files in changeset.
Added a root node to the model graph and cleaned up MutableModelNode so that links are always added using a ModelCreator.

This means all graph additions are done by linking a node from another node, and so we can apply consistent validation and behaviour.

    • -2
    • +2
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 10 more files in changeset.
Tweak to int test

    • -13
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
Remove AppliedPlugins and make PluginManager the public replacement for PluginContainer.

+review REVIEW-5298

    • -1
    • +1
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 97 more files in changeset.
Add apply(String) and apply(Class) to PluginAware.

+review REVIEW-5298

    • -1
    • +1
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 69 more files in changeset.
Allow properties of managed elements to be targeted.

This is a rather naive, inefficient, implementation. It will be later optimized without changing the user behaviour.

+review REVIEW-5264

    • -1
    • +1
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 5 more files in changeset.
Enforce that all parameterized type usages are declared with type parameters in model rules.

+review REVIEW-5283

    • -4
    • +4
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 4 more files in changeset.
Don't implement Plugin in rule sources used in tests if it's not necessary

+review REVIEW-5239

    • -59
    • +23
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 7 more files in changeset.
Avoid deprecated apply plugin

    • -1
    • +1
    ./PluginRuleSourceIntegrationTest.groovy
Plugin creates model element of custom, composite, type without supplying an implementation

+review REVIEW-5233

    • -44
    • +0
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 18 more files in changeset.
Add support for model creation rules providing instances of managed types

+review REVIEW-5226

    • -0
    • +44
    ./PluginRuleSourceIntegrationTest.groovy
  1. … 12 more files in changeset.