ModelRuleBindingFailureIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -7
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 26 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 26 more files in changeset.
Annotate integ tests failing with instant execution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 26 more files in changeset.
Use parameter types in method descriptor

+review REVIEW-5921

    • -13
    • +13
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 27 more files in changeset.
Removed deprecated `CollectionBuilder` and `ManagedSet` types.

    • -1
    • +0
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 19 more files in changeset.
Replaced a bunch of usages of `$('p')` with `$.p`

    • -5
    • +5
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 32 more files in changeset.
Changed the descriptor for DSL rules so that it more closely matches the expression used in the code to reference the subject.

This change also detangles the subject path from the DSL rule descriptor, so that they can be different.

    • -5
    • +5
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 25 more files in changeset.
Remove test fixture that enables transformed model rules DSL. Not required any more.

    • -5
    • +0
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 43 more files in changeset.
Delay defining node projections, take 2

+review REVIEW-5635

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 19 more files in changeset.
Revert "Postpone defining node projections until needed"

This reverts commit 6cc63413b1af2a95a613d825318339d46f6ad278.

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 18 more files in changeset.
Postpone defining node projections until needed

+review REVIEW-5635

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 18 more files in changeset.
Postpone defining node projections until needed

+review REVIEW-5635

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 18 more files in changeset.
Handle a null reference in the path for a rule input or subject, and report a binding failure (instead of NPE).

    • -0
    • +61
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 1 more file in changeset.
Added more coverage for reporting unbound rules.

    • -36
    • +74
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 1 more file in changeset.
Tweaks to model rule binding failure error message format.

+review REVIEW-5556

    • -53
    • +45
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 30 more files in changeset.
Reimplements the format of rule binding errors - removes file seperator from build script location

+review REVIEW-5556

    • -24
    • +30
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 29 more files in changeset.
Renames test case

+review REVIEW-5556

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
Improves the format of model rule bind exceptions * Adds release notes for recent model changes * Normalizes line separotors to be consistent with InProcessGradleExecuter * Removes an unused class

+review REVIEW-5556

    • -16
    • +61
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 14 more files in changeset.
Renames mutable & immutable to subject & inputs, respectively - Adds some options to the spec

+review

    • -6
    • +6
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 9 more files in changeset.
Updates model tests to use relative path to build file

+review REVIEW-5552

    • -2
    • +2
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 4 more files in changeset.
Shows more concise names for rule source method rules

+review

    • -7
    • +7
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 32 more files in changeset.
Reworked handling of rules that define rules so that elements are not created in order to do validation of unbound rules.

    • -1
    • +5
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 15 more files in changeset.
Allow the calculation of inputs for a DSL model rule to be deferred until the subject is known. Includes some regressions in validation of unbound rules and eagerly creates unmanaged elements during validation. Will be fixed later.

    • -7
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 8 more files in changeset.
Remove some obsolete imports in integration tests.

+review REVIEW-5491

    • -12
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 41 more files in changeset.
Extracted out a class to mediate all rule subject and input binding. Allows the incoming rules for a given (node,state) to be determined, which is required to support rule inputs that are not fully closed.

Two impacts of this change: binding validation is now more eager, and rules with the same (node,state) subject are executed in a fix, but arbitrary order. Happens to be by-path rules in order defined followed by by-type rules in order defined.

    • -1
    • +1
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 10 more files in changeset.
Introduce ModelMap extends CollectionBuilder and allow to use them interchangeably in rules

+review REVIEW-5491

    • -1
    • +2
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 117 more files in changeset.
Sort unbound rules by descriptor string, alphabetically, before rendering to screen.

    • -4
    • +4
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 1 more file in changeset.
Mutation rules are always executed in a reliable order

+review REVIEW-5384

    • -1
    • +0
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 8 more files in changeset.
Validate model rule bindings just before beginning execution, and only for projects that have to-be-executed tasks.

+review REVIEW-5370

    • -0
    • +11
    ./ModelRuleBindingFailureIntegrationTest.groovy
  1. … 3 more files in changeset.