Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Improve error messages for missing credentials prerequisites

    • -5
    • +6
    ./CredentialsProviderIntegrationTest.groovy
  1. … 5 more files in changeset.
Extract build prerequisite interface

    • -0
    • +2
    ./CredentialsProviderIntegrationTest.groovy
  1. … 7 more files in changeset.
Remove debugging printouts from a test

    • -10
    • +0
    ./CredentialsProviderIntegrationTest.groovy
Use ValueSource providers to supply credentials (WIP)

    • -3
    • +13
    ./CredentialsProviderIntegrationTest.groovy
  1. … 4 more files in changeset.
Merge remote-tracking branch 'origin/release'

* origin/release:

When instrumenting build logic, discard any files which cannot be opened as a Jar.

Increase parallelism in test

Fix race conditions in credentials providers when evaluated during execution

    • -0
    • +43
    ./CredentialsProviderIntegrationTest.groovy
Increase parallelism in test

    • -3
    • +5
    ./CredentialsProviderIntegrationTest.groovy
Fix race conditions in credentials providers when evaluated during execution

Credentials providers will be evaluated at execution time possibly in a multi-threaded environment if they are not declared as task inputs and not validated before execution.

This change uses thread-safe collections for storing credentials providers and synchronizes their evaluation. Evaluation part is synchronized because error messages may be constructed there and error messages are assembled from possibly multiple missing properties - we don't want them duplicated and we want to have a deterministic order when missing properties are reported.

    • -0
    • +79
    ./CredentialsProviderIntegrationTest.groovy
  1. … 1 more file in changeset.
Fix race conditions in credentials providers when evaluated during execution

Credentials providers will be evaluated at execution time possibly in a multi-threaded environment if they are not declared as task inputs and not validated before execution.

This change uses thread-safe collections for storing credentials providers and synchronizes their evaluation. Evaluation part is synchronized because error messages may be constructed there and error messages are assembled from possibly multiple missing properties - we don't want them duplicated and we want to have a deterministic order when missing properties are reported.

    • -0
    • +41
    ./CredentialsProviderIntegrationTest.groovy
  1. … 1 more file in changeset.
Fix race conditions in credentials providers when evaluated during execution

Credentials providers will be evaluated at execution time possibly in a multi-threaded environment if they are not declared as task inputs and not validated before execution.

This change uses thread-safe collections for storing credentials providers and synchronizes their evaluation. Evaluation part is synchronized because error messages may be constructed there and error messages are assembled from possibly multiple missing properties - we don't want them duplicated and we want to have a deterministic order when missing properties are reported.

    • -0
    • +79
    ./CredentialsProviderIntegrationTest.groovy
  1. … 1 more file in changeset.
Add an ignored test that asserts for credentials not being serialized to configuration cache

This replicates an issue we want to fix. How to fix it still needs to be explored.

    • -1
    • +36
    ./CredentialsProviderIntegrationTest.groovy
Remove unnecessary @Unroll annotations from "model"

    • -7
    • +0
    ./CollectionPropertyIntegrationTest.groovy
  1. … 31 more files in changeset.
Remove unnecessary @Unroll annotations from "model"

    • -7
    • +0
    ./CollectionPropertyIntegrationTest.groovy
  1. … 31 more files in changeset.
Remove unnecessary @Unroll annotations from "model"

    • -7
    • +0
    ./CollectionPropertyIntegrationTest.groovy
  1. … 31 more files in changeset.
Remove unnecessary @Unroll annotations from "model"

    • -7
    • +0
    ./CollectionPropertyIntegrationTest.groovy
  1. … 31 more files in changeset.
Remove unnecessary @Unroll annotations from "model"

    • -7
    • +0
    ./CollectionPropertyIntegrationTest.groovy
  1. … 31 more files in changeset.
Document ToBeFixed cause in CredentialsProviderIntegrationTest

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +1
    ./CredentialsProviderIntegrationTest.groovy
Remove `@ToBeFixedForInstantExecution` from `CredentialsProviderIntegrationTest`

    • -2
    • +2
    ./CredentialsProviderIntegrationTest.groovy
Introduce `zip` directly on `Provider`

This commit makes it possible to create a zipped provider from any

provider. It realies on the fact that all providers internally

implement `ProviderInternal`, where we can actually supply a default

method implementation which returns a zipped provider.

This commit also adds some test coverage for zipped provider.

  1. … 3 more files in changeset.
Introduce `zip` directly on `Provider`

This commit makes it possible to create a zipped provider from any

provider. It realies on the fact that all providers internally

implement `ProviderInternal`, where we can actually supply a default

method implementation which returns a zipped provider.

This commit also adds some test coverage for zipped provider.

  1. … 3 more files in changeset.
Introduce `ProviderFactory#zip`

This method takes two providers, a function which arguments

are the types of the providers and returns a new provider

which value is computed using the combiner function. The

potential dependencies of the inputs are tracked.

This allows binding providers together and facilitates

computation of values which depend on the value of two

providers.

Currently there's only a zip function taking a pair

of providers.

It would be nicer to have this method on `Provider` directly

so that we don't have to call the provider factory, but

the required infrastructure isn't available at this location

in the code.

See #12974

  1. … 6 more files in changeset.
Fix integration test

    • -2
    • +2
    ./CredentialsProviderIntegrationTest.groovy
Document reason for @ToBeFixedForInstantExecution in :modelCore

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./AbstractPropertyLanguageInterOpIntegrationTest.groovy
Expose Credentials providers via ProviderFactory

    • -0
    • +229
    ./CredentialsProviderIntegrationTest.groovy
  1. … 30 more files in changeset.
Fix PropertyIntegrationTest for the configuration cache

by using a system property provider in the build under test

Signed-off-by: Paul Merlin <paul@gradle.com>

Fix for previous commit.

Correctly serialize a `Property` instance with finalize on read enabled and whose value is derived from a task output.

  1. … 3 more files in changeset.
Work around a race condition in `DefaultConfiguration` that is exposed when visiting the task dependencies of a `Configuration` while also visiting the files of the same `Configuration` instance.

This does not fix the race condition, but simply makes it less likely to have an effect. The underlying issue can be fixed later.

  1. … 1 more file in changeset.
Work around a race condition in `DefaultConfiguration` that is exposed when visiting the task dependencies of a `Configuration` while also visiting the files of the same `Configuration` instance.

This does not fix the race condition, but simply makes it less likely to have an effect. The underlying issue can be fixed later.

  1. … 1 more file in changeset.
Work around a race condition in `DefaultConfiguration` that is exposed when visiting the task dependencies of a `Configuration` while also visiting the files of the same `Configuration` instance.

This does not fix the race condition, but simply makes it less likely to have an effect. The underlying issue can be fixed later.

  1. … 1 more file in changeset.
Work around an issue where a `Property` instance may have multiple threads attempting to finalize its value.

  1. … 1 more file in changeset.