Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moved `o.g.messaging.*` to `o.g.internal.*`.

    • -79
    • +0
    ./hub/DefaultMethodArgsSerializer.java
  1. … 281 more files in changeset.
Changed `ObjectConnection` contract to allow handlers to be notified of the end of the stream of messages. The handler can then deal with missing messages rather than wait forever.

    • -5
    • +28
    ./hub/MessageHubBackedObjectConnection.java
    • -36
    • +0
    ./hub/protocol/ConnectionClosed.java
    • -36
    • +0
    ./hub/protocol/ConnectionEstablished.java
  1. … 11 more files in changeset.
Fixed single use worker processes so that it actually works.

Previously would hang when used from a plugin. Also improved handling to get rid of the hang when the worker process crashes for some reason.

    • -0
    • +5
    ./hub/MessageHubBackedObjectConnection.java
  1. … 6 more files in changeset.
Fixed case where worker process protocol method has a parameter of an array type.

  1. … 1 more file in changeset.
Reduced the serialized size of messages sent between build and worker processes. Includes test execution events.

    • -0
    • +79
    ./hub/DefaultMethodArgsSerializer.java
    • -0
    • +62
    ./hub/JavaSerializationBackedMethodArgsSerializer.java
    • -11
    • +9
    ./hub/MessageHubBackedObjectConnection.java
    • -0
    • +23
    ./hub/MethodArgsSerializer.java
    • -40
    • +52
    ./hub/MethodInvocationSerializer.java
  1. … 12 more files in changeset.
Changed `RemoteConnection` so that clients have explicit control over when buffered messages are forwarded to the client. Use this in `MessageHub` (used between build process and worker processes) to flush only after it has written a batch of messages, rather than after each message.

    • -2
    • +2
    ./hub/MessageHubBackedObjectConnection.java
  1. … 9 more files in changeset.
Changed contract of `OutgoingConnector` and `IncomingConnector` so that consumer cannot request that a particular encoder/decoder be used.

Allow the implementation more control over buffering of encoded messages, and none of the consumers care about the encoder or decoder.

    • -9
    • +6
    ./hub/MessageHubBackedObjectConnection.java
  1. … 5 more files in changeset.
Removed some unused parameters.

  1. … 1 more file in changeset.
Removed methods that request that Java serialization be used for messages sent across a connection.

Still happens to be the default in the case of `ObjectConnection`, which is used to talk to worker processes.

    • -4
    • +0
    ./hub/MessageHubBackedObjectConnection.java
  1. … 2 more files in changeset.
`Connection` does not need a `requestStop()` method, as it is never used.

  1. … 6 more files in changeset.
Javadocs.

  1. … 1 more file in changeset.
Removed some more unused classes.

    • -33
    • +0
    ./protocol/RouteAvailableMessage.java
    • -20
    • +0
    ./protocol/RouteUnavailableMessage.java
Removed unused field.

Removed a bunch of classes that are no longer used.

  1. … 75 more files in changeset.
Extracted a `Serializer` implementation for `MultiChoiceAddress` out of the daemon startup stuff.

    • -0
    • +54
    ./inet/MultiChoiceAddressSerializer.java
  1. … 7 more files in changeset.
Increase buffer size, don't flush entirely when buffer fills up

Only use OP_WRITE selector when socket write buffer is full

- attempt to fix daemon connection problems on Windows

Don't retry to connect on self bind, as a self bind means there's nothing listening on the destination address.

    • -10
    • +12
    ./inet/TcpOutgoingConnector.java
Fix review items

+review REVIEW-5610

GRADLE-2316 Detect TCP self-connect and retry connection

When attempting to connect to the daemon, if the daemon has not bound

to the port, there is a small chance that the OS may attempt to bind and

connect to the same port. When this happens, data written to this socket

is "reflected" back on the receiving side.

This change attempts to detect that by comparing the local and remote

addresses. If they are the same, we assume that we have self-connected

and need to retry the connection. Since ports are assigned sequentially

most of the time, this should work on the second retry.

+review REVIEW-5610

  1. … 1 more file in changeset.
GRADLE-2316 Detect TCP self-connect and retry connection

When attempting to connect to the daemon, if the daemon has not bound

to the port, there is a small chance that the OS may attempt to bind and

connect to the same port. When this happens, data written to this socket

is "reflected" back on the receiving side.

This change attempts to detect that by comparing the local and remote

addresses. If they are the same, we assume that we have self-connected

and need to retry the connection. Since ports are assigned sequentially

most of the time, this should work on the second retry.

+review REVIEW-5610

  1. … 1 more file in changeset.
Add timeout when connecting to socket

- fixes TcpConnectorTest on OS X Yosemite

Renamed and moved a couple of classes.

    • -1
    • +1
    ./hub/MessageHubBackedObjectConnection.java
  1. … 12 more files in changeset.
Don't log stacktrace for discarded exception.

Tightened up the contract for Serializer and friends wrt exceptions thrown when unexpected end of stream is found, and tweaked SocketConnection to understand this.

Should allow the switch to kryo based serialization for the client - daemon connection.

  1. … 5 more files in changeset.
Busted up a class into two pieces

    • -0
    • +60
    ./KryoBackedMessageSerializer.java
    • -19
    • +12
    ./hub/InterHubMessageSerializer.java
    • -5
    • +7
    ./hub/MessageHubBackedObjectConnection.java
  1. … 2 more files in changeset.
Changed TestEventSerializer so that it provides a Serializer rather than a StatefulSerializer.

    • -8
    • +13
    ./hub/MessageHubBackedObjectConnection.java
  1. … 13 more files in changeset.
Renamed package o.g.messaging.serialize to o.g.internal.serialize.

    • -3
    • +3
    ./hub/MessageHubBackedObjectConnection.java
    • -2
    • +2
    ./protocol/DiscoveryProtocolSerializer.java
  1. … 165 more files in changeset.
GRADLE-3180 - Consider Openshift environment when determining available local addresses. Remove unnecessary services wiring from previous implementation.

+review REVIEW-5393

  1. … 2 more files in changeset.
GRADLE-3180 - Detect Openshift environment when creating outgoing connection.

+review REVIEW-5393

  1. … 2 more files in changeset.