Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./logging/text/TestStyledTextOutputFactory.java
  1. … 1005 more files in changeset.
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./logging/text/TestStyledTextOutputFactory.java
  1. … 999 more files in changeset.
Rename class TestLineChoppingStyledTextOutput to fix spelling

Signed-off-by: Bo Zhang <bo@gradle.com>

    • -43
    • +0
    ./logging/text/TestLineChoppingStyledTextOuput.groovy
    • -0
    • +43
    ./logging/text/TestLineChoppingStyledTextOutput.groovy
spelling: output

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -1
    • +1
    ./logging/text/TestLineChoppingStyledTextOuput.groovy
  1. … 2 more files in changeset.
Implement `--dry-run` for rich console

    • -1
    • +1
    ./logging/text/TestStyledTextOutputFactory.java
  1. … 5 more files in changeset.
Bind lifecycle of level and OutputEventListener in ConfigureLogging rule

This is a followup to 8fd0c8bd1f72a1ce2513efce354c34ecbc5d7e04 to

attempt at fixing flakiness issue due to MemoryManager debug messages

emitted to a test listener only interested in >info messages.

The ConfigureLogging rule constructor now accepts a LogLevel to prevent

a race condition where logging level is set later, e.g. by a

@Before/setup method or directly in a test, possibly calling the

OutputEventListener with unwanted events.

  1. … 1 more file in changeset.
Fix issue gradle/gradle#1566 (#1576)

The state machine for `AbstractLineChoppingStyledTextOutput` was

redesigned to consider *nix, Windows and Mac OS 9 non-system newline.

Printing to the console any text with those end-of-line chars will

detect a newline been written.

    • -0
    • +43
    ./logging/text/TestLineChoppingStyledTextOuput.groovy
  1. … 3 more files in changeset.
Revert `BatchOutputEventListener` in preference to more localized change

    • -2
    • +2
    ./logging/CollectingTestOutputEventListener.groovy
    • -2
    • +2
    ./logging/TestOutputEventListener.groovy
  1. … 15 more files in changeset.
Draft parallel console implementation

This allows Gradle to show multiple items in progress when attached

to an interactive terminal.

This is achieved by:

First, breaking apart ConsoleBackedProgressRenderer into 3 filters:

- ThrottlingOutputEventListener buffers OutputEvents and flushes

them after a certain period of time or if the build has ended

- BuildStatusRenderer maintains a Label that displays overall

build progress (formerly the "status bar")

- WorkInProgressRenderer maintains a BuildProgressArea and

associates one branch of a ProgressOperations "tree" to a Label

representing work in progress for multiple workers.

Second, externalizing and enhancing concepts within AnsiConsole:

- Cursor represents a position in the terminal, using a cartesian

coordinate system with origin (0, 0) at the bottom left

- MultiLineProgressArea is a TextArea implementation with

addressible lines through Labels.

- Style represents ANSI text colors and emphases.

- Span is simply an association between a Style and String of

text.

- AnsiExecutor is an ANSI-aware text writer. It accepts Actions

that may reposition the Cursor and write styled text

Finally, logging improvements. Project evaluation logging was

extracted from build progress logging. Build progress logs are

formatted with a ProgressBar formatter and submitted through

the same ProgressOperations mechanism. These ProgressOperations

are selected by the BuildStatusRenderer and rendered separately

from other ProgressOperations for now. In the future, we will

have must stronger semantics around this using BuildOperations.

Issue: gradle/gradle-private#649

    • -2
    • +2
    ./logging/CollectingTestOutputEventListener.groovy
    • -2
    • +2
    ./logging/TestOutputEventListener.groovy
  1. … 66 more files in changeset.
Add more test coverage for logging in worker processes

    • -3
    • +1
    ./logging/TestOutputEventListener.groovy
  1. … 9 more files in changeset.
fix test `workerProcessStdoutAndStderrIsForwardedToThisProcess`

    • -6
    • +15
    ./logging/TestOutputEventListener.groovy
  1. … 2 more files in changeset.
Address review feedback for #689

+review REVIEW-6216

  1. … 7 more files in changeset.
Polish logging stack of deprecation messages

#689

+review REVIEW-6216

    • -35
    • +0
    ./featurelifecycle/SimulatedDeprecationMessageLogger.java
    • -34
    • +0
    ./featurelifecycle/SimulatedGroovyCallLocation.groovy
    • -35
    • +0
    ./featurelifecycle/SimulatedJavaCallLocation.java
  1. … 5 more files in changeset.
Deprecation warning should print location in build file (#689)

    • -0
    • +29
    ./deprecated/DeprecatedPlugin.java
    • -0
    • +40
    ./deprecated/DeprecatedTask.java
    • -0
    • +35
    ./featurelifecycle/SimulatedDeprecationMessageLogger.java
    • -0
    • +34
    ./featurelifecycle/SimulatedGroovyCallLocation.groovy
    • -0
    • +35
    ./featurelifecycle/SimulatedJavaCallLocation.java
    • -0
    • +35
    ./logging/CollectingTestOutputEventListener.groovy
  1. … 12 more files in changeset.
Remove excessive output from `ConfigureLogging` (cherry picked from commit 32baad3)

Remove excessive output from `ConfigureLogging`

Attempt to fix `ConfigureLogging` rule

The `ConfigureLogging` rule is broken. It replaces the configured `OutputEventListener`

for the SLF4J logging system. Then, after the tests completes it resets the SLF4J logging

back to it's default state.

The `InProcessGradleExecuter` attaches a listener so that it can capture any logging output

created during a test build invocation. This is done only once for the global logging

system. The `ConfigureLogging` rule doesn't reattach this listener when it completes

so any subsequent test will not have some missing log events when executing builds with `InProcessGradleExecuter`.

This change causes `ConfigureLogging` to reinstate the original `OutputEventListener` when resetting the logging.

Fix stupid mistake in logging experiment

Attempt to fix `ConfigureLogging` rule

The `ConfigureLogging` rule is broken. It replaces the configured `OutputEventListener`

for the SLF4J logging system. Then, after the tests completes it resets the SLF4J logging

back to it's default state.

The `InProcessGradleExecuter` attaches a listener so that it can capture any logging output

created during a test build invocation. This is done only once for the global logging

system. The `ConfigureLogging` rule doesn't reattach this listener when it completes

so any subsequent test will not have some missing log events when executing builds with `InProcessGradleExecuter`.

This change causes `ConfigureLogging` to reinstate the original `OutputEventListener` when resetting the logging.

Fix stupid mistake in logging experiment

(cherry picked from commit 8fd0c8b)

Moved more classes to live with the logging text output classes.

    • -80
    • +0
    ./logging/TestStyledTextOutput.groovy
    • -55
    • +0
    ./logging/TestStyledTextOutputFactory.java
    • -0
    • +79
    ./logging/text/TestStyledTextOutput.groovy
    • -0
    • +52
    ./logging/text/TestStyledTextOutputFactory.java
  1. … 58 more files in changeset.
Moved progress logging and styled text logging interfaces to live in their own packages.

    • -0
    • +2
    ./logging/TestStyledTextOutputFactory.java
  1. … 154 more files in changeset.
Moved the slf4j bridging classes to live in o.g.internal.logging.slf4j.

  1. … 16 more files in changeset.
Moved logging events to live in their own package.

    • -3
    • +3
    ./logging/TestOutputEventListener.groovy
  1. … 76 more files in changeset.
Moved logging test fixtures from 'core' to 'logging' project.

    • -0
    • +63
    ./logging/ConfigureLogging.groovy
    • -0
    • +44
    ./logging/TestOutputEventListener.groovy
    • -0
    • +80
    ./logging/TestStyledTextOutput.groovy
    • -0
    • +53
    ./logging/TestStyledTextOutputFactory.java
  1. … 46 more files in changeset.