Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +51
    ./DefaultContextAwareTaskLogger.java
    • -0
    • +62
    ./OutputEventListenerBackedLogger.java
    • -0
    • +1
    ./OutputEventListenerBackedLoggerContext.java
  1. … 1002 more files in changeset.
Add missing @Override to all modules

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +51
    ./DefaultContextAwareTaskLogger.java
    • -0
    • +62
    ./OutputEventListenerBackedLogger.java
    • -0
    • +1
    ./OutputEventListenerBackedLoggerContext.java
  1. … 996 more files in changeset.
Get a better error message if we can't cast the Logger appropriately

Address review feedback

- more test coverage on using task logger after task has been executed

- minor code polishing

    • -3
    • +1
    ./OutputEventListenerBackedLogger.java
  1. … 1 more file in changeset.
Some cleanup on removing unrequired methods

    • -7
    • +0
    ./OutputEventListenerBackedLogger.java
  1. … 1 more file in changeset.
Handle KotlinCompile task logger decoration

    • -0
    • +24
    ./ContextAwareTaskLogger.java
    • -0
    • +481
    ./DefaultContextAwareTaskLogger.java
  1. … 4 more files in changeset.
Handle KotlinCompile task logger decoration

    • -0
    • +481
    ./DefaultContextAwareTaskLogger.java
  1. … 4 more files in changeset.
Rework task logger build id decoration

    • -0
    • +27
    ./BuildOperationAwareLogger.java
    • -0
    • +481
    ./ContextAwareBuildLogger.java
    • -11
    • +2
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Rework task logger build id decoration

    • -11
    • +2
    ./OutputEventListenerBackedLogger.java
  1. … 5 more files in changeset.
Use logger per task instance

    • -5
    • +4
    ./OutputEventListenerBackedLogger.java
  1. … 5 more files in changeset.
Use logger per task instance

    • -5
    • +4
    ./OutputEventListenerBackedLogger.java
  1. … 5 more files in changeset.
Handle threaded task logging for parallel executed tasks

    • -5
    • +18
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Handle threaded task logging for parallel executed tasks

    • -5
    • +18
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Decorate task logger with build operation id so usage from external thread is linked to correct task

    • -0
    • +9
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Decorate task logger with build operation id so usage from external thread is linked to correct task

    • -0
    • +9
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Decorate task logger with build operation id so usage from external thread is linked to correct task

    • -3
    • +15
    ./OutputEventListenerBackedLogger.java
  1. … 5 more files in changeset.
Decorate task logger with build operation id so usage from external thread is linked to correct task

    • -3
    • +15
    ./OutputEventListenerBackedLogger.java
  1. … 5 more files in changeset.
Decorate task logger with build operation id so usage from external thread is linked to correct task

    • -0
    • +9
    ./OutputEventListenerBackedLogger.java
  1. … 3 more files in changeset.
Remove log message that cannot be actioned by user

  1. … 1 more file in changeset.
Verify tests running in modular Java can access SLF4j

  1. … 7 more files in changeset.
Allow testing with `java.system.class.path` and SLF4j

The core `Slf4jLoggingConfigurer` assumes that the Gradle implementation

of `org.slf4j.ILoggerFactory` is being used. This is not the case when

tests are run using a custom system classloader (by setting the

`java.system.class.loader` system property).

Previously, this would result in a `ClassCastException` when attempting

to configure the logger. This change makes `Slf4jLoggingConfigurer` lenient

in this case, opting not to configure the underlying logger rather than

fail.

Fixes #2657

  1. … 4 more files in changeset.
Allow `StandardOutputListener` logging destinations to be added only from inside a build, and avoid setting up the pipeline that supports this in places where builds will not run, such as the client (except when --no-daemon), worker processes or tapi provider (except when in embedded mode).

    • -8
    • +2
    ./OutputEventListenerBackedLoggerContext.java
  1. … 12 more files in changeset.
Emit build operation progress events for logging output (#4537)

* Tweak BuildOperationListener#progress api

* Use build operation id to reference progress

* Add workaround for tracing log output via build operation progress for composite builds

* Replace some Object typing of operation identifiers with OperationIdentifier.

* Associate all progress logging with the current build operation.

* Update logic to accommodate for all progress events now having build operation IDs.

* Don't allow ProgressStartEvent.buildOperationCategory to be null.

** Default it to uncategorized.

    • -1
    • +2
    ./OutputEventListenerBackedLogger.java
  1. … 50 more files in changeset.
Rationalise handling of “current” build operation and build operation ID

For an upcoming change to emit console logging as build operation progress events, we need to associate all progress logging with the build operation. This pulled a thread on some long overdue cleanup.

The end result is:

1. Base build operation infrastructure is consolidated org.gradle.internal.operations.

2. Mechanism for passing thread global current build operation is more test friendly, and better named.

3. A consistent mechanism is used for binding the current operation to the thread, instead of two mechanisms.

4. Build operation IDs are typed to OperationIdentifier.

There is no public API or user behaviour change.

    • -4
    • +4
    ./OutputEventListenerBackedLogger.java
  1. … 147 more files in changeset.
Simplify time handling internally and for build scans (#2857)

* Don't make TimeProvider Serializable.

This isn't safe and generally doesn't make sense.

* Extract and promote the concept of a build timer.

This was previously not well defined and being overlaid with the concept of when a user/tool requested something, which is not always the same thing.

* Pare down the deprecated org.gradle.util.Clock down to the minimum required.

Internal usage is replaced by a `getStartTime()` directly on BuildRequestContext.

What is left is only kept for backwards compatibility with scans.

* Rename TimeProvider to Clock.

* Move BuildExecutionTimer out of baseServices into core, and into a better package.

* Remove unused.

* Simplify the time package by merging types.

* Prevent the client's build started timestamp from being later than when the provider received the build request.

* Provide a dedicated mechanism for conveying the build start time to build scans.

* Consolidate the ways of formatting durations.

    • -5
    • +5
    ./OutputEventListenerBackedLogger.java
    • -6
    • +6
    ./OutputEventListenerBackedLoggerContext.java
  1. … 178 more files in changeset.
Avoid creating a new TrueTimeProvider for OutputEventRenderer

    • -1
    • +1
    ./OutputEventListenerBackedLoggerContext.java
  1. … 4 more files in changeset.
Revert some logging changes

- Move OperationIdentifier back to logging and use Objects for

BuildOperation ids

- Remove log event builders and use plain constructors to avoid too

much garbage

    • -8
    • +4
    ./OutputEventListenerBackedLogger.java
  1. … 54 more files in changeset.
Mark log events with their associated build operation id

Use BuildOperationIdentifierRegistry in all of the places where

we generate renderable output events to set build operation id.

Serialize Operation identifiers coming from forked processes.

Use Builder pattern for constructing renderable output events to

avoid an explosion of constructors while maintaining forward

compatibility. (0 uses of StyledTextOutputEvent in non-forked

repos, so removed those constructors, they're internal anyway)

Reuse BuildOperation ids through progress logging where we

can.

Issue: #1611

    • -1
    • +7
    ./OutputEventListenerBackedLogger.java
  1. … 55 more files in changeset.
Moved `Clock` and `TimeProvider` into a separate package

This commit reverts recent changes to the API of

`org.gradle.util.Clock`, and instead deprecates the existing type

replacing with a new internal type. This was done because the

`ExtractDslMetaDataTask` uses this type for timing, and external plugins may have copied this pattern.

`org.gradle.util.Clock` is now deprecated.

    • -1
    • +1
    ./OutputEventListenerBackedLogger.java
    • -1
    • +1
    ./OutputEventListenerBackedLoggerContext.java
  1. … 102 more files in changeset.
GRADLE-3504 Fix support for logging formatted messages with an exception.

This fix is for a regression in Gradle 2.4. In Gradle versions 2.3 and earlier a logging statement like

so would include the passed exception stacktrace in the log. This is also consistent with SLF4J

logger behavior.

logger.error("This is a {} error", "bad", new Exception());

    • -3
    • +7
    ./OutputEventListenerBackedLogger.java
  1. … 1 more file in changeset.