PersistentDaemonRegistryTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Remove old entries with same port in daemon registry"

This reverts commit d32d0b7e33660dfb1a94ae9eea8238c793a4243e.

This was supposed to be done on master.

    • -24
    • +1
    ./PersistentDaemonRegistryTest.groovy
  1. … 2 more files in changeset.
Remove old entries with same port in daemon registry

This fixes https://github.com/gradle/gradle/issues/12530

Previously, when two daemons happen to allocate the same port, they

will both exist in daemon registry file, and client might connect

to the wrong one. By default, MultiChoiceAddress doesn't equal to

each other even with same port. This PR removes the old entry by

port.

    • -1
    • +24
    ./PersistentDaemonRegistryTest.groovy
  1. … 2 more files in changeset.
Remove old entries with same port in daemon registry

This fixes https://github.com/gradle/gradle/issues/12530

Previously, when two daemons happen to allocate the same port, they

will both exist in daemon registry file, and client might connect

to the wrong one. By default, MultiChoiceAddress doesn't equal to

each other even with same port. This PR removes the old entry by

port.

    • -1
    • +24
    ./PersistentDaemonRegistryTest.groovy
  1. … 2 more files in changeset.
Force AbstractTestDirectoryProvider to use Class (#12431)

Closes https://github.com/gradle/gradle-private/issues/2988

This PR adds `className` to `AbstractTestDirectoryProvider` so there'll be no more `unknown-test-class`.

  1. … 407 more files in changeset.
Fix tests

  1. … 372 more files in changeset.
Move Stat and Chmod to :files

  1. … 38 more files in changeset.
Move Stat and Chmod to :files

  1. … 38 more files in changeset.
Make daemon state visible in the registry

+review REVIEW-6160

  1. … 24 more files in changeset.
Log Daemon Stop Events uniquely by PID and severity. +review REVIEW-6078

  1. … 7 more files in changeset.
Improve readability for and address feedback on Daemon stopped messaging. +review REVIEW-5986

  1. … 6 more files in changeset.
Improving test coverage

+review REVIEW-5986

    • -1
    • +16
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.
Make daemon stop messaging more robust +review REVIEW-5986 * getting a snapshot of all daemons before connecting * using that snapshot for connecting and messaging * only removing DaemonStopEvents that were actually logged

  1. … 12 more files in changeset.
Properly clear Daemon stop events after display. +review REVIEW-5986

    • -1
    • +16
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.
Ensure that the daemon registry file and parent directory have read and write permission set only for the user.

  1. … 9 more files in changeset.
Changed the daemon to reject a build command that does not include the correct authentication token.

The authentication token is generated by the daemon on startup and written to the registry, and read from the registry by the client and passed back to the daemon in build/stop commands.

Note that the daemon and client currently do not take any steps to prevent the world reading (or writing) the registry beyond whatever the OS happens to do by default. This will be fixed in a later commit.

  1. … 38 more files in changeset.
Draft Notify user after daemon stopped due to unhealthiness +review REVIEW-5986

  1. … 23 more files in changeset.
Reinstate "Implement and test the LRU expiration strategy."

This reverts commit 2b9a76181b061922daea852a63b660c346689b66.

  1. … 17 more files in changeset.
Temporarily revert "Implement and test the LRU expiration strategy. This commit doesn't flip it on." to get CompositeDaemonExpirationStrategy class back.

This reverts commit 9458848597819f9c8e55631ba5289ca9c52ba369.

  1. … 17 more files in changeset.
Implement and test the LRU expiration strategy. This commit doesn't flip it on.

  1. … 17 more files in changeset.
Moved `o.g.messaging.*` to `o.g.internal.*`.

  1. … 295 more files in changeset.
Renamed org.gradle.internal.nativeplatform -> o.g.i.nativeintegration

  1. … 177 more files in changeset.
Don't blow up when this daemon's address has been removed from the registry by some other process.

    • -8
    • +26
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.
Some renaming and cleanup around the test/temp directory used in tests.

  1. … 308 more files in changeset.
Changed some unit tests to use mocks for the native services they need.

  1. … 2 more files in changeset.
Removing an address from daemon registry does not assert on registry not-empty.

    • -0
    • +12
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.
Daemon server tidy up. Added a shutdown hook to the server that removes the daemon from the registry. It's not critical but it is a decent thing to do :)

    • -1
    • +27
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.
Add the daemon entry to the registry and mark as busy as a single atomic operation, so that the daemon cannot be stolen by another client.

  1. … 8 more files in changeset.
GRADLE-2216 - If the daemon registry file is corrupt, ignore and treat it as empty.

    • -0
    • +76
    ./PersistentDaemonRegistryTest.groovy
  1. … 1 more file in changeset.