PropertiesToStartParameterConverterTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move responsibility for constructing a `StartParameter` from command-line options and properties into a single class.

    • -75
    • +0
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 23 more files in changeset.
Refine deprecation mechanism (#3285)

Refine deprecation mechanism

Fix https://github.com/gradle/gradle/issues/3228

    • -9
    • +9
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 35 more files in changeset.
Create build options only once

They are effectively immutable constants, so no need to

create them again and again in sevaral different places.

    • -12
    • +12
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 29 more files in changeset.
Polishing of Gradle build options (#2890)

    • -4
    • +4
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 32 more files in changeset.
Represent Gradle properties and corresponding command line option as data structure (#2784)

    • -11
    • +12
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 48 more files in changeset.
Add Gradle property for logging (#1927)

* Add global property

* Read new property to determine log level

* Document the new log.level property

* Review feedback

* Expand test coverage and make testing more explicit

    • -0
    • +31
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 7 more files in changeset.
Remove deprecated task caching system properties

+review REVIEW-6503

    • -1
    • +0
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 13 more files in changeset.
Introduce --build-cache command-line options

- Introduce --build-cache and --no-build-cache to enable build caches

- Replace isTaskOutputCacheEnabled with isBuildCacheEnabled

- Methods remain, but are deprecated

- Introduce org.gradle.buildcache to replace org.gradle.cache.tasks

- Update production code and tests to use new names

- Consolidate references to org.gradle.cache.tasks.push and pull

+review REVIEW-6451

    • -1
    • +2
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 20 more files in changeset.
Expose task output cache state in `StartParameter`

+review REVIEW-6213

    • -0
    • +1
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 6 more files in changeset.
Remove deprecated --parallel-threads command line option and StartParameters

+review REVIEW-6005

    • -1
    • +0
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 10 more files in changeset.
Tigther validation and better error messages when an invalid value is given for max workers.

+review REVIEW-5434

    • -1
    • +2
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 3 more files in changeset.
Fail when org.gradle.workers.max is set to something invalid

+review REVIEW-5434

    • -6
    • +8
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 1 more file in changeset.
Fix tests

+review REVIEW-5434

    • -1
    • +1
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 1 more file in changeset.
Separate native parallel compilation from parallel-threads

* Deprecate --parallel-threads, suggest using --parallel

* Deprecate get/setParallelThreadCount in StartParameter

* Introduce org.gradle.workers.max system property

* Introduce --workers command line option (incubating)

* Introduce get/setMaxWorkerCount in StartParameter (incubating)

* Introduce is/setParallelProjectExecutionEnabled in StartParameter (incubating)

* Have BuildOperationProcessor use max worker count

+review REVIEW-5434

    • -0
    • +4
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 11 more files in changeset.
Remove @author tags and names from source code.

- Added checkstyle check for @author

- Added not to CONTRIBUTING.md saying that we don't use names in the codebase

    • -3
    • +0
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 1213 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

    • -2
    • +2
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 13 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

(cherry picked from commit d21b4bc)

    • -2
    • +2
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 13 more files in changeset.
Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties).

1. The use case is that organisations may roll out incubating mode to all projects and don't want to confuse the end users (e.g. fear about the features that may be perceived incomplete, confusing request for feedback in the incubating message). So, if the incubating mode is explicitly configured in the gradle properties, we assume that the user knows what he is doing and need not be reminded about the incubating nature of the feature. (while writing this commit message it just occurred to me that this should be in the spec)

2. The implementation is not quite pretty, looking for suggestions on how to improve it.

    • -2
    • +2
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 13 more files in changeset.
REVIEW-1198 Refactored the commandline / properties conversion in order to tidy up the internals.

    • -0
    • +39
    ./PropertiesToStartParameterConverterTest.groovy
  1. … 27 more files in changeset.