PropertiesToDaemonParametersConverterTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Revert "Revert "Add debug support to TestLauncher (#9863)""

This reverts commit 17d0ec1ba0dd44df1a6e2e2f8e79c366faa2bee7.

    • -14
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 39 more files in changeset.
Revert "Add debug support to TestLauncher (#9863)"

This reverts commits 026d9f4f8b33e64a64fd0f9f4c364b4c7cebf26f and fda0f3d58074137a1e9204fbf2762d9f63a0603b.

Temporarily reverted due to a possible performance regression.

    • -0
    • +14
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 40 more files in changeset.
Add debug support to TestLauncher (#9863)

    • -14
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 39 more files in changeset.
Remove tests that no longer apply to the production code

    • -14
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 2 more files in changeset.
Remove tests that no longer apply to the production code

    • -14
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 2 more files in changeset.
Replace some direct usages of `DefaultConfigurableFileCollection` with `FileCollectionFactory`.

    • -1
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 50 more files in changeset.
Replace some direct usages of `DefaultConfigurableFileCollection` with `FileCollectionFactory`.

    • -1
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 50 more files in changeset.
Create build options only once

They are effectively immutable constants, so no need to

create them again and again in sevaral different places.

    • -17
    • +17
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 29 more files in changeset.
Unify error messages for Gradle build options (#2934)

Unify error messages for Gradle build options #2917

    • -5
    • +4
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 19 more files in changeset.
Represent Gradle properties and corresponding command line option as data structure (#2784)

    • -27
    • +17
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 48 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -0
    • +14
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 199 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -14
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 199 more files in changeset.
Fix bug when debugger doesn't get enabled

- when default debugger option is in jvm args, the debug flag gets

set and the option is removed from args (existing behaviour)

- the debug flag was getting overridden, this commit fixes that

    • -0
    • +14
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 1 more file in changeset.
Improve PropertiesToDaemonParametersConverter tests by flipping enabled=false to ensure we're not inadvertantly falling back to default of enabled=true. +review REVIEW-6000

    • -4
    • +4
    ./PropertiesToDaemonParametersConverterTest.groovy
Enable Gradle Daemon by default

    • -8
    • +7
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 21 more files in changeset.
Change periodiccheckinterval property name to healthcheckinterval

    • -9
    • +9
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 3 more files in changeset.
Daemon should exit when registry unavailable. REVIEW-5910

Allow periodic check interval to be set via CLI options.

Composite periodic check stops daemon if any expiration conditions

met, including idle timeout and registry unavailable.

    • -6
    • +18
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 24 more files in changeset.
Trim whitespace when matching on boolean properties

    • -0
    • +7
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 1 more file in changeset.
Changed DeamonParameters to use `JavaInfo` instances instead of File java home to represent the target JVM for build execution.

    • -1
    • +1
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 10 more files in changeset.
Cleanup of NativeServices testing changes - Changed use of NativeServicesTestFixture to annotation in many cases - Centralized temp dir creation logic - Enhanced uninitialized NativeServices error message

+review REVIEW-5378

    • -5
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 41 more files in changeset.
Initializing native services for more broken tests

+review REVIEW-5378

    • -0
    • +4
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 11 more files in changeset.
Promote DaemonUsage to top level and use it instead of multiple boolean flags.

+review REVIEW-5426

    • -6
    • +7
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 12 more files in changeset.
Print a message suggesting using the daemon when it's not used and has not been explicitly disabled.

+review REVIEW-5426

    • -8
    • +32
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 18 more files in changeset.
Cleared up an old TODO

    • -1
    • +1
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 3 more files in changeset.
Remove @author tags and names from source code.

- Added checkstyle check for @author

- Added not to CONTRIBUTING.md saying that we don't use names in the codebase

    • -3
    • +0
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 1213 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

    • -2
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 13 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

(cherry picked from commit d21b4bc)

    • -2
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 13 more files in changeset.
Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties).

1. The use case is that organisations may roll out incubating mode to all projects and don't want to confuse the end users (e.g. fear about the features that may be perceived incomplete, confusing request for feedback in the incubating message). So, if the incubating mode is explicitly configured in the gradle properties, we assume that the user knows what he is doing and need not be reminded about the incubating nature of the feature. (while writing this commit message it just occurred to me that this should be in the spec)

2. The implementation is not quite pretty, looking for suggestions on how to improve it.

    • -2
    • +2
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 13 more files in changeset.
REVIEW-1198 Refactored the commandline / properties conversion in order to tidy up the internals.

    • -0
    • +109
    ./PropertiesToDaemonParametersConverterTest.groovy
  1. … 27 more files in changeset.