configuration

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
handle java.io.tmpdir as immutable systemproperty

  1. … 4 more files in changeset.
Include the correct Jvm args in BuildEnvironment model

Moved `CurrentProcess` utility into 'core', while keeping the daemon

process configuration stuff in 'launcher'.

  1. … 6 more files in changeset.
Removing uid from DaemonParameters and moving it to startup.

+review REVIEW-5825

  1. … 3 more files in changeset.
Trim whitespace when matching on boolean properties

  1. … 1 more file in changeset.
Use a new UID any time a daemon is started.

+review REVIEW-5825

  1. … 2 more files in changeset.
Fixing regression where "-Dorg.gradle.debug=true" does not have an effect

+review REVIEW-5668

  1. … 1 more file in changeset.
Don't include `-XX:MaxPermSize` in the default JVM args for the daemon when the target is >= Java 9.

This means that the daemon and tooling API now work with Java 9, when no JVM args specified.

  1. … 5 more files in changeset.
Changed DeamonParameters to use `JavaInfo` instances instead of File java home to represent the target JVM for build execution.

  1. … 9 more files in changeset.
Revert "Provide more information about Java environment in the Tooling API"

This reverts commit 4116f02938163f36c8561c13d1f36739a4d89657.

Conflicts:

subprojects/launcher/src/main/java/org/gradle/tooling/internal/provider/ProviderConnection.java

subprojects/tooling-api/src/main/java/org/gradle/tooling/model/build/JavaEnvironment.java

  1. … 4 more files in changeset.
Detect whether the build client is interactive or not.

Currently, this is only used for dealing with continuous build cancellation. The current strategy is to use `System.console()` in the build client for detecting whether or not the client is interactive.

  1. … 8 more files in changeset.
Serialize daemon startup configuration across to daemon process via its stdin rather than on the command-line, to keep command-line length down. Same approach is used to send configuration to worker process.

  1. … 10 more files in changeset.
Provide more information about Java environment in the Tooling API

+review: REVIEW-5473

  1. … 4 more files in changeset.
Wire "watch mode" command line options into build executer

- Rename watch mode to continuous mode

- Still using --watch for command line right now

- Build executer for continuous mode just keeps building without any

external triggers right now (5 seconds after last build)

- Extract command line parsing into separate converter (so integ tests can

use it) - TBD

- Put all of the "Parameter" objects into a Parameters holder

- No integ tests yet

  1. … 23 more files in changeset.
Don't use a discrete copy of the native services libs per daemon.

+review REVIEW-5378

  1. … 3 more files in changeset.
Promote DaemonUsage to top level and use it instead of multiple boolean flags.

+review REVIEW-5426

  1. … 11 more files in changeset.
Separate native parallel compilation from parallel-threads

* Deprecate --parallel-threads, suggest using --parallel

* Deprecate get/setParallelThreadCount in StartParameter

* Introduce org.gradle.workers.max system property

* Introduce --workers command line option (incubating)

* Introduce get/setMaxWorkerCount in StartParameter (incubating)

* Introduce is/setParallelProjectExecutionEnabled in StartParameter (incubating)

* Have BuildOperationProcessor use max worker count

+review REVIEW-5434

  1. … 11 more files in changeset.
Print a message suggesting using the daemon when it's not used and has not been explicitly disabled.

+review REVIEW-5426

  1. … 18 more files in changeset.
GRADLE-3145 - Respect command line system properties that represent immutable JVM runtime options (e.g. file.encoding).

There should now be no difference between such a property being set on the command line, environment vars, or gradle.properties.

+review REVIEW-5061

  1. … 5 more files in changeset.
Removed cycle between BuildLayoutParameters and StartParameter. Also changed StartParameter.DEFAULT_GRADLE_USER_HOME so that it considers the system and environment variables that affect user home (via BuildLayoutParameters).

  1. … 8 more files in changeset.
Cleared up an old TODO

  1. … 3 more files in changeset.
Remove @author tags and names from source code.

- Added checkstyle check for @author

- Added not to CONTRIBUTING.md saying that we don't use names in the codebase

    • -3
    • +0
    ./DefaultDaemonServerConfiguration.java
  1. … 1210 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

  1. … 13 more files in changeset.
Revert "Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties)."

This reverts commit 7fa641429cdd04a00f8bdf3f6364909fbd32a5ae.

It didn't work for the daemon execution and I wasn't happy with the implementation, too.

(cherry picked from commit d21b4bc)

  1. … 13 more files in changeset.
Message for incubating execution mode is not shown if the mode is explicitly configured (e.g. gradle.properties).

1. The use case is that organisations may roll out incubating mode to all projects and don't want to confuse the end users (e.g. fear about the features that may be perceived incomplete, confusing request for feedback in the incubating message). So, if the incubating mode is explicitly configured in the gradle properties, we assume that the user knows what he is doing and need not be reminded about the incubating nature of the feature. (while writing this commit message it just occurred to me that this should be in the spec)

2. The implementation is not quite pretty, looking for suggestions on how to improve it.

  1. … 13 more files in changeset.
REVIEW-1198 Refactored the commandline / properties conversion in order to tidy up the internals.

  1. … 25 more files in changeset.
Added gradle property 'org.gradle.parallel' for parallel execution.

1. I decided to only add org.gradle.parallel for now (avoid parallel.threads). It's because it feels awkward to configure exact number of threads in the gradle.properties - Gradle should figure out the optimal number for the user. Supporting both 'org.gradle.parallel' and 'org.gradle.parallel.threads' also means that we need to code some rules for the scenario when the user specifies both options (e.g. some combinations are mutually exclusive).

2. Added startParameter.isParallelThreadCountConfigured() method. This is a bit awkward but that was the simplest reasonable solution I came up with. (btw. We need to make StartParameter an interface). There's some complexity around the start parameter & gradle properties processing:

a. First we need to parse / convert the command line arguments because they contain information needed for gradle properties parsing (e.g. search upwards, directory, user home, etc.)

b. then we need to pull data from gradle properties and update the start parameter accordingly. However, the command line arguments should generally win over the gradle properties. So gradle properties can only update the start parameter *if* start parameter was not explicitly configured with given property.

3. The StartParameter.newInstance() method seems to be incorrect (the source and target instances share some collections). Should I fix it?

I'm open to discussion how to solve above better.

  1. … 5 more files in changeset.
Configure on demand. Some refactorings & reworking of the coverage.

Now the BuildActionsFactoryTest is not influenced by gradle.properties file present in local dev environment. Moved some coverage to more relevant spot (e.g. the properties precedence order moved to GradlePropertiesConfigurerTest).

  1. … 4 more files in changeset.
--configure-on-demand. Fixed problems with the tooling api. Now the new command line option is correctly handled.

  1. … 4 more files in changeset.
Configuration on demand now available at the command line.

1. Introduced --configure-on-demand command line option.

2. Reworked the DaemonParameters. New class GradleProperties deals with configuring various gradle properties from sources like gradle.properties and system properties.

    • -0
    • +182
    ./GradleProperties.java
    • -0
    • +41
    ./GradlePropertiesConfigurer.java
  1. … 12 more files in changeset.
added org.gradle.debug system property to facilitate debugging of (daemon) JVM (similar to test.debug)

  1. … 1 more file in changeset.