Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Moar whitespace ...

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 25 more files in changeset.
Moar whitespace ...

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 25 more files in changeset.
Fix scripts in test reaching out to project in task actions

where the fix is trivial

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 19 more files in changeset.
Fix scripts in test reaching out to project in task actions

where the fix is trivial

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 19 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -2
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :launcher

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 14 more files in changeset.
Annotate integ tests failing with instant execution in :launcher

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 14 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 50 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 98 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 50 more files in changeset.
Changed a bunch of integration tests to use the various task assertion methods instead of directly querying the `executedTasks` and `skippedTasks` collections. These methods can give better diagnostics when the assertion fails, and can perform additional checks.

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 98 more files in changeset.
Make environment variable mutation work on Java9+

Mutating the environment requires reflection on the

java.util package, so we need to open that package

up to Gradle. Since Gradle is not modularized, this

means opening it up to the whole classpath. This is

less than desirable, but the only way to restore the

behavior we had on Java 8 and below.

We should start limiting access to environment variables

going forward so users don't depend on arbitrary values.

However, this change allows us to unblock users who are

currently either not using Java 9 or running Gradle in

no-daemon mode, both of which are terrible solutions.

    • -1
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 11 more files in changeset.
Set timeout for AbstractIntegrationSpec (#5806)

We have been bitten by CI build exection timeout for a long time.

This PR introduces timeout for AbstractIntegrationSpec in order to

monitor execution timeout. Upon timeout, a spock interceptor can

print all threads' stack traces in all JVMs so that we can diagnose

the potential issues in other JVMs (daemons, test workers, etc.).

    • -2
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 29 more files in changeset.
Fix misplaced @Requires

In previous commit an attempt was made to ignore a test, but it wasn't placed

on the correct test method. This commit fixes that mistake.

    • -2
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
Ignore --foreground tests on IBM JDK

The foreground daemon uses whatever environment

variables were set when it was started, as it has

no "client context". On IBM JDK there are a bunch

of extra environment variables by default, which

interfere with subsequent matching of this daemon.

The whole --foreground feature seems questionable,

but that's a decision for another day.

    • -0
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 2 more files in changeset.
Fix launcher usages of output test fixtures

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 5 more files in changeset.
Increase timeout for DaemonScanInfoIntegrationTest

    • -2
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
Increase timeout for `DaemonScanInfoIntegrationSpec`

    • -0
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
Apply timeout to whole test class

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
Add timeout to probably flaky test

    • -0
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
Address review feedback

- use DaemonServerConfiguration to pass information further down

- remove BuildAndStop command

- change naming to use singleUse

+review REVIEW-6567

    • -4
    • +4
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 14 more files in changeset.
Expose single run daemon usage in DaemonScanInfo

    • -3
    • +29
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 13 more files in changeset.
Be less strict when comparing System.currentTimeMillis()

System.currentTimeMillis() is not monotonic and clock adjustments

on the build agent, while the test is running, can cause this assertion

to fail.

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
Use a stricter file delete

    • -1
    • +2
    ./DaemonScanInfoIntegrationSpec.groovy
Change test to block until expiration to fix flakiness

    • -17
    • +28
    ./DaemonScanInfoIntegrationSpec.groovy
Attempted fix for flaky test

- Increased delay waiting for daemon expiration message

- Fixed test that had incorrect assumptions

Flaky test issue: gradle/gradle-private#580

    • -16
    • +18
    ./DaemonScanInfoIntegrationSpec.groovy
Satisfy contract for DaemonScanInfo.notifyOnUnhealthy()

- Only fire once

- Make implicitly build scoped

+review

    • -2
    • +27
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 1 more file in changeset.
Rename method

+review REVIEW-5988

    • -1
    • +1
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 2 more files in changeset.
Reduce what is exposed to allow listening for damon expiration

- Do not expose the classes of `org.gradle.launcher.daemon.server.expiry`

- Provide a single listen method on `DaemonScanInfo` to listen for expiration

- cConsolidate integration tests

+review REVIEW-6019

    • -4
    • +109
    ./DaemonScanInfoIntegrationSpec.groovy
  1. … 6 more files in changeset.