DaemonInitialCommunicationFailureIntegrationSpec.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Run perf with loopback

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 14 more files in changeset.
Revert "Merge pull request #7838 from gradle/eskatos/messaging/bind-loopback-if-available"

Listening to the loopback device seems to cause some connection issues

to the daemon from IDEA. Reverting the change for now.

This reverts commit 9a940b21ee06ed0b5c83b7d88f7d191a0d7a590e, reversing

changes made to 18b1f6e10f32f623986868bb39e083b49467b16e.

    • -2
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 6 more files in changeset.
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 6 more files in changeset.
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 6 more files in changeset.
Prefer loopback bind address if available for IPC

Keep file lock communicator bound to wildcard address

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 6 more files in changeset.
Refine memory sampling event publishing

Merge MemoryStatusBroadcaster into MemoryManager

Broadcast start/stop is now isolated in MemoryManager

DaemonHealthStats wait for one JVM memory event

Strengthen tests around health logging

Services depend on ExecutorFactory to use ScheduledExecutorServices

And stop them properly

    • -1
    • +5
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 14 more files in changeset.
Added some int test coverage to verify that the daemon rejects stop requests when the authentication token does not match the expected token, and to verify that the registry file has the correct permissions attached.

    • -2
    • +26
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Don't use Java 7 method in int tests.

    • -1
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Added some test coverage to verify something is written to the daemon log file when a badly formed client request is received.

    • -1
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 3 more files in changeset.
Changed the daemon so that it does not disclose its existence to the client when a badly formed request is received. Instead, the daemon silently drops the connection.

This is an initial step to close a security vulnerability which allows different OS level users on the same machine as the daemon to run arbitrary commands or copy arbitrary files.

Note that this change does not actually fix the issue, later commits will do this.

    • -1
    • +32
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
move daemon integ test fixtures to internalIntegTesting

+review REVIEW-5483

    • -0
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 40 more files in changeset.
Tweak test coverage to assert that daemon is idle once the build client has finished, rather than becomes at some point later.

    • -4
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Extracted some interfaces out of TestableDaemon and DaemonLogsAnalyzer, and some renames.

    • -4
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 9 more files in changeset.
Added some test coverage to verify that the daemon is not killed when a build can be cancelled gracefully.

    • -9
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 19 more files in changeset.
Changed test server to attempt to receive something before dropping the connection.

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Don't use Java 7 API.

    • -1
    • +2
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Attempt to make this int test more robust on windows.

    • -4
    • +42
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Remove @author tags and names from source code.

- Added checkstyle check for @author

- Added not to CONTRIBUTING.md saying that we don't use names in the codebase

    • -3
    • +0
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1213 more files in changeset.
Introduce IntegrationTestBuildContext, that provides values for certain configuration required for test execution (e.g. gradle user home dir).

This used to be done by GradleDistribution.

    • -4
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 43 more files in changeset.
Rename org.gradle.tests package to org.gradle.test

    • -1
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 12 more files in changeset.
Broke the different kinds of test fixture servers out into their own packages and inner'd some sftp server classes.

    • -1
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 37 more files in changeset.
Move (some) Ivy specific test fixtures into a dedicated package, instead of growing the 'org.gradle.integtests' ball of mud.

Had to move some other stuff that hangs off this as well to avoid package cycles.

    • -1
    • +1
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 50 more files in changeset.
Don't kill the daemon until after it has updated the registry. Killing it part way through the update will leave a corrupted registry behind, which the client will just discard.

    • -3
    • +5
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 2 more files in changeset.
Attempted to stablize a test that fails sometimes on the ibm jvm. If this stabilizes the test, the other tests in this test case should be updated also.

    • -1
    • +3
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Made it possible to kill the daemon process forcefully from our fixture code on windows. Some windowses do not support it but the implementation is protected. To avoid hung builds on windows I need to use our ProcessBuilder machinery.

    • -3
    • +3
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Made the test run on linux only until windows CI issue fixed.

    • -3
    • +3
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Made it possible to kill the daemon process forcefully from our fixture code on windows. Some windowses do not support it but the implementation is protected from them.

    • -3
    • +3
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Improved one of the daemon tests and started using HttpServer as a @Rule. This way it will be cleaned after the test execution. Fixed a problem with the server cleanup and made sure it is possible to retry starting the server.

    • -4
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
  1. … 1 more file in changeset.
Reverted the change to the test until CI failure is fixed.

    • -4
    • +4
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy
Improved the test so that the HttpServer resource is cleaned correctly.

    • -2
    • +5
    ./DaemonInitialCommunicationFailureIntegrationSpec.groovy