language

Re-enable Play/Scala tests on Java 9+ (#5593)

Almost all Play/Scala tests were ignored on Java 9/10, which makes it lack coverage. This PR does:

- Update Scala version to Java9-compatible version according to [JDK compatibility](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html).

- Update default Play version to latest 2.6.15, which supports Java 9/10

- Adjust corresponding samples. Previous default Play version 2.3.10 was too old (release at 2014).

- Ignored the tests which can't work on Java 9+.

- Separate Play test resources with different versions. For example, Play 2.6 uses `build.gradle` and `Play 2.4/2.5` uses `build.gradle.old`.

- Previously `AbstractMultiVersionPlayContinuousBuildIntegrationTest` didn't have `targetPlatform` configuration, which made multi-version tests meaningless

- Fix `play-logback` configuration for `2.5.18`.

Apply repository mirroring to more sample tests

Also introduces a mirror for JBoss repository

Change int tests to use relevant fixture methods to express their expectations about the build log output.

Remove default parameter from abstract method

+review REVIEW-6575

Test against `scala-lang` instead of `play`

+review REVIEW-6575

Added Test to verify Java version updates with Cache & update language-scala.gradle

Signed-off-by: Devi Sridharan <devishree_90@yahoo.co.in>

Adding tests for PlatformScalaCompile Issue:#3648

Signed-off-by: Devi Sridharan <devishree_90@yahoo.co.in>

Use mavenCentral() and jcenter() mirrors in tests where possible

Move some of persistent-cache out of core

+review REVIEW-6562

On CI redirect maven central queries to local repo for integration tests

Fix issue with duplicate compiler daemons and add reuse tests

Configure -Xmx for daemons and workers in various tests

Tweaked the API of `BlockingHttpServer` to make it somewhat more convenient to use in tests.

Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

Reworked `BlockingHttpServer`. Converted to Java and changed the implementation to use the JVM's HTTP server types instead of Jetty internals.

Relax test condition to avoid flakiness

We have a known issue that the order of output is wrong in very rare

cases. If that happens, the test does not pick up the error messages

from the compiler (although they are still printed later).

Until that is fixed, do not check for the message in the output.

gradle/gradle#1303

Use project locking to parallelize tasks with async work

- Allow tasks to start while running tasks are waiting on async work

- Lock on the entire build when --parallel is not used

- Discontinue handling of @ParallelizableTask

Remove our custom provided configuration in favor of compileOnly

- Remove FindBugsExecuterTest since it relies on a FindBugs type and doesn't add much value

- Move static constants from ZincScalaCompilerFactory into ZincScalaCompilerUtil so tests don't rely on Zinc/Scala internals

- Replace uses of 'provided' with 'compileOnly'

- Move FindBugs and Zinc dependencies into gradle/dependencies.gradle

Run even more tests with reproducible archives on

Fix path canonicalization in ScalaCompileParallelIntegrationTest

Fixes "Could not canonicalise" error when Project#file and

passing a new File object on Windows.

Issue: #734

Revert "Stabilize ZincScalaCompilerFactory and improve testing"

This reverts commit 92cd7a6f0ef94b74e96d587121baf48428457968.

Stabilize ZincScalaCompilerFactory and improve testing

- Moved ZincCompilerServices to be private inner class

- Fixed failures in ScalaCompileParallelIntegrationTest

- Fixed typo "coping" => "copying"

- Update Zinc compiler interface JAR name. File name started

with compiler-interface-compiler-interface-

- Avoid leaking files when generating Zinc interface JAR

- Acquire lock when trying to get pre-existing zinc interface JAR.

This prevents returning a partially-copied JAR.

- Create temp file under zinc cache dir so we can verify that no

files are left behind after creating compiler interface JAR.

- Wrap Zinc cache closure in try/finally to avoid leaving it open

if an exception is thrown in operations before it's closed.

- Print warning if compiler interface JAR takes over 30 seconds to

generate.

Issue: #707, #733, #734

Investigate flaky test: request jstack dump for process holding the lock

- when a LockTimeoutException occurs

Remove test flakiness by allowing initial scala compilation to take longer

The test waits 20s for any build activity, but initial scala compilation can

take up to 1 minute to complete. This makes this tests fail for reasons

completely unrelated to the feature being tested (scala continuous build).

Bumping the timeout should make this test non-flaky, but it will leave the

underlying problem that Scala compilation sometimes is exceedingly slow.