Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use external repository mirrors in build (#6094)

We've been bitten by external repository fluctuation for a long time.

This PR makes most of tests use repository mirrors set up by ourselves

via init script and system property.

There're still some tests not switching to mirrors, which would be fixed

in follow-up commits.

    • -2
    • +1
    ./scala/SampleScalaLanguageIntegrationTest.groovy
  1. … 99 more files in changeset.
Re-enable Play/Scala tests on Java 9+ (#5593)

Almost all Play/Scala tests were ignored on Java 9/10, which makes it lack coverage. This PR does:

- Update Scala version to Java9-compatible version according to [JDK compatibility](https://docs.scala-lang.org/overviews/jdk-compatibility/overview.html).

- Update default Play version to latest 2.6.15, which supports Java 9/10

- Adjust corresponding samples. Previous default Play version 2.3.10 was too old (release at 2014).

- Ignored the tests which can't work on Java 9+.

- Separate Play test resources with different versions. For example, Play 2.6 uses `build.gradle` and `Play 2.4/2.5` uses `build.gradle.old`.

- Previously `AbstractMultiVersionPlayContinuousBuildIntegrationTest` didn't have `targetPlatform` configuration, which made multi-version tests meaningless

- Fix `play-logback` configuration for `2.5.18`.

    • -1
    • +1
    ./scala/JointScalaLangIntegrationTest.groovy
    • -0
    • +3
    ./scala/ScalaLanguageIncrementalBuildIntegrationTest.groovy
    • -1
    • +3
    ./scala/ScalaToolProviderNotAvailableIntegrationTest.groovy
  1. … 168 more files in changeset.
Apply repository mirroring to more sample tests

Also introduces a mirror for JBoss repository

    • -1
    • +6
    ./scala/SampleScalaLanguageIntegrationTest.groovy
  1. … 32 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -4
    • +3
    ./scala/ScalaLanguageIntegrationTest.groovy
    • -2
    • +1
    ./scala/ScalaToolProviderNotAvailableIntegrationTest.groovy
  1. … 29 more files in changeset.
Remove default parameter from abstract method

+review REVIEW-6575

    • -1
    • +1
    ./scala/CachedPlatformScalaCompileIntegrationTest.groovy
  1. … 4 more files in changeset.
Test against `scala-lang` instead of `play`

+review REVIEW-6575

    • -67
    • +27
    ./scala/CachedPlatformScalaCompileIntegrationTest.groovy
    • -0
    • +122
    ./scala/LanuageScalaCompilationFixture.groovy
    • -138
    • +0
    ./scala/PlayCompilationFixture.groovy
    • -9
    • +9
    ./scala/UpToDatePlatformScalaCompileIntegrationTest.groovy
Polish PR

+review REVIEW-6575

    • -38
    • +11
    ./scala/CachedPlatformScalaCompileIntegrationTest.groovy
    • -12
    • +8
    ./scala/PlayCompilationFixture.groovy
    • -18
    • +3
    ./scala/UpToDatePlatformScalaCompileIntegrationTest.groovy
  1. … 1 more file in changeset.
Added Test to verify Java version updates with Cache & update language-scala.gradle

Signed-off-by: Devi Sridharan <devishree_90@yahoo.co.in>

    • -0
    • +76
    ./scala/UpToDatePlatformScalaCompileIntegrationTest.groovy
  1. … 1 more file in changeset.
updating Tests with review comments

Signed-off-by: Devi Sridharan <devishree_90@yahoo.co.in>

    • -11
    • +16
    ./scala/CachedPlatformScalaCompileIntegrationTest.groovy
    • -3
    • +20
    ./scala/PlayCompilationFixture.groovy
  1. … 2 more files in changeset.
Adding tests for PlatformScalaCompile Issue:#3648

Signed-off-by: Devi Sridharan <devishree_90@yahoo.co.in>

    • -0
    • +221
    ./scala/CachedPlatformScalaCompileIntegrationTest.groovy
    • -0
    • +125
    ./scala/PlayCompilationFixture.groovy
  1. … 1 more file in changeset.
Use mavenCentral() and jcenter() mirrors in tests where possible

    • -3
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
    • -3
    • +1
    ./scala/ScalaCompilerContinuousIntegrationTest.groovy
  1. … 50 more files in changeset.
Move some of persistent-cache out of core

+review REVIEW-6562

    • -1
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 127 more files in changeset.
On CI redirect maven central queries to local repo for integration tests

    • -3
    • +1
    ./scala/ScalaComponentCompilerDaemonReuseIntegrationTest.groovy
  1. … 108 more files in changeset.
Fix issue with duplicate compiler daemons and add reuse tests

    • -0
    • +52
    ./scala/ScalaComponentCompilerDaemonReuseIntegrationTest.groovy
  1. … 16 more files in changeset.
Configure -Xmx for daemons and workers in various tests

    • -0
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 44 more files in changeset.
Tweaked the API of `BlockingHttpServer` to make it somewhat more convenient to use in tests.

    • -1
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 15 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

    • -1
    • +0
    ./scala/ScalaCompilerContinuousIntegrationTest.groovy
  1. … 119 more files in changeset.
Reworked `BlockingHttpServer`. Converted to Java and changed the implementation to use the JVM's HTTP server types instead of Jetty internals.

    • -1
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 8 more files in changeset.
Relax test condition to avoid flakiness

We have a known issue that the order of output is wrong in very rare

cases. If that happens, the test does not pick up the error messages

from the compiler (although they are still printed later).

Until that is fixed, do not check for the message in the output.

gradle/gradle#1303

    • -1
    • +4
    ./scala/ScalaLanguageIntegrationTest.groovy
Use project locking to parallelize tasks with async work

- Allow tasks to start while running tasks are waiting on async work

- Lock on the entire build when --parallel is not used

- Discontinue handling of @ParallelizableTask

    • -21
    • +19
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 40 more files in changeset.
Use project locking to parallelize tasks with async work

- Allow tasks to start while running tasks are waiting on async work

- Lock on the entire build when --parallel is not used

- Discontinue handling of @ParallelizableTask

    • -21
    • +19
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 40 more files in changeset.
Remove our custom provided configuration in favor of compileOnly

- Remove FindBugsExecuterTest since it relies on a FindBugs type and doesn't add much value

- Move static constants from ZincScalaCompilerFactory into ZincScalaCompilerUtil so tests don't rely on Zinc/Scala internals

- Replace uses of 'provided' with 'compileOnly'

- Move FindBugs and Zinc dependencies into gradle/dependencies.gradle

    • -7
    • +7
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 9 more files in changeset.
Run even more tests with reproducible archives on

    • -2
    • +4
    ./scala/ScalaLanguageIncrementalBuildIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix path canonicalization in ScalaCompileParallelIntegrationTest

Fixes "Could not canonicalise" error when Project#file and

passing a new File object on Windows.

Issue: #734

    • -1
    • +1
    ./scala/ScalaCompileParallelIntegrationTest.groovy
Revert "Revert "Revert "Revert "Stabilize ZincScalaCompilerFactory and improve testing""""

This reverts commit 4c2360fc0db1ce39de01cb747e24725f8d92a0b4.

    • -9
    • +19
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 2 more files in changeset.
Revert "Revert "Revert "Stabilize ZincScalaCompilerFactory and improve testing"""

This reverts commit c854d5b2c48cc0cae743f0fa55f9f72a87ed1829.

    • -19
    • +9
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 2 more files in changeset.
Revert "Revert "Stabilize ZincScalaCompilerFactory and improve testing""

This reverts commit cb627f180505dd101ec1bd11d5a3e1ee60c1a245.

    • -9
    • +19
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 2 more files in changeset.
Revert "Stabilize ZincScalaCompilerFactory and improve testing"

This reverts commit 92cd7a6f0ef94b74e96d587121baf48428457968.

    • -19
    • +9
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 2 more files in changeset.
Stabilize ZincScalaCompilerFactory and improve testing

- Moved ZincCompilerServices to be private inner class

- Fixed failures in ScalaCompileParallelIntegrationTest

- Fixed typo "coping" => "copying"

- Update Zinc compiler interface JAR name. File name started

with compiler-interface-compiler-interface-

- Avoid leaking files when generating Zinc interface JAR

- Acquire lock when trying to get pre-existing zinc interface JAR.

This prevents returning a partially-copied JAR.

- Create temp file under zinc cache dir so we can verify that no

files are left behind after creating compiler interface JAR.

- Wrap Zinc cache closure in try/finally to avoid leaving it open

if an exception is thrown in operations before it's closed.

- Print warning if compiler interface JAR takes over 30 seconds to

generate.

Issue: #707, #733, #734

    • -9
    • +19
    ./scala/ScalaCompileParallelIntegrationTest.groovy
  1. … 2 more files in changeset.
Investigate flaky test: request jstack dump for process holding the lock

- when a LockTimeoutException occurs

    • -0
    • +47
    ./scala/ScalaCompileParallelIntegrationTest.groovy