Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
GRADLE-3152 Cannot use Javadoc task without JavaBasePlugin applied

Allow to use Javadoc and JavaCompile tasks without applying JavaBasePlugin

- Inject JavaToolChain directly into the tasks instead of via the plugin

- Move providing DefaultJavaToolChain to JvmPluginServiceRegistry in language-jvm as JavaCompileTest needs that dependency

- Move all javadoc related code from plugins to language-jvm because DefaultJavaToolChain depends on that code

+review REVIEW-5158

  1. … 121 more files in changeset.
Extract core JVM platform classes into new subproject ‘platform-jvm’

    • -39
    • +0
    ./jvm/internal/DefaultClasspath.java
    • -114
    • +0
    ./jvm/internal/DefaultJarBinarySpec.java
    • -49
    • +0
    ./jvm/internal/DefaultJvmBinaryTasks.java
    • -85
    • +0
    ./jvm/internal/DefaultJvmLibrarySpec.java
    • -23
    • +0
    ./jvm/internal/JarBinarySpecInternal.java
  1. … 75 more files in changeset.
Internalize the mainSources FunctionalSourceSet into ComponentSpec.getSources()

- All LanguageSourceSets added to a component’s main source set are automatically part of the components sources

- Don’t use a rule to accomplish this: it’s part of the core component behaviour

- Once SourceSets are managed by model rules, this mechanism should be simpler

+review REVIEW-5076

    • -0
    • +1
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 10 more files in changeset.
Remove illegal model path (that was not used)

- remove internal componentSpecInternal from DefaultLibrarySpec for now - rename LanguageOutputType to TransformationFileType.

+review REVIEW-5076

    • -3
    • +3
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 11 more files in changeset.
linking main functionalSourceSet of component to component#sources is business of ComponentModelBasePlugin

+review REVIEW-5076

    • -6
    • +0
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 9 more files in changeset.
rename/move LanguageOutputTypes

+review REVIEW-5076

    • -0
    • +27
    ./jvm/JvmByteCode.java
    • -0
    • +28
    ./jvm/JvmResources.java
    • -5
    • +5
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 14 more files in changeset.
Rename project#projectComponents to #componentSpecs; update release notes

+review REVIEW-5076

  1. … 8 more files in changeset.
only attach source sets of relevant languages to component

- introduce LanguageOutputType for modelling language output

- keep registering factories for all kinds of provided SourceSet types for _all_ functional sourcesets in project#sources

- just create default languageSourceSet where component inputs (partially) match language output

- update integtests

TODO: handle custom libraries (currently returning empty set of component inputs); handle 3party language output / language plugins / components

+review REVIEW-5076

    • -1
    • +13
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 42 more files in changeset.
Inject FunctionalSourceSet into ComponentSpec at creation time

- introduce ComponentSpecInternal to access "mainSourceSet"

+review REVIEW-5076

    • -5
    • +18
    ./jvm/internal/DefaultJvmLibrarySpec.java
  1. … 26 more files in changeset.
Javadocs.

  1. … 2 more files in changeset.
Introduced a few more types to the component models for consistency

- NativeLibraryBinarySpec for all library binaries built for native

- JvmBinarySpec for all binaries built for JVM

    • -0
    • +59
    ./jvm/JvmBinarySpec.java
  1. … 5 more files in changeset.
Introduced ApplicationSpec type as corollary to LibrarySpec

  1. … 3 more files in changeset.
more renamings

ProjectBinary -> BinarySpec

ProjectBinaryInternal -> BinarySpecInternal

ProjectJarBinary -> JarBinarySpec

ProjectJvmLibraryBinary -> JvmLibraryBinarySpec

ProjectNativeBinaryTest -> NativeBinarySpecTest

+ several default implementations according to their related interfaces

    • -0
    • +43
    ./jvm/JarBinarySpec.java
    • -0
    • +59
    ./jvm/JvmLibraryBinarySpec.java
    • -0
    • +114
    ./jvm/internal/DefaultJarBinarySpec.java
    • -3
    • +3
    ./jvm/internal/DefaultJvmBinaryTasks.java
    • -3
    • +3
    ./jvm/internal/DefaultJvmLibrarySpec.java
    • -0
    • +23
    ./jvm/internal/JarBinarySpecInternal.java
  1. … 49 more files in changeset.
add work-in-progress sample + integrationTest for custom libraries via plugin

- did some more renamings.

- for now DefaultLibrarySpec lives in org/gradle/runtime/base/internal/ to avoid classycle issues for now

- TODO JvmLibrarySpec should extend DefaultLibrarySpec

  1. … 18 more files in changeset.
rename more component related model classes

  1. … 66 more files in changeset.
introdcue LibrarySpec

  1. … 3 more files in changeset.
rename ProjectJvmLibrary to JvmLibrarySpec

    • -0
    • +32
    ./jvm/JvmLibrarySpec.java
    • -0
    • +65
    ./jvm/internal/DefaultJvmLibrarySpec.java
    • -11
    • +11
    ./jvm/plugins/JvmComponentPlugin.java
  1. … 3 more files in changeset.
Rename: NamedProjectComponentIdentifier -> ComponentSpecIdentifier

- No longer extends ProjectComponentIdentifier, which represents an instance/binary

- Plan is to rename ProjectComponent -> ComponentSpec

  1. … 21 more files in changeset.
Configure component source sets via model rule

- This is a breaking change for the native ‘sources’ DSL

  1. … 25 more files in changeset.
Added JavaToolChain.displayName.

  1. … 2 more files in changeset.
Replace a couple of uses of ProjectConfigurationActionContainer with model rules

  1. … 6 more files in changeset.
Tweak to DefaultProjectJvmLibrary.displayName.

Extracted creation of binary lifecycle task into model rule

- Split functionality with legacy ‘java’ plugins, which still creates tasks eagerly

  1. … 5 more files in changeset.
Remove use of strings to represent model paths.

    • -32
    • +7
    ./jvm/plugins/JvmComponentPlugin.java
  1. … 13 more files in changeset.
Remove some use of String as a model path.

  1. … 20 more files in changeset.
Replace uses of model rules with rule source classes.

The goal is to get rid of the model rules class to make evolving the model registry easier. Only benefit of this change at this point is the improved error reporting due to the strong rule identity provided by rule sources.

    • -14
    • +104
    ./jvm/plugins/JvmComponentPlugin.java
  1. … 32 more files in changeset.
Extracted plugin to assist with migration to model rules

- ComponentModelBasePlugin now has source set defaults which are incompatible with legacy java plugin

- Fixes building gradle with latest gradle with JDK 1.8

  1. … 11 more files in changeset.
Added JavaToolChain to ProjectJvmLibraryBinary

  1. … 6 more files in changeset.
Moved ProjectNativeComponent.getBinaries() up to ProjectComponent

- Tests for configuring binaries of ProjectJvmLibrary

- Also moved getDisplayName() up

  1. … 5 more files in changeset.