Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Use the old mapping strategy for CLI compiler

This commit reintroduces the "old" mapping strategy from class names

to source files (and vice-versa) in case we use the CLI compiler.

The CLI compiler will not be perfect wrt incremental compilation (at

least not worse than it has been so far).

    • -2
    • +10
    ./recomp/DefaultIncrementalCompileResult.java
    • -3
    • +4
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -0
    • +46
    ./recomp/FileNameDerivingClassNameConverter.java
    • -2
    • +2
    ./recomp/JavaRecompilationSpecProvider.java
    • -2
    • +1
    ./recomp/RecompilationSpecProvider.java
    • -0
    • +25
    ./recomp/SourceFileClassNameConverter.java
  1. … 4 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -156
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Reimplement source to class name mapping for Java

Previously, mapping from source files to class names was done by extracting

the class names from the class files names, which wasn't 100% accurate.

The Groovy incremental compiler, on the other hand, was implemented using

an AST transformation which could extract the class names from the compiler

itself, therefore giving an accurate mapping from class names to source files.

The same is now done for the Java compiler, using a Java compiler plugin.

This fixes several issues where we could not figure out properly what files

to recompile when the name of the class being used in a dependency wasn't

directly related to the source file name.

However, this introduces a problem when the compiler is not a proper JDK

compiler. In particular, if compiling using a "path to compiler", the

plugin cannot be loaded and incremental compilation will fail.

    • -102
    • +0
    ./recomp/CompilationSourceDirs.java
    • -0
    • +28
    ./recomp/DefaultIncrementalCompileResult.java
    • -0
    • +50
    ./recomp/DefaultSourceFileClassNameConverter.java
    • -28
    • +0
    ./recomp/GroovyIncrementalCompileResult.java
    • -154
    • +0
    ./recomp/GroovyRecompilationSpecProvider.java
    • -50
    • +0
    ./recomp/GroovySourceFileClassNameConverter.java
    • -18
    • +46
    ./recomp/JavaRecompilationSpecProvider.java
    • -1
    • +7
    ./recomp/RecompilationSpecProvider.java
  1. … 18 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 26 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 50 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 26 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 26 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 49 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 26 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 49 more files in changeset.
Remove `FileResolver.getPatternSetFactory()` as this was only used to carry around the factory service and never used by the resolvers themselves. Instead, pass the factory around as a service.

    • -4
    • +2
    ./recomp/GroovyRecompilationSpecProvider.java
    • -7
    • +5
    ./recomp/JavaRecompilationSpecProvider.java
  1. … 50 more files in changeset.
Expose the location that a file tree will generate its contents into to the structure visitor.

  1. … 13 more files in changeset.
Expose the location that a file tree will generate its contents into to the structure visitor.

  1. … 13 more files in changeset.
Expose the location that a file tree will generate its contents into to the structure visitor.

  1. … 13 more files in changeset.
Expose the location that a file tree will generate its contents into to the structure visitor.

  1. … 13 more files in changeset.