gradle

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove deprecated Jetty plugin

Issue: #735

    • -589
    • +0
    ./api/plugins/jetty/AbstractJettyRunTask.java
    • -171
    • +0
    ./api/plugins/jetty/JettyPlugin.java
    • -61
    • +0
    ./api/plugins/jetty/JettyPluginConvention.java
    • -479
    • +0
    ./api/plugins/jetty/JettyRun.java
    • -130
    • +0
    ./api/plugins/jetty/JettyRunWar.java
    • -105
    • +0
    ./api/plugins/jetty/JettyStop.java
    • -57
    • +0
    ./api/plugins/jetty/ScanTargetPattern.java
    • -99
    • +0
    ./api/plugins/jetty/internal/ConsoleScanner.java
    • -117
    • +0
    ./api/plugins/jetty/internal/Monitor.java
    • -27
    • +0
    ./api/plugins/jetty/internal/Proxy.java
    • -20
    • +0
    ./api/plugins/jetty/package-info.java
  1. … 24 more files in changeset.
Mark classpaths as `@Classpath`

Instead of annotating with `@InputFiles` and `@OrderSensitive`, we now have only `@Classpath`.

This also enables relative path normalization for every classpath property.

+review REVIEW-6241

    • -5
    • +8
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 31 more files in changeset.
Merge branch 'release'

    • -0
    • +3
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 2 more files in changeset.
Deprecate Jetty plugin API classes

+review REVIEW-6139

    • -0
    • +3
    ./api/plugins/jetty/AbstractJettyRunTask.java
    • -0
    • +3
    ./api/plugins/jetty/JettyPluginConvention.java
    • -0
    • +3
    ./api/plugins/jetty/ScanTargetPattern.java
  1. … 2 more files in changeset.
Hard code Gradle version in deprecation test

Also use softer language in warning people what they should be doing.

+review REVIEW-6139

  1. … 2 more files in changeset.
Deprecate Jetty plugin

+review REVIEW-6139

  1. … 2 more files in changeset.
Mark all classpath task properties order-sensitive

All classpaths should respect file order.

+review REVIEW-6114

    • -0
    • +2
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 25 more files in changeset.
Comment classloaders which are safe, close ones which leak.

  1. … 9 more files in changeset.
Comment classloaders which are safe, close ones which leak.

  1. … 9 more files in changeset.
Workaround for non-existing webXml file

+review REVIEW-5932

Fix annotations for `JettyRun.webXml`

+review REVIEW-5932

Some diagnostics to assist with flaky test analysis

Mark any un-annotated task properties with `@Internal`

+review REVIEW-5932

    • -0
    • +15
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 32 more files in changeset.
GRADLE-2263 allow daemon instances to be shutdown. (#643)

This is a proposed fix for the issue described in:

https://issues.gradle.org/browse/GRADLE-2263

In GRADLE-2263, a workaround is described that added to a projects build.gradle

script. This commit is a simple reordering of two statements that are described in that Jira. This

reordering of code effectively implements, for all users, the workaround described in

that Jira.

This commit simply reorders these two operations so that a monitor port is created prior to performing

the exit if daemon check.

    • -4
    • +4
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 1 more file in changeset.
Replace usage of `String#format` with good old string concatenation

The rationale behind this change is that while `String#format` is usually admitted as good for readability (this is arguable),

in practice it is very bad for performance. Since Java 6, the JVM (the JIT, to be correct) does a pretty good job at optimizing

string concatenation. However, it is only capable to do so if we're using "dirty" string concatenations (using `+`), or `StringBuilder`.

However, usage of `StringBuilder` is not recommended either for 2 reasons:

1. it significantly decreases code readability

2. in Java 9, String concatenation is even more optimized thanks to `invokedynamic`, and code using `StringBuilder` will *not* benefit

from this optimization.

There are sill leftover `String#format` calls in the code, in the following cases:

- the call is used to generate an exception message. That's 90% of the remaining calls.

- the call is obviously a debug message, often used in `toString` (because as we all know, `toString` should only be used for debugging)

- the format includes specific number formatting patterns

- I missed it

    • -2
    • +2
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 226 more files in changeset.
Fixed static fields that should be final.

This commit fixes a number of static fields that were not declared final, although never updated.

    • -10
    • +10
    ./api/plugins/jetty/AbstractJettyRunTask.java
    • -23
    • +23
    ./api/plugins/jetty/JettyRun.java
    • -8
    • +8
    ./api/plugins/jetty/internal/ConsoleScanner.java
  1. … 18 more files in changeset.
Moved progress logging and styled text logging interfaces to live in their own packages.

    • -2
    • +2
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 154 more files in changeset.
Moved internal logging classes from 'core' to 'logging' project.

    • -2
    • +2
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 417 more files in changeset.
`coll.toArray(new T[coll.size()])` => `coll.toArray(new T[0])`

> Bottom line: toArray(new T[0]) seems faster, safer, and contractually cleaner, and therefore should be the default choice now. Future VM optimizations may close this performance gap for toArray(new T[size]), rendering the current "believed to be optimal" usages on par with an actually optimal one. Further improvements in toArray APIs would follow the same logic as toArray(new T[0]) — the collection itself should create the appropriate storage.

http://shipilev.net/blog/2016/arrays-wisdom-ancients/

Let's see what our performance tests say, if this is noticeable at all.

Changes made by IDEA "Structural Replace":

$coll$.toArray(new $T$[$coll$.size()])

=>

$coll$.toArray(new $T$[0])

+review REVIEW

    • -1
    • +1
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 38 more files in changeset.
fix log statement formatting to use {} when applicable

+review REVIEW-5646

  1. … 16 more files in changeset.
Remove AppliedPlugins and make PluginManager the public replacement for PluginContainer.

+review REVIEW-5298

  1. … 97 more files in changeset.
Add apply(String) and apply(Class) to PluginAware.

+review REVIEW-5298

  1. … 69 more files in changeset.
Deprecate PluginContainer.apply(Class) and PluginContainer.apply(String)

+review REVIEW-5239

  1. … 101 more files in changeset.
Change: Correct some misspelling and duplicate words

  1. … 26 more files in changeset.
Started using the convenience method for progress logger.

    • -8
    • +5
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 3 more files in changeset.
Remove @author tags and names from source code.

- Added checkstyle check for @author

- Added not to CONTRIBUTING.md saying that we don't use names in the codebase

    • -2
    • +0
    ./api/plugins/jetty/JettyPluginConvention.java
  1. … 1211 more files in changeset.
improved javadoc for `reload` and `scanIntervalSeconds` properties, and made sure they appear in dsl reference

    • -7
    • +32
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 2 more files in changeset.
replace usages of TaskContainer.add with TaskContainer.create

  1. … 24 more files in changeset.
Fixed capitalisation of HTML, XML, and CSV in a bunch of places in the docs

    • -1
    • +1
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 36 more files in changeset.
Moved ClassPath and DefaultClassPath from core to baseServices.

    • -1
    • +1
    ./api/plugins/jetty/AbstractJettyRunTask.java
  1. … 39 more files in changeset.