Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

    • -1
    • +1
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoReportRelocationIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
  1. … 115 more files in changeset.
Renders a deprecation warning to the console for ConfigurableReport.setDestination(Object) (#1798)

Use the method ConfigurableReport.setDestination(File) in Gradle's tests to avoid rendering the deprecation message.

    • -2
    • +2
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
  1. … 10 more files in changeset.
Remove dependency between integTest and test sources

    • -0
    • +54
    ./plugins/JacocoReportFixture.groovy
  1. … 10 more files in changeset.
Revert disabling append for Jacoco up to date test

+review REVIEW-6420

    • -7
    • +0
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
Do not append to Jacoco output in tests

So that the task is cached/can be up-to-date

+review REVIEW-6420

    • -0
    • +2
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -0
    • +8
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
    • -0
    • +7
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
Test Jacoco class dump dir

+review REVIEW-6418

    • -1
    • +7
    ./plugins/JacocoCachingIntegrationTest.groovy
Rename Jacoco’s classDumpFile to classDumpDir

Deprecated the old property in favor of the new.

+review REVIEW-6418

    • -1
    • +1
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
  1. … 6 more files in changeset.
Fix inverse logic

    • -1
    • +1
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 3 more files in changeset.
Align type with the one used in Maven plugin

    • -7
    • +7
    ./plugins/rules/JacocoViolationRulesLimit.groovy
  1. … 2 more files in changeset.
Show that JaCoCo does not run validation for rule values minimum > maximum

    • -5
    • +6
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
    • -0
    • +1
    ./plugins/rules/JacocoViolationRulesLimit.groovy
Uses minimum/maximum rule values if values is out of bounds

    • -6
    • +7
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
    • -0
    • +1
    ./plugins/rules/JacocoViolationRulesLimit.groovy
Test behavior for defining the same rule multiple times

    • -2
    • +23
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
JaCoCo metrics verification doesn't work with JDK 8 in earlier versions

    • -1
    • +1
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
Introduce base class for multi-version tests

    • -0
    • +34
    ./plugins/JacocoMultiVersionIntegrationTest.groovy
    • -10
    • +2
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -0
    • +43
    ./plugins/JacocoVersionCompatibilityIntegrationTest.groovy
    • -52
    • +0
    ./plugins/JacocoVersionIntegTest.groovy
    • -9
    • +3
    ./plugins/rules/AbstractJacocoPluginCoverageVerificationVersionIntegrationTest.groovy
    • -10
    • +3
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
Put back restriction

    • -1
    • +1
    ./plugins/JacocoVersionIntegTest.groovy
Test plugin with multiple JaCoCo versions

    • -231
    • +0
    ./plugins/JacocoPluginIntegrationTest.groovy
    • -0
    • +277
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -1
    • +1
    ./plugins/JacocoVersionIntegTest.groovy
    • -0
    • +7
    ./plugins/fixtures/JacocoCoverage.groovy
Make multi-version test

    • -2
    • +10
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
Change coverage to avoid rounding issue jacoco/jacoco#452

    • -3
    • +7
    ./plugins/JacocoPluginIntegrationTest.groovy
Move assertion logic into fixture

    • -1
    • +1
    ./plugins/JacocoVersionIntegTest.groovy
  1. … 1 more file in changeset.
Use latest JaCoCo version for multi-version tests

    • -1
    • +1
    ./plugins/JacocoVersionIntegTest.groovy
    • -1
    • +3
    ./plugins/fixtures/JacocoCoverage.groovy
  1. … 3 more files in changeset.
Upgrade JaCoCo library to a Java 9-compatible version

    • -4
    • +0
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -15
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
    • -4
    • +0
    ./plugins/JacocoReportRelocationIntegrationTest.groovy
    • -3
    • +0
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
    • -3
    • +0
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 1 more file in changeset.
Tests do not work on Java 9

    • -0
    • +2
    ./plugins/JacocoPluginIntegrationTest.groovy
Use task name that better expresses intent

    • -49
    • +0
    ./plugins/rules/AbstractJacocoPluginCheckCoverageVersionIntegrationTest.groovy
    • -0
    • +49
    ./plugins/rules/AbstractJacocoPluginCoverageVerificationVersionIntegrationTest.groovy
    • -32
    • +0
    ./plugins/rules/JacocoPluginCheckCoverageCompatibleVersionIntegrationTest.groovy
    • -33
    • +0
    ./plugins/rules/JacocoPluginCheckCoverageIncompatibleVersionIntegrationTest.groovy
    • -352
    • +0
    ./plugins/rules/JacocoPluginCheckCoverageIntegrationTest.groovy
    • -0
    • +32
    ./plugins/rules/JacocoPluginCoverageVerificationCompatibleVersionIntegrationTest.groovy
    • -0
    • +33
    ./plugins/rules/JacocoPluginCoverageVerificationIncompatibleVersionIntegrationTest.groovy
    • -0
    • +352
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 7 more files in changeset.
Report task should fail if any of the input file does not exist

    • -0
    • +34
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 1 more file in changeset.
Ignore running tests on Java 9

    • -0
    • +3
    ./plugins/rules/JacocoPluginCheckCoverageIntegrationTest.groovy
Extract dedicated task for verifying if coverage metrics are met

Results in better configurability for end user and decouples report generation from coverage verification.

    • -2
    • +2
    ./plugins/rules/AbstractJacocoPluginCheckCoverageVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/rules/JacocoPluginCheckCoverageCompatibleVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/rules/JacocoPluginCheckCoverageIncompatibleVersionIntegrationTest.groovy
    • -73
    • +48
    ./plugins/rules/JacocoPluginCheckCoverageIntegrationTest.groovy
  1. … 5 more files in changeset.
Use constant for task paths

    • -0
    • +1
    ./plugins/rules/AbstractJacocoPluginCheckCoverageVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/rules/JacocoPluginCheckCoverageCompatibleVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/rules/JacocoPluginCheckCoverageIncompatibleVersionIntegrationTest.groovy
Add missing word

    • -1
    • +1
    ./plugins/rules/JacocoPluginCheckCoverageIntegrationTest.groovy
Reuse version number across all multi-version tests

    • -2
    • +3
    ./plugins/JacocoVersionIntegTest.groovy
    • -0
    • +82
    ./plugins/fixtures/JacocoCoverage.groovy
    • -2
    • +3
    ./plugins/rules/JacocoPluginCheckCoverageCompatibleVersionIntegrationTest.groovy
    • -2
    • +3
    ./plugins/rules/JacocoPluginCheckCoverageIncompatibleVersionIntegrationTest.groovy
Add multi-version coverage for check support

    • -404
    • +0
    ./plugins/JacocoPluginCheckCoverageIntegrationTest.groovy
    • -0
    • +48
    ./plugins/rules/AbstractJacocoPluginCheckCoverageVersionIntegrationTest.groovy
    • -0
    • +31
    ./plugins/rules/JacocoPluginCheckCoverageCompatibleVersionIntegrationTest.groovy
    • -0
    • +32
    ./plugins/rules/JacocoPluginCheckCoverageIncompatibleVersionIntegrationTest.groovy
    • -0
    • +374
    ./plugins/rules/JacocoPluginCheckCoverageIntegrationTest.groovy
    • -0
    • +53
    ./plugins/rules/JacocoViolationRulesLimit.groovy