Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Deprecate jacoco.append

It makes no sense to set the property to `false`.

    • -0
    • +29
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Fix Jacoco to work with build cache

Jacoco code coverage should work well with the build cache out of the

box. Since appending to a coverage file works with parallel test

execution, see https://github.com/jacoco/jacoco/pull/52, we set

`append=true` and delete the coverage data just before the test task

starts to execute.

Note that this is a breaking change: separate tasks now cannot use the

same coverage file, since each of the tasks will delete it.

Issue: #5269

    • -2
    • +0
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -3
    • +0
    ./plugins/JacocoPluginIntegrationTest.groovy
    • -4
    • +9
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -3
    • +13
    ./plugins/JacocoReportFixture.groovy
    • -8
    • +0
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
  1. … 2 more files in changeset.
Rework JacocoReportBase to avoid use of afterEvaluate

    • -1
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 2 more files in changeset.
Re-enable Jacoco test for Java9 (#5557)

    • -1
    • +1
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -10
    • +11
    ./plugins/fixtures/JacocoCoverage.groovy
    • -1
    • +1
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 1 more file in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

This reverts commit 13eaebc2b1244511dcbff4c59cd41253e3b69642.

    • -1
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 88 more files in changeset.
Revert "Dogfood ImmutableFileCollection on production code (#4988)"

This reverts commit 834632674ca29b6fd190857947338b2b54a9bb62.

The commit caused a bug in incremental compilation, causing changes

to go undetected.

    • -1
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 88 more files in changeset.
Dogfood ImmutableFileCollection on production code (#4988)

Use ImmutableFileCollection in production code

    • -1
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 88 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -1
    • +1
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -1
    • +1
    ./plugins/rules/JacocoPluginCoverageVerificationIncompatibleVersionIntegrationTest.groovy
    • -7
    • +7
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 28 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -1
    • +1
    ./plugins/rules/JacocoPluginCoverageVerificationIntegrationTest.groovy
  1. … 22 more files in changeset.
Allow ArgumentProviders be passed as Test/JavaExec Jvm arguments (#4300)

* Allow ArgumentProviders be passed to Test Jvm arguments

* Make it possible to pass argument providers to JavaExec

    • -1
    • +1
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 26 more files in changeset.
Allow enabling build cache in all integration tests

Signed-off-by: Lóránt Pintér <lorant@gradle.com>

    • -9
    • +9
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 27 more files in changeset.
Convert existing relocation tests to use new one (#3782)

    • -16
    • +8
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
  1. … 9 more files in changeset.
Use mavenCentral() and jcenter() mirrors in tests where possible

  1. … 51 more files in changeset.
Check that cached jacoco report is the same

    • -0
    • +2
    ./plugins/JacocoCachingIntegrationTest.groovy
Activate test which is now implemented

    • -4
    • +0
    ./plugins/JacocoCachingIntegrationTest.groovy
Do not restore file dates when unpacking task outputs (#2667)

    • -1
    • +1
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 5 more files in changeset.
Add coverage for Test tasks being cachable with Jacoco disabled

+review REVIEW-6522

    • -0
    • +25
    ./plugins/JacocoCachingIntegrationTest.groovy
Add @NotYetImplemented test for JaCoCo's effect on Test

+review REVIEW-6522

    • -0
    • +23
    ./plugins/JacocoCachingIntegrationTest.groovy
Revert "Remove check for jacoco.append=true to disable caching"

This reverts commit 0ad7be70ca4661b5fdc56722a9018097b6797389.

+review REVIEW-6522

    • -0
    • +2
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 3 more files in changeset.
Revert "Remove another reference of append=false for JaCoCo tests"

This reverts commit e2c02630ceba4c041d06ca77c640d39438a342ac.

+review REVIEW-6522

    • -0
    • +8
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
Keep a good test

+review REVIEW-6524

    • -1
    • +0
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -0
    • +16
    ./plugins/JacocoPluginIntegrationTest.groovy
Revert "Use a configure task to add jvmArgs to Test"

This reverts commit 8bb0429bc2140552c53dfbeb522c34a55caf63f0.

+review REVIEW-6524

    • -25
    • +0
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Remove another reference of append=false for JaCoCo tests

+review REVIEW-6522

    • -8
    • +0
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
Use a configure task to add jvmArgs to Test

+review REVIEW-6524

    • -0
    • +25
    ./plugins/JacocoPluginIntegrationTest.groovy
  1. … 3 more files in changeset.
Detect overlapping files for cacheable tasks

When two tasks overwrite one another, enforcing overlap detection doesn't

really make sense (because the outcome is the same).

But when two tasks append to a single output file, we should disable caching

because the order of the two tasks executing matters more.

+review REVIEW-6522

    • -3
    • +33
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 2 more files in changeset.
Remove check for jacoco.append=true to disable caching

If two Test tasks use the same JaCoCo execution data file, overlapping

output detection will disable build caching.

+review REVIEW-6522

    • -2
    • +0
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 3 more files in changeset.
Extract test fixture for HttpBuildCache

    • -2
    • +2
    ./plugins/JacocoCachingIntegrationTest.groovy
  1. … 21 more files in changeset.
Use separate output directories for all JVM languages

- Introduce an outputDir on SourceDirectorySet

- Default output directory is now `build/classes/<source directory set name>/<source set name>`

- Example: Java compilation goes to build/classes/java/main instead of build/classes/main

- Adapt JDepend, FindBugs, Test and ValidateTaskProperties tasks to handle multiple class directories

- Deprecate setClassesDir/getClassesDir on SourceSetOutput

- Calling setClassesDir restores old behavior (shared output directory)

- Introduce addClassesDir and getClassesDirs on SourceSetOutput

- OSGi plugin needs a single classes directory, so introduce 'osgiClasses' task that syncs all classes to a single directory

Most of the changes to integration tests are find classes in their new location. Helper methods in AbstractIntegrationSpec

can locate class files vs hardcoding a path.

Squashed commit of sg-split-jvm-classes branch for REVIEW-6502

    • -1
    • +1
    ./plugins/JacocoCachingIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoReportRelocationIntegrationTest.groovy
    • -2
    • +2
    ./plugins/JacocoTestRelocationIntegrationTest.groovy
  1. … 115 more files in changeset.
Renders a deprecation warning to the console for ConfigurableReport.setDestination(Object) (#1798)

Use the method ConfigurableReport.setDestination(File) in Gradle's tests to avoid rendering the deprecation message.

    • -2
    • +2
    ./plugins/JacocoPluginMultiVersionIntegrationTest.groovy
  1. … 10 more files in changeset.
Remove dependency between integTest and test sources

    • -0
    • +54
    ./plugins/JacocoReportFixture.groovy
  1. … 10 more files in changeset.