Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Always evaluate publishing block eagerly

This commit makes `enableFeaturePreview('STABLE_PUBLISHING')`

meaningless by always using the new behavior. The flag is kept for

backward compatibility.

    • -2
    • +0
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 55 more files in changeset.
Enable improved POM support by default

This commit makes the experimental flag `IMPROVED_POM_SUPPORT` the default.

The flag is still there for backwards compatibility but has effectively no

impact. As a consequence, the behavior of improved POM support is now the

default, which implies that:

- Maven dependencies packaged as `pom` or `jar` now have derived variants

(`compile` and `runtime`) and we properly choose between the variants based

on the consumer attributes

- platform dependencies using the `platform` and `enforcedPlatform` keywords

are enabled

Enabling improved POM support by default is a **breaking change**: there's

a risk that resolved dependencies is different, in particular because we

will now only include the `compile` dependencies of a POM file whenever the

consumer asks for the API variant. There are also some changes in the

dependency insight reports due to the use of attribute based matching instead

of configuration selection.

Last but not least, this commit is likely to introduce a small performance

regression due to attribute based selection.

    • -1
    • +0
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 50 more files in changeset.
Nag users only once about stable_publishing flag

This was an oversight, it should have used the deprecation

logger, not a normal logger to print the warning.

    • -1
    • +2
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 27 more files in changeset.
Nag users only once about stable_publishing flag

This was an oversight, it should have used the deprecation

logger, not a normal logger to print the warning.

    • -1
    • +2
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 28 more files in changeset.
Transform FeaturePreviewsFixture to use the new API

Replaces injecting a property in the gradle.properties with injecting

the gradle.enableFeaturePreview in settings.gradle

    • -2
    • +2
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 16 more files in changeset.
Turn experimental option into gradle metadata option

Signed-off-by: Jendrik Johannes <jendrik@gradle.com>

    • -1
    • +1
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 18 more files in changeset.
Rename 'experimental features' to 'feature previews'

The idea behind this is that we have a set of feature previews rather

than one cryptic experimental flag.

A feature preview collects a set of related functionality (e.g.

everything related to gradle metadata) that changes existing behavior

and thus could potentially break existing builds. The preview options

will be removed with the next major release (currently 5.0) and the new

behaviour will then become the default.

Signed-off-by: Jendrik Johannes <jendrik@gradle.com>

    • -3
    • +3
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 45 more files in changeset.
Adjust tests and test fixtures to opt-in options split

Signed-off-by: Jendrik Johannes <jendrik@gradle.com>

    • -1
    • +2
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 13 more files in changeset.
Adjust tests to use the new experimental feature option

Signed-off-by: Jendrik Johannes <jendrik@gradle.com>

    • -1
    • +1
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 23 more files in changeset.
Explicitly declare which tests require external dependencies

Ideally, those dependencies should be replaced with synthethic dependencies that mimic what they are doing.

In the meantime, the relatively low number of tests which do make use of external dependencies have been

marked as such. This should fix an error on CI, where the Artifactory mirror is not as quite tolerant as

what we allow in the component coordinates.

    • -1
    • +3
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 4 more files in changeset.
Introduce `noComponentPublished()` expectation

This expectation needs to be used whenever we expect resolution failure because no component was published.

This happens with Gradle metadata only, as the only way to publish a module file is `from components....`

    • -2
    • +16
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 14 more files in changeset.
Always resolve test publications with experimentFeatures enabled

Now that we can selectively choose which `metadataSource` to resolve

we can always verify the published metadata files with experimental

features enabled. This simplifies the tests.

One test needed to be changed because an optional dependency being

dragged in by spring-core was changing the resolution result when

experimental features were enabled.

    • -10
    • +1
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 3 more files in changeset.
Migrate the Maven publish integration tests to use the same test fixtures as Ivy

This makes things much easier to understand, and explicits some expectations.

    • -21
    • +9
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 12 more files in changeset.
Push common `sq` methods up to trait

    • -8
    • +0
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 2 more files in changeset.
Enfore looking only for `ivy` or `gradle` metadata when doing resolution

This commit uses the `metadataSources` to make sure that when we re-resolve, we only use the expected metadata source.

This prevents some tests from accidentally passing because we resolve to Ivy after failing with Gradle.

    • -2
    • +6
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 5 more files in changeset.
Resolve published Ivy files twice, with and without Gradle metadata

This commit changes the Ivy publication tests so that we resolve the published files twice:

- once with Gradle metadata

- once without Gradle metadata

Expectations are set on both, using a single entry point (`resolveArtifacts`). This removes the

explosion of `resolveArtifact` methods.

    • -26
    • +82
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 12 more files in changeset.
Fix legacy Ivy publishing for null Exclude artifacts

    • -5
    • +5
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 1 more file in changeset.
Make java libraries publishable on Ivy using Gradle metadata

This commit completes Gradle metadata publishing on Ivy repositories. It adds the necessary support, and

converts several tests to the wrapping `javaLibrary` test fixture.

    • -10
    • +76
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 28 more files in changeset.
Use mavenCentral() and jcenter() mirrors in tests where possible

    • -1
    • +3
    ./ivy/AbstractIvyPublishIntegTest.groovy
  1. … 51 more files in changeset.
Close sftp server session at end of broken upload test

    • -0
    • +6
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 1 more file in changeset.
Fixed test expectations for changes to the outgoing variants of a java project.

    • -1
    • +1
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
Revert "Revert "Merge branch 'cc-java-library-plugin'""

This reverts commit c6cd884e1a8889fb25d26dfcfdfa79d896835e11.

    • -1
    • +1
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 76 more files in changeset.
Revert "Merge branch 'cc-java-library-plugin'"

This reverts commit 0d442a55b445f537efbce65267ce9418fce2e7a8, reversing

changes made to 04647ab69fc8d19186cd2a78124ea74b8a89cc0f.

    • -1
    • +1
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 76 more files in changeset.
Fix Ivy integration tests

    • -1
    • +1
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
Upgrade Jetty to 6.1.26 to fix file handle leaks

Tests using both HttpServer and TestKeyStore fixtures to setup a TLS

enabled HTTP server leak file handles because Jetty is not releasing

the keystore files.

This minor Jetty version includes the proper fix:

- http://dev.jetty.codehaus.narkive.com/rDyeZ8st/jetty-dev-jira-created-jetty-1292-sslsocketconnector-createfactory-leaks-file-handles-when-reading

- http://jetty.4.x6.nabble.com/Jetty-release-6-1-26-td45150.html

    • -2
    • +0
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 8 more files in changeset.
Clean up Ivy test fixture

+review REVIEW-6123

    • -8
    • +9
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 3 more files in changeset.
Polishing

+review REVIEW-6123

    • -11
    • +12
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 7 more files in changeset.
Fix for GRADLE-3440 & some improved integTests

    • -5
    • +32
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 8 more files in changeset.
Upgrade Apache Commons Collections to v3.2.2

Version 3.2.1 has a CVSS 10.0 vulnerability. That's the worst kind of

vulnerability that exists. By merely existing on the classpath, this

library causes the Java serialization parser for the entire JVM process

to go from being a state machine to a turing machine. A turing machine

with an exec() function!

https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-8103

https://commons.apache.org/proper/commons-collections/security-reports.html

http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/

    • -2
    • +2
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 54 more files in changeset.
Forcefully clean up test temp directories and mark tests for which it fails on Windows with @LeaksFileHandles so that they still pass.

+review REVIEW-5504

    • -0
    • +2
    ./ivy/AbstractIvyRemoteLegacyPublishIntegrationTest.groovy
  1. … 97 more files in changeset.