Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Flag a bunch of tests that @LeaksFileHandlers

- Now that we're correctly registering the cleanup rules, these

leaks are causing build failures on windows.

  1. … 15 more files in changeset.
Fix broken unit tests

This commit also removes a weird behavior of `ModelPath` that supported dots in names. This is very confusing and caused the discovery

of the 2 other broken tests fixed in this commit.

+review REVIEW-5921

  1. … 2 more files in changeset.
Fixed the location reported when a pom or ivy.xml cannot be parsed so that it points to the origin of the resource, not the cached file.

Also changed the error message to use file path for an origin that is on the file system and a URI for a remote origin. Plus added some test coverage for this.

  1. … 4 more files in changeset.
Use a factory to create `FileCollection` instances in a few more places.

  1. … 19 more files in changeset.
Extracted a base specification which can be used for writing software model plugin unit tests, from various existing unit tests.

    • -12
    • +4
    ./publish/ivy/plugins/IvyPublishPluginTest.groovy
  1. … 4 more files in changeset.
Some post merge cleanup and additional test coverage for Ivy publication excludes

+review REVIEW-5755

  1. … 5 more files in changeset.
Move ModelRegistryHelper functionality to Groovy extension module

+review REVIEW-5715

  1. … 19 more files in changeset.
ivy: added support for publishing exclude in descriptors

  1. … 4 more files in changeset.
Cleanup of NativeServices testing changes - Changed use of NativeServicesTestFixture to annotation in many cases - Centralized temp dir creation logic - Enhanced uninitialized NativeServices error message

+review REVIEW-5378

  1. … 41 more files in changeset.
Some cleanup of native services initialization in unit tests

+review REVIEW-5378

  1. … 13 more files in changeset.
Initializing native services for more broken tests

+review REVIEW-5378

  1. … 11 more files in changeset.
Make DirectInstantiator a singleton.

  1. … 88 more files in changeset.
Don't graph-close task container model node when selecting tasks for execution

+review REVIEW-5370

  1. … 37 more files in changeset.
Push the class to rule extractor into the registry, to allow nodes etc. to accept RuleSource classes.

While it bothers me slightly that we are pushing knowledge of a particular type of rule representation into the registry, it saves having to cart some extra stuff around.

+review REVIEW-5353

  1. … 38 more files in changeset.
Collection mutation rule specifies input taking mutation rule for particular model element

+review REVIEW-5353

  1. … 68 more files in changeset.
Revert selective task closing work.

Too much breakage.

+review REVIEW-5350

  1. … 67 more files in changeset.
Wire the model registry into the “task selector”, effectively enabling configure-on-demand for rule based task declarations.

Rather than eagerly “realize” the whole task container and its contents, we now only realize the container itself.

This means that we know of all the tasks that will exist without actually creating them.

If a task (declared by rules) is not needed for a build (i.e. not selected, not depended on) it will not be created.

However, our rule based plugins at this time contain coarse rules that don't allow this feature to be leveraged.

Benefits will only be seen right now for contrived domains.

  1. … 63 more files in changeset.
Deprecate PluginContainer.apply(Class) and PluginContainer.apply(String)

+review REVIEW-5239

  1. … 101 more files in changeset.
Go back to adding model rules for tasks as soon as they are added to the task container

+review REVIEW-5176

  1. … 11 more files in changeset.
Moved a few classes to live in org.gradle.internal.xml and org.gradle.internal.html

  1. … 63 more files in changeset.
Extract ModelRegistryValidatingConfigurationAction from TaskModelRealizingConfigurationAction

+review REVIEW-5176

  1. … 4 more files in changeset.
Configuration performed to “bridged” model element made in afterEvaluate() is visible to creation rule

+review REVIEW-5176

  1. … 16 more files in changeset.
Renamed IvyExtraInfoSpec.put() -> add()

+review REVIEW-5059

  1. … 3 more files in changeset.
Review items for 'Make branch attribute available when publishing and resolving Ivy modules' story

- Changed groovy.xml.QName to javax.xml.namespace.QName

- Minor change to error message and construction of namespace list

- Minor change to dsl doc

- Changed IvyModuleDescriptorSpec to return mutable view of IvyExtraInfoSpec

- Minor change to sample build script

+review REVIEW-5059

  1. … 15 more files in changeset.
Review items for 'Make branch attribute available when publishing and resolving Ivy modules' story

- Changed extraInfo from a Map to an IvyExtraInfo with a map view

+review REVIEW-5059

  1. … 28 more files in changeset.
Review items for 'Make branch attribute available when publishing and resolving Ivy modules' story

- Moved NamespaceId and IvyModuleDescriptor to artifacts.ivy subpackage

- Added test for NamespaceId

- Updated javadoc comment for IvyModuleDescriptor.getIvyStatus to reflect that it is immutable

+review REVIEW-5059

  1. … 25 more files in changeset.
Addressing open issues for 'Make branch attribute available when publishing and resolving Ivy modules'

- Adding support for publishing extra info elements

- Change extra info map to use composite key for namespacing

+review REVIEW-5059

  1. … 22 more files in changeset.
Addressing open issues for 'Make branch attribute available when publishing and resolving Ivy modules'

- Adding ivyStatus to IvyModuleDescriptor

- Adding validation for status

+review REVIEW-5059

  1. … 9 more files in changeset.
Documentation and tweaks for 'Make branch attribute available when publishing and resolving Ivy modules' story +review REVIEW-5054

  1. … 8 more files in changeset.
First iteration of 'Make branch attribute available when publishing and resolving Ivy modules' story

  1. … 21 more files in changeset.