IvyArtifactNotationParserFactoryTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Do not publish stale signature files

This commit fixes the publication of stale signature files:

prior to this change it was possible that a signature generated

in a previous build for a different artifact was uploaded even

if no signature was generated during the build, which would

lead to inconsistent publications.

In addition, it makes it an error to publish something which

doesn't have the main artifact created (or, at least up-to-date)

in this build. In other words, if the task which generates the

main artifact is disabled, it's an error to publish.

Other stale artifacts are going to be ignored.

Fixes #5136

    • -2
    • +2
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 37 more files in changeset.
Do not publish stale signature files

This commit fixes the publication of stale signature files:

prior to this change it was possible that a signature generated

in a previous build for a different artifact was uploaded even

if no signature was generated during the build, which would

lead to inconsistent publications.

In addition, it makes it an error to publish something which

doesn't have the main artifact created (or, at least up-to-date)

in this build. In other words, if the task which generates the

main artifact is disabled, it's an error to publish.

Other stale artifacts are going to be ignored.

Fixes #5136

    • -2
    • +2
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 38 more files in changeset.
Do not publish stale signature files

This commit fixes the publication of stale signature files:

prior to this change it was possible that a signature generated

in a previous build for a different artifact was uploaded even

if no signature was generated during the build, which would

lead to inconsistent publications.

In addition, it makes it an error to publish something which

doesn't have the main artifact created (or, at least up-to-date)

in this build. In other words, if the task which generates the

main artifact is disabled, it's an error to publish.

Other stale artifacts are going to be ignored.

Fixes #5136

    • -2
    • +2
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 38 more files in changeset.
Allow the services required by a given class to be queried prior to creating any instances of that class. Use this to allow `ArtifactTransformDependencies` to be injected into artifact transforms using any of the service injection patterns (that is, via a constructor or a getter).

    • -1
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 127 more files in changeset.
Remove some direct usages of `AsmBackedClassGenerator` from tests, and instead use `TestUtil` fixture to take care of setting up a decorating `Instantiator`.

    • -4
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 17 more files in changeset.
Make AbstractArchiveTask.destinationDir mandatory

Prior to this commit the working directory was used when the

`destinationDir` was not set. Since this behavior does not play nice

with reproducible builds, it will now fail instead. However, it should

rarely happen because the `base` plugin provides a convention.

    • -0
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 26 more files in changeset.
Make AbstractArchiveTask.destinationDir mandatory

Prior to this commit the working directory was used when the

`destinationDir` was not set. Since this behavior does not play nice

with reproducible builds, it will now fail instead. However, it should

rarely happen because the `base` plugin provides a convention.

    • -0
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 26 more files in changeset.
Make IvyArtifact lazy

    • -18
    • +4
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 13 more files in changeset.
Remove deprecated methods on TestUtil (#672)

In order to use project builder correctly without having

leaking files on windows it is necessary to initialize

the test fixture for NativeServices and clean up

the test directory after building.

AbstractProjectBuilderSpec provides a nice base class

for Groovy tests.

I removed the deprecated methods since using them leads

to files lying around. Migrating all the usages to the "new"

way ensures it is used correctly.

    • -4
    • +5
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 97 more files in changeset.
Fix broken unit tests

This commit also removes a weird behavior of `ModelPath` that supported dots in names. This is very confusing and caused the discovery

of the 2 other broken tests fixed in this commit.

+review REVIEW-5921

    • -1
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 2 more files in changeset.
Make DirectInstantiator a singleton.

    • -1
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 89 more files in changeset.
Added type parameter to NotationParser to represent the source type.

    • -1
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 53 more files in changeset.
Moved NotationParser to a new package.

    • -1
    • +1
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 59 more files in changeset.
renamed HelperUtil to TestUtil (REVIEW-1626)

    • -2
    • +2
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 145 more files in changeset.
Can now explicitly set publication coordinates for a Maven or Ivy publication - Use a convention mapping to set default artifact name in ivy publication (temporary until we get lazy configuration sorted properly)

    • -2
    • +3
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 9 more files in changeset.
Reworked default values and validation for IvyPublication and MavenPublication - Default IvyArtifact.name to module name on construction, rather than at time of writing ivy.xml (REVIEW-1678) - Don't permit null values for IvyArtifact.[name|extension|type] or MavenArtifact.extension - Allow empty string for extention only - Updated javadocs for MavenArtifact and IvyArtifact, adding @Nullable where appropriate (REVIEW-1572, REVIEW-1575)

    • -7
    • +12
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 19 more files in changeset.
REVIEW-1218: Removed magic parsing of filename when constructing publication artifact from file - Only carry extension from file to published artifact: everything else will be configured explicitly.

    • -6
    • +7
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 6 more files in changeset.
REVIEW-1519: Don't use file-name, PublishArtifact.name or ArchiveTask.baseName as artifact name when publishing to ivy - Default IvyArtifact.name to null, allowing it to inherit the published module name - The plan is to decouple how things are generated in the build from how they are published - Allowed multiple artifacts with same name in IvyDescriptor test code

    • -14
    • +10
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 14 more files in changeset.
Added FileResolver.asNotationParser() - for cases where we need to convert notation first to a File before transforming to an end result - Single location to differentiate between file notation errors & file resolution errors

    • -5
    • +14
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 5 more files in changeset.
Remove the 'file:' map mechanism for creating publication artifacts (source:) supercedes it (REVIEW-1217)

    • -35
    • +18
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 10 more files in changeset.
Tidied up construction of NotationParsers (REVIEW-1214) - Replaced TopLevelNotationParser with Factory<NotationParser<T>> - Renamed *NotationParser to *NotationParserFactory where appropriate - Still need to look at ProjectDependencyNotationParser as it doesn't follow the pattern

    • -0
    • +182
    ./IvyArtifactNotationParserFactoryTest.groovy
  1. … 21 more files in changeset.