Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix snapshot handling with Gradle Module Metadata

This commit fixes a couple of bugs:

1. if Gradle Module Metadata was published and consumed, then

the `changing` flag for the resolved component metadata wouldn't

be set to `true`, which means that snapshot would effectively be

considered as persistent

2. the publish test fixtures were not using the right, timestamped,

version id for the metadata and artifacts in case of unique snapshots,

which caused the resolution to fallback to the POM file

In addition, this fixes the generated module metadata file which

was uploaded _without_ substution the the SNAPSHOT version with

the timestamped version when published on external repositories.

Finally, this highlighted a couple of issues with test fixtures

which were still using Gradle Module Metadata when they shouldn't.

Fixes #10916

    • -4
    • +4
    ./integtests/publish/ivy/IvyPublishResolvedVersionsJavaIntegTest.groovy
  1. … 9 more files in changeset.
Fix snapshot handling with Gradle Module Metadata

This commit fixes a couple of bugs:

1. if Gradle Module Metadata was published and consumed, then

the `changing` flag for the resolved component metadata wouldn't

be set to `true`, which means that snapshot would effectively be

considered as persistent

2. the publish test fixtures were not using the right, timestamped,

version id for the metadata and artifacts in case of unique snapshots,

which caused the resolution to fallback to the POM file

In addition, this fixes the generated module metadata file which

was uploaded _without_ substution the the SNAPSHOT version with

the timestamped version when published on external repositories.

Finally, this highlighted a couple of issues with test fixtures

which were still using Gradle Module Metadata when they shouldn't.

Fixes #10916

    • -4
    • +4
    ./integtests/publish/ivy/IvyPublishResolvedVersionsJavaIntegTest.groovy
  1. … 9 more files in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 41 more files in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 32 more files in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 32 more files in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 26 more files in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
  1. … 1 more file in changeset.
Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
  1. … 4 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 61 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 54 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 58 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 60 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 58 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 58 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 61 more files in changeset.
Remove use of deprecated API

Remove use of deprecated APIs in PluginBuilder

Replace use of archiveName with archiveFileName

Avoid more deprecated APIs

    • -1
    • +1
    ./api/publish/ivy/IvyPublishArtifactCustomizationIntegTest.groovy
    • -6
    • +6
    ./integtests/publish/ivy/IvySingleProjectPublishIntegrationTest.groovy
  1. … 61 more files in changeset.
Make Javadoc and sources primary variants without dependencies

  1. … 15 more files in changeset.
Make Javadoc and sources primary variants without dependencies

  1. … 15 more files in changeset.
Make Javadoc and sources primary variants without dependencies

  1. … 15 more files in changeset.
Make Javadoc and sources primary variants without dependencies

  1. … 15 more files in changeset.
Update 'complete example' section in ivy publishing chapter

  1. … 6 more files in changeset.
Update 'complete example' section in ivy publishing chapter

  1. … 6 more files in changeset.
Update 'complete example' section in ivy publishing chapter

  1. … 6 more files in changeset.
Warn on publication of non transitive variant

This is effectively not supported in any of the published format.

  1. … 2 more files in changeset.
Warn on publication of non transitive variant

This is effectively not supported in any of the published format.

  1. … 2 more files in changeset.
Warn on publication of non transitive variant

This is effectively not supported in any of the published format.

  1. … 2 more files in changeset.
Warn on publication of non transitive variant

This is effectively not supported in any of the published format.

  1. … 2 more files in changeset.
Add validation at publication time

This commit introduces validation when generating Gradle

Module Metadata:

- check that there's at least one variant published

- each variant must have at least one attribute

- there shouldn't be duplicate variant names

- each variant must have a different (attributes,capabilities)

combination

Closes #10736

    • -15
    • +217
    ./api/publish/ivy/IvyGradleModuleMetadataPublishIntegrationTest.groovy
  1. … 10 more files in changeset.
Add validation at publication time

This commit introduces validation when generating Gradle

Module Metadata:

- check that there's at least one variant published

- each variant must have at least one attribute

- there shouldn't be duplicate variant names

- each variant must have a different (attributes,capabilities)

combination

Closes #10736

    • -15
    • +217
    ./api/publish/ivy/IvyGradleModuleMetadataPublishIntegrationTest.groovy
  1. … 10 more files in changeset.
Add validation at publication time

This commit introduces validation when generating Gradle

Module Metadata:

- check that there's at least one variant published

- each variant must have at least one attribute

- there shouldn't be duplicate variant names

- each variant must have a different (attributes,capabilities)

combination

Closes #10736

    • -15
    • +217
    ./api/publish/ivy/IvyGradleModuleMetadataPublishIntegrationTest.groovy
  1. … 10 more files in changeset.