Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Modified JUnitTestClassExecutionResult to support the changes made in JUnitXmlResultWriter.

- Overloaded `assertTestCount` with a 4 integer function that asserts the skip count.

- Changed assert methods to filter on the existence(or not) of a `skipped` sub-element.

- Added an assert to the checking method to check that there is a skipped annotation and that is not empty.

- Removed findIgnoredTests as it is no longer required.

    • -8
    • +16
    ./fixtures/JUnitTestClassExecutionResult.groovy
Changed some int tests to use DefaultTestExecutionResult rather than JUnitTestExecutionResult, to use whatever the default mechanism for verifying test results happens to be.

    • -1
    • +1
    ./fixtures/DefaultTestExecutionResult.groovy
    • -8
    • +11
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 23 more files in changeset.
GRADLE-2730 Added an integ test.

    • -0
    • +5
    ./fixtures/JUnitTestClassExecutionResult.groovy
  1. … 1 more file in changeset.
Changed the HtmlTestExecutionResult assert methods so that they actually assert stuff, and some other minor fixes in the various TestExecutionResult implementations.

    • -2
    • +5
    ./fixtures/DefaultTestExecutionResult.groovy
    • -23
    • +25
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 2 more files in changeset.
Changed the profile and test reports to generate only the index page into the destination directory, and the other stuff ends up in sub-directories.

    • -2
    • +2
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 18 more files in changeset.
Moved some classes out of org.gradle.util.

    • -1
    • +1
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 63 more files in changeset.
REVIEW-3092: moved toSafeFileName method to baseServices - avoids duplicate code in test fixtures - REVIEW-3090 encode # as well - REVIEW-3092 add testcoverage for toSafeFileName

    • -25
    • +3
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 7 more files in changeset.
Add a bit more coverage to the cucumberjvm test and fix xml test result fixture.

    • -1
    • +1
    ./fixtures/HtmlTestExecutionResult.groovy
    • -2
    • +2
    ./fixtures/JUnitXmlTestExecutionResult.groovy
  1. … 1 more file in changeset.
fix html report generation for test class names that contains spaces, slashes and other non supported chars in filenames

    • -1
    • +24
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 5 more files in changeset.
Fix xml test result generation for cucumber tests. We now take care of generating correct filenames used in xml reports; TODO: Do the same for html

    • -2
    • +8
    ./fixtures/JUnitXmlTestExecutionResult.groovy
  1. … 3 more files in changeset.
Improve assertions on JUnit XML output to test that no system-out type elements are present when not using test case output association.

    • -4
    • +3
    ./fixtures/JUnitTestClassExecutionResult.groovy
Enabled generating the JUnit XML file with output per test case.

This is not complete. The actual generation of the XML based on the TestResultsProvider is unit tested and there is functional level coverage when running TestNG tests.

Coverage for JUnit is needed, as well as coverage at the intermediary parts of the results/report generation.

There are also some types to tidy up.

    • -0
    • +8
    ./fixtures/DefaultTestExecutionResult.groovy
    • -0
    • +9
    ./fixtures/HtmlTestExecutionResult.groovy
    • -0
    • +161
    ./fixtures/JUnitTestClassExecutionResult.groovy
    • -116
    • +7
    ./fixtures/JUnitXmlTestExecutionResult.groovy
    • -0
    • +4
    ./fixtures/TestClassExecutionResult.java
    • -0
    • +22
    ./fixtures/TestResultOutputAssociation.java
  1. … 12 more files in changeset.
REVIEW-1962: Use JUnit 4.5 in AssumptionIntegrationTest; fix HtmlTestExecutionResult

    • -0
    • +1
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 1 more file in changeset.
REVIEW-1874 some repackaging/reorganizing of the JUnit related integrationtests; add covererage for JUnit samples in docs.

    • -1
    • +1
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 83 more files in changeset.
Fix CI build - fix testclass lookup in HtmlTestExecutionResult - split test scoped ignored classes to extra package to support JUnit 4.0 in JUnitCrossVersionIntegTest

    • -2
    • +1
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 6 more files in changeset.
tweak HtmlTestExecutionResult to provide more readable assertion error.

    • -4
    • +4
    ./fixtures/HtmlTestExecutionResult.groovy
fix failing ci

    • -4
    • +4
    ./fixtures/HtmlTestExecutionResult.groovy
REVIEW-1310:

- wrap HtmlTestExecutionResult and JUnitXmlTestExecutionResult in DefaultTestExecutionResult

- fix HtmlTestExecutionResult

- always add testclass to report

    • -0
    • +98
    ./fixtures/DefaultTestExecutionResult.groovy
    • -4
    • +4
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 2 more files in changeset.
REVIEW-1292: replace JSoup.parse(File, "UTF-8") by JSoup.parse(File, null)

    • -2
    • +2
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 6 more files in changeset.
GRADLE-2649: fix our reporting of junit testsuites

    • -3
    • +3
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 8 more files in changeset.
REVIEW-1033: rename DefaultTestExecutionResult to JUnitXmlTestExecutionResult

    • -184
    • +0
    ./fixtures/DefaultTestExecutionResult.groovy
    • -0
    • +184
    ./fixtures/JUnitXmlTestExecutionResult.groovy
  1. … 28 more files in changeset.
GRADLE-1033: Use HtmlTestExecutionResult in TestReportIntegrationTest

    • -2
    • +2
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 1 more file in changeset.
Add more integration test coverage for Html reports for TestNG - cover forkEvery and maxParallelForks - introduce HtmlTestExecutionResult to verify test results against html report

    • -0
    • +146
    ./fixtures/HtmlTestExecutionResult.groovy
  1. … 5 more files in changeset.
Some renaming and cleanup around the test/temp directory used in tests.

    • -1
    • +1
    ./fixtures/DefaultTestExecutionResult.groovy
  1. … 308 more files in changeset.
REVIEW-867: Rename test fixture JUnitTestExecutionResult -> DefaultTestExecutionResult.

    • -0
    • +184
    ./fixtures/DefaultTestExecutionResult.groovy
    • -185
    • +0
    ./fixtures/JUnitTestExecutionResult.groovy
  1. … 26 more files in changeset.
Use new XML generation as a default in TestNG - always generate xml output (REVIEW-841) - move report handling from TestFramework to Test

    • -1
    • +0
    ./fixtures/JUnitTestExecutionResult.groovy
  1. … 15 more files in changeset.
TestNG creates xml results efficiently - an initial implementation.

1. The xml results are generated by the parent process and not by the test worker process. To avoid increased memory footprint, the test logging (std out/err, log4j, etc.) output is written to files (with buffering). To avoid speed regression, the test logging is copied to the resulting xml (e.g. no deserialization, just copying bytes from input stream to output stream). This way the new xml reports take less memory than previous Gradle versions without incurring build speed regression.

2. After many profiling sessions I've decided to not serialize the test results just yet (only the test logging is serialized). The test results (e.g. set of class names, test method names with results information) does not seem to consume too much memory at this stage. The full performance test run will soon validate this statement.

3. The TestNG exection generates 2 extra files per every test class. Those 2 files contain test output and test error. For JUnit I will be able to tweak the algorithm to generate less files and build some of the reports on the fly. It's because with JUnit we receive notifications on test class start / end. Hence, the JUnit xml results generation should be even more efficient, once all stories are completed.

4. The xml is written using the sax api to make sure it is efficient. The test outputs are also streamed.

5. Writing the test output to the files uses some simple caching of the open files + buffered writer.

6. Efficient generation of the html results may be nicely blended into above approach, possibly generating some data on the fly.

    • -0
    • +186
    ./fixtures/JUnitTestExecutionResult.groovy
    • -0
    • +62
    ./fixtures/TestClassExecutionResult.java
    • -0
    • +29
    ./fixtures/TestExecutionResult.java
  1. … 24 more files in changeset.
Split the integration testing harness out into internal-integ-testing from internal-testing, leaving internal-testing as general utilities used by testFixtures and integration tests.

    • -45
    • +0
    ./fixtures/AbstractExecutionResult.java
    • -262
    • +0
    ./fixtures/AbstractGradleExecuter.java
    • -56
    • +0
    ./fixtures/BasicGradleDistribution.java
    • -65
    • +0
    ./fixtures/DaemonGradleExecuter.java
    • -339
    • +0
    ./fixtures/ForkingGradleExecuter.java
    • -50
    • +0
    ./fixtures/GradleBackedArtifactBuilder.java
    • -196
    • +0
    ./fixtures/GradleDistribution.java
    • -219
    • +0
    ./fixtures/GradleDistributionExecuter.java
    • -386
    • +0
    ./fixtures/InProcessGradleExecuter.java
  1. … 51 more files in changeset.
GRADLE-1609 - When launching the daemon server process, only put the gradle-launcher jar on the system classpath (which is the behaviour for non daemon execution).

    • -5
    • +28
    ./fixtures/GradleDistributionExecuter.java
  1. … 6 more files in changeset.
Removed unused class.