Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Added simple validation for javaHome tooling api configurability

    • -3
    • +16
    ./m8/JavaConfigurabilityIntegrationTest.groovy
    • -2
    • +4
    ./m8/StrictLongRunningOperationIntegrationTest.groovy
  1. … 2 more files in changeset.
Enabled first integ test for invalid jvm args passed via the tooling api

    • -6
    • +14
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Daemon honors java home configuration (also for tooling api)...

On the server side I simply stop replacing the java.home property. It feels awkward anyway as we have daemon per java home. Now we can honor the java home configuration that gets applied when daemon starts (by looking for the correct java executable). This change needs a peer review. Added some fixes to the integration tests / unignored them.

    • -0
    • +2
    ./m8/BuildEnvironmentModelIntegrationTest.groovy
    • -2
    • +5
    ./m8/GradlePropertiesIntegrationTest.groovy
    • -21
    • +5
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 2 more files in changeset.
Final fix to the integ test

    • -1
    • +3
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Some tooling api fixes/investigation related to the java home configurability

    • -1
    • +1
    ./m8/GradlePropertiesIntegrationTest.groovy
    • -1
    • +17
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 1 more file in changeset.
Added support for java home supplied via gradle.properties...

Added relevant coverage using the AvailableJavaHomes. Moved/added related tooling api coverate to a separate test case.

    • -0
    • +64
    ./m8/GradlePropertiesIntegrationTest.groovy
    • -1
    • +19
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 3 more files in changeset.
Added proper tooling api coverage for custom java home using sweet AvailableJavaHomes

    • -0
    • +21
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Adding some examples/docs for the new tooling api configurability. I'll also reference them from the release notes.

    • -1
    • +8
    ./AutoTestedSamplesToolingApiTest.groovy
  1. … 2 more files in changeset.
Added more coverage to the tooling api related to jvm arguments. Tweaked the docs a bit.

    • -4
    • +5
    ./m8/BuildEnvironmentModelIntegrationTest.groovy
    • -0
    • +19
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 1 more file in changeset.
Minor refactoring before tackling GRADLE-1799 (no decent feedback when daemon fails to start)...

I'm not starting to work on it just now but I wanted to document some of the code investigation I did. Reworked the loop a little bit because it didn't make sense to ask for the connection immediately after starting the daemon (it surely hasn't started yet). Fixed the @Ignore import.

    • -4
    • +4
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 1 more file in changeset.
Fixed compilation issue related to misue of spock labels.

    • -4
    • +2
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Added yet ignored tests that need to be implemented soonish.

    • -0
    • +30
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Added explicit coverage for tooling api config taking precedence over gradle.properties

    • -0
    • +20
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Fixed a minor problem in the test.

    • -2
    • +2
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Improving the tooling api coverage for concurrency.

The test that was exercising the concurrent scenario with different target gradle versions now truly uses the 'previous' version, instead of hardcoded M7. Introduced ReleasedVersions type that holds that information (this can be improved further). Unignored the concurrent test because the reason for failure we a red herring (I think).

    • -7
    • +11
    ./m8/ConcurrentToolingApiIntegrationTest.groovy
  1. … 2 more files in changeset.
Enabled the smoke test of Tooling API samples from the javadoc...

It tries to compile the java snippets using the java 6 compiler api. I'm using this api reflectively to avoid compilation issues on java5. The test is configured to run only when the environment is compatible with java6. It's a first iteration, hopefully this test improves down the road.

    • -3
    • +40
    ./AutoTestedSamplesToolingApiTest.groovy
Ignored one test until we get a solution. It's a new concurrency issue exposed by running multiple different target versions of gradle concurrently with the tooling api. We couldn't run this test before releasing M7.

    • -0
    • +3
    ./m8/ConcurrentToolingApiIntegrationTest.groovy
Removed a TODO, there's little point in separating those tests.

    • -2
    • +0
    ./m8/ConcurrentToolingApiIntegrationTest.groovy
Made sure current consumer can read gradle version from M7. Tweaked the error messages a bit.

    • -1
    • +1
    ./m8/VersionOnlyBuildEnvironmentIntegrationTest.groovy
  1. … 2 more files in changeset.
Unignored a test that can now be ran after releasing M7

    • -3
    • +0
    ./m8/ConcurrentToolingApiIntegrationTest.groovy
Removed small thingy used for debugging

    • -2
    • +4
    ./m8/StrictLongRunningOperationIntegrationTest.groovy
Added strict validation for remaining LongRunningOperation configuration options.

    • -7
    • +28
    ./m8/StrictLongRunningOperationIntegrationTest.groovy
  1. … 3 more files in changeset.
Strict checking for new tooling api configurability...

First stab at the implementation. When the client uses long running operation configuration like javaHome but it is not supported than building the model or running the build will fail immediately. Basically, we're strict by default.

    • -0
    • +71
    ./m8/StrictLongRunningOperationIntegrationTest.groovy
  1. … 7 more files in changeset.
Moved tooling api java configurability from connector to the operation...

Moved the configurability from GradleConnector onto the LongRunningOperation. This makes the API nicer, because when we move to the strict model (next commits) the 'UnsupportedOperation' failure will happen earlier and recovery is slightly simpler. Also, this enables us to implement the 2-phase approach for LongRunning operations in the tooling api, e.g. make the GradleConnector download the distro on connect().

    • -26
    • +24
    ./m8/JavaConfigurabilityIntegrationTest.groovy
  1. … 10 more files in changeset.
Tooling api integ coverage improving/refactoring.

Separated out the coverage for build environment model and the java settings configurability. Useful before the next step, e.g. moving the configurability onto the LongRunningOperation instead of keeping it on the GradleConnector.

    • -55
    • +17
    ./m8/BuildEnvironmentModelIntegrationTest.groovy
    • -0
    • +79
    ./m8/JavaConfigurabilityIntegrationTest.groovy
Removed the java6 dependency for now to avoid compilation issues.

    • -33
    • +3
    ./AutoTestedSamplesToolingApiTest.groovy
Tooling api fixes after releasing M7...

-Some of the stuff was expected to fail because it wasn't really 'complete' at the time we cut the branch. I updated the suite so that it will be ran against M8. The new features were marked @Deprecated and experimental in the docs so that even if someone uses them with M7 consumer he has been warned. Those features do not work with M7 provider anyway.

-Unfortunately I needed to add back some methods to the protocol interfaces (VersionX types). They are internal so they are not affecting the clients. However it's breaking our internal contract on not changing those interfaces.

-Some of the tests (the concurrency fixes) can be a part of M7 suite and I will select them accordingly.

-This change should fix the build.

    • -114
    • +0
    ./m7/BuildEnvironmentModelIntegrationTest.groovy
    • -340
    • +0
    ./m7/ConcurrentToolingApiIntegrationTest.groovy
    • -104
    • +0
    ./m7/ConsumingStandardInputIntegrationTest.groovy
    • -43
    • +0
    ./m7/UnknownModelFeedbackIntegrationTest.groovy
    • -55
    • +0
    ./m7/VersionOnlyBuildEnvironmentIntegrationTest.groovy
    • -0
    • +114
    ./m8/BuildEnvironmentModelIntegrationTest.groovy
    • -0
    • +342
    ./m8/ConcurrentToolingApiIntegrationTest.groovy
    • -0
    • +104
    ./m8/ConsumingStandardInputIntegrationTest.groovy
    • -0
    • +43
    ./m8/UnknownModelFeedbackIntegrationTest.groovy
    • -0
    • +55
    ./m8/VersionOnlyBuildEnvironmentIntegrationTest.groovy
  1. … 2 more files in changeset.
Improved tooling api docs, added simple way to validate java code samples...

Added some examples to the DSL reference related to the tooling api. Added (so far quite crude) way of smoke testing the java samples contained in the javadocs. Basically, it uses java6 at hoc compiling facility to compile the sample and hence validate if the API is correctly used.

    • -0
    • +90
    ./AutoTestedSamplesToolingApiTest.groovy
  1. … 2 more files in changeset.
more s/buildBy/builtBy

    • -1
    • +1
    ./m4/ToolingApiEclipseMinimalModelFixesIntegrationTest.groovy
  1. … 1 more file in changeset.
Added more explicit coverage for jvm args passed via the tooling api.

    • -1
    • +23
    ./m7/BuildEnvironmentModelIntegrationTest.groovy