internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move Java sources from src/main/groovy to src/main/java

There are no Groovy sources left, so there's no need to keep these files in src/main/groovy. We can also save build time by only invoking a single compiler instead of two for these projects.

    • -242
    • +0
    ./configurer/HierarchicalElementDeduplicator.java
    • -41
    • +0
    ./configurer/NameDeduplicationAdapter.java
    • -82
    • +0
    ./generator/AbstractPersistableConfigurationObject.java
    • -55
    • +0
    ./generator/PropertiesPersistableConfigurationObject.java
    • -122
    • +0
    ./generator/XmlPersistableConfigurationObject.java
    • -32
    • +0
    ./generator/generator/Generator.java
    • -26
    • +0
    ./generator/generator/PersistableConfigurationObject.java
    • -47
    • +0
    ./generator/generator/PersistableConfigurationObjectGenerator.java
    • -41
    • +0
    ./tooling/BasicIdeaModelBuilder.java
    • -48
    • +0
    ./tooling/BuildEnvironmentBuilder.java
    • -130
    • +0
    ./tooling/BuildInvocationsBuilder.java
    • -291
    • +0
    ./tooling/EclipseModelBuilder.java
  1. … 364 more files in changeset.
Remove IdeaModuleDependency#getTarget()

Instead, provide the target module name. The getTarget() method was

introduced with the use case of a client-managed composite in mind.

This use case is no longer supported, composites are managed by the

coordinating build.

    • -7
    • +6
    ./tooling/idea/DefaultIdeaModuleDependency.java
  1. … 11 more files in changeset.
Remove GradleConnection API

The GradleConnection API was our first attempt at

implementing composite builds. We have improved on that

in Gradle 3.1, allowing the user to define composite builds

in settings.gradle and giving the user much more control

over how dependency substitution works.

A composite build is a normal Gradle build as far as the

Tooling API is concerned, so the separate concept of

the GradleConnection is no longer needed. We will add

methods for fetching all models from a composite build

to ProjectConnection in Gradle 3.2

    • -17
    • +2
    ./tooling/GradleProjectBuilder.java
  1. … 135 more files in changeset.
Removed `EclipseProjectIdentifier`

For the Eclipse model, we assume that the name of an EclipseProject is

sufficient for identification, and that the path of a ProjectDependency

is sufficient to locate the target project.

Based on that assumption, this commit removes the separate identifier

that was added to the eclipse model. It also simplifies the code for

wiring up dependencies in the Eclipse model, removing the need to track

the ProjectComponentIdentifier for each project dependency.

    • -22
    • +4
    ./tooling/eclipse/DefaultEclipseProjectDependency.java
  1. … 11 more files in changeset.
Stop tracking projectId for IDEA module dependency

For the IDEA model, we assume that the name of a IDEA module is

sufficient for identification. Based on that assumption, this commit

simplifies the code for wiring up dependencies in the IDEA model,

removing the need to track the ProjectComponentIdentifier and project

directory for each module dependency.

    • -1
    • +1
    ./tooling/eclipse/DefaultEclipseProjectDependency.java
    • -12
    • +9
    ./tooling/idea/DefaultIdeaModuleDependency.java
  1. … 3 more files in changeset.
Support GSTrings in build command arguments

GStrings in eclipse build command arguments lead to deserialization

errors on the Tooling API client, because the client does not have

the Groovy runtime. They GStrings need to be forcefully converted

to Strings on the provider side.

  1. … 1 more file in changeset.
Tidy up construction of tooling model dependencies

For a single build, the EclipseProject.path or IdeaModule.name is a

canonical identifier. Instead of using a separate `gradleProjectPath`

value, we rely on these properties to correlate tooling model dependencies

with their targets.

Removed all uses of `ProjectDependency.gradlePath`

    • -0
    • +6
    ./tooling/eclipse/DefaultEclipseProjectDependency.java
  1. … 2 more files in changeset.
Use project id instead of path in IDE plugins

  1. … 11 more files in changeset.
Add isExported() method to EclipseClasspathContainer

    • -1
    • +7
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
  1. … 2 more files in changeset.
Revert "Add isExported() method to EclipseClasspathContainer"

This reverts commit a91c278af1186158308416ac7ba8e613d7323abe.

    • -7
    • +1
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
  1. … 2 more files in changeset.
Add isExported() method to EclipseClasspathContainer

    • -1
    • +7
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
  1. … 2 more files in changeset.
Let Classpath class create FileReference instances

+review REVIEW-6109

  1. … 7 more files in changeset.
Remove remaining Closure instantiations from Java code

Ant builder calls remain - these should probably be converted back to Groovy

  1. … 7 more files in changeset.
Moved composite-specific DM types into a separate package

  1. … 25 more files in changeset.
Convert deduplication logic to Java

    • -29
    • +0
    ./configurer/DeduplicationTarget.groovy
    • -0
    • +242
    ./configurer/HierarchicalElementDeduplicator.java
    • -113
    • +0
    ./configurer/ModuleNameDeduper.groovy
    • -0
    • +41
    ./configurer/NameDeduplicationAdapter.java
  1. … 5 more files in changeset.
Tooling API exposes Eclipse project output folder

+review REVIEW-6048

    • -0
    • +32
    ./tooling/eclipse/DefaultEclipseOutputLocation.java
  1. … 3 more files in changeset.
Tooling API exposes access rules for Eclipse classpath entries

+review REVIEW-6047

    • -0
    • +38
    ./tooling/eclipse/DefaultAccessRule.java
    • -2
    • +2
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
    • -1
    • +8
    ./tooling/eclipse/DefaultEclipseClasspathEntry.java
    • -2
    • +2
    ./tooling/eclipse/DefaultEclipseExternalDependency.java
    • -4
    • +4
    ./tooling/eclipse/DefaultEclipseProjectDependency.java
    • -2
    • +2
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 5 more files in changeset.
Revert "Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release"

This reverts commit 506f8ce9d6dc1a81e8ff10575c512778ca2f382a.

    • -0
    • +36
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
    • -0
    • +32
    ./tooling/eclipse/DefaultEclipseClasspathEntry.java
    • -3
    • +22
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 194 more files in changeset.
Temporarily reverting everything since 810f052813ea0835dc7e9d3eb87bca005815db64 for 3.0-milestone-1 release

    • -36
    • +0
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
    • -32
    • +0
    ./tooling/eclipse/DefaultEclipseClasspathEntry.java
    • -22
    • +3
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 194 more files in changeset.
Fix build errors

+review REVIEW-6043

  1. … 2 more files in changeset.
Tooling API exposes Eclipse source folder output

+review REVIEW-6044

    • -1
    • +7
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 2 more files in changeset.
Tooling API exposes Eclipse classpath containers

+review REVIEW-6043

    • -0
    • +36
    ./tooling/eclipse/DefaultEclipseClasspathContainer.java
  1. … 4 more files in changeset.
Tooling API exposes Eclipse source folder classpath attributes

+review REVIEW-6042

    • -0
    • +32
    ./tooling/eclipse/DefaultEclipseClasspathEntry.java
    • -3
    • +3
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 2 more files in changeset.
Tooling API exposes Eclipse source folder exclude and include patterns

+review REVIEW-6040

    • -1
    • +14
    ./tooling/eclipse/DefaultEclipseSourceDirectory.java
  1. … 6 more files in changeset.
Ensure all post-evaluation actions are executed when build TAPI IDE models

  1. … 2 more files in changeset.
Fix de-duplication and dependencies for IDE plugins

When root project did not apply the IDE plugin, de-duplication and

IDE dependency customization were not correctly applied.

  1. … 5 more files in changeset.
Removed a couple of stale TODOs

  1. … 1 more file in changeset.
Remove two old TAPI models

    • -0
    • +2
    ./tooling/idea/DefaultIdeaModuleDependency.java
    • -0
    • +2
    ./tooling/idea/DefaultIdeaSingleEntryLibraryDependency.java
  1. … 4 more files in changeset.
Revert ""Remove two old TAPI models""

This reverts commit 54d284abd2f2c6f983390b06ea8fb60053f9491a.

    • -2
    • +0
    ./tooling/idea/DefaultIdeaModuleDependency.java
    • -2
    • +0
    ./tooling/idea/DefaultIdeaSingleEntryLibraryDependency.java
  1. … 4 more files in changeset.
"Remove two old TAPI models"

    • -0
    • +2
    ./tooling/idea/DefaultIdeaModuleDependency.java
    • -0
    • +2
    ./tooling/idea/DefaultIdeaSingleEntryLibraryDependency.java
  1. … 4 more files in changeset.