Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Move Java sources from src/main/groovy to src/main/java

There are no Groovy sources left, so there's no need to keep these files in src/main/groovy. We can also save build time by only invoking a single compiler instead of two for these projects.

    • -74
    • +0
    ./api/PropertiesFileContentMerger.java
    • -57
    • +0
    ./eclipse/GenerateEclipseClasspath.java
    • -59
    • +0
    ./eclipse/GenerateEclipseProject.java
    • -60
    • +0
    ./eclipse/GenerateEclipseWtpComponent.java
    • -61
    • +0
    ./eclipse/GenerateEclipseWtpFacet.java
  1. … 364 more files in changeset.
Add deprecation warning for deprecated methods

    • -2
    • +5
    ./eclipse/model/ProjectDependency.java
  1. … 2 more files in changeset.
Remove IdeaModuleDependency#getTarget()

Instead, provide the target module name. The getTarget() method was

introduced with the use case of a client-managed composite in mind.

This use case is no longer supported, composites are managed by the

coordinating build.

    • -5
    • +0
    ./internal/tooling/idea/DefaultIdeaModule.java
  1. … 11 more files in changeset.
Deprecated constructor with ignored parameter

    • -9
    • +19
    ./eclipse/model/ProjectDependency.java
Remove GradleConnection API

The GradleConnection API was our first attempt at

implementing composite builds. We have improved on that

in Gradle 3.1, allowing the user to define composite builds

in settings.gradle and giving the user much more control

over how dependency substitution works.

A composite build is a normal Gradle build as far as the

Tooling API is concerned, so the separate concept of

the GradleConnection is no longer needed. We will add

methods for fetching all models from a composite build

to ProjectConnection in Gradle 3.2

  1. … 135 more files in changeset.
Removed `EclipseProjectIdentifier`

For the Eclipse model, we assume that the name of an EclipseProject is

sufficient for identification, and that the path of a ProjectDependency

is sufficient to locate the target project.

Based on that assumption, this commit removes the separate identifier

that was added to the eclipse model. It also simplifies the code for

wiring up dependencies in the Eclipse model, removing the need to track

the ProjectComponentIdentifier for each project dependency.

    • -14
    • +0
    ./eclipse/model/ProjectDependency.java
  1. … 9 more files in changeset.
Stop tracking projectId for IDEA module dependency

For the IDEA model, we assume that the name of a IDEA module is

sufficient for identification. Based on that assumption, this commit

simplifies the code for wiring up dependencies in the IDEA model,

removing the need to track the ProjectComponentIdentifier and project

directory for each module dependency.

    • -14
    • +4
    ./internal/tooling/IdeaModelBuilder.java
    • -1
    • +1
    ./internal/tooling/idea/DefaultIdeaModule.java
  1. … 1 more file in changeset.
Support GSTrings in build command arguments

GStrings in eclipse build command arguments lead to deserialization

errors on the Tooling API client, because the client does not have

the Groovy runtime. They GStrings need to be forcefully converted

to Strings on the provider side.

  1. … 1 more file in changeset.
Tidy up construction of tooling model dependencies

For a single build, the EclipseProject.path or IdeaModule.name is a

canonical identifier. Instead of using a separate `gradleProjectPath`

value, we rely on these properties to correlate tooling model dependencies

with their targets.

Removed all uses of `ProjectDependency.gradlePath`

    • -11
    • +21
    ./internal/tooling/IdeaModelBuilder.java
  1. … 1 more file in changeset.
Use project id instead of path in IDE plugins

    • -4
    • +24
    ./eclipse/model/ProjectDependency.java
    • -4
    • +7
    ./internal/IdeDependenciesExtractor.java
    • -1
    • +1
    ./internal/tooling/IdeaModelBuilder.java
  1. … 7 more files in changeset.
Introduce a separate `BuildIdentifier` for composites

ProjectComponentIdentifier and ProjectComponentSelector now each have

a BuildIdentifier instance to identify the build that contains the

project. You can create a project identifier for the 'current' build

or from an included build.

At this stage, any ProjectComponentIdentifier for the 'current'

build has a 'current' BuildIdentifier, with name = `null`.

This will be improved to be a true build identifier.

  1. … 28 more files in changeset.
Add more convenience methods for transforming ids

Create ProjectComponentIdentifier for:

- build + ProjectComponentIdentifier

- ProjectComponentSelector

- Project

Create ProjectComponentSelector for:

- ProjectComponentIdentifier

- build + ProjectComponentSelector

  1. … 7 more files in changeset.
Add factory methods for build-specified project ids

  1. … 5 more files in changeset.
Always use factory method to create ProjectComponentId

  1. … 22 more files in changeset.
Make configure on demand work with idea/eclipse plugin

Calling `project.getTasks().getByPath(taskName)` forces

the project to evaluate. These calls have been added in

3.0 to add the IDE artifacts to the projects. This broke

configure on demand. Replacing `getByPath` with

`getByName` simplifies the code and fixes the problem,

since getByName does not force the project to be evaluated.

GRADLE-3534 #resolve

  1. … 1 more file in changeset.
Make configure on demand work with idea plugin

Calling `project.getTasks().getByPath(taskName)` forces

the project to evaluate. By putting the whole iml artifact

attach business into an afterEvaluate block this should

be fixed. The Eclipse plugin probably exposes the same problem.

  1. … 1 more file in changeset.
Remove @Deprecated from FileContentMerger#beforeMerged(Closure)

We do not have a strategy yet what to do with Closure taking methods.

Deprecating doesn't seem to be an option because then you see

deprecation warnings when writing `build.gradle` files.

For Gradle 3.0 we will not deprecate these methods and think

about a strategy for the future which we will implement later

in the 3.x release cycle

+review REVIEW-6142

Merge branch 'master' into composite-builds

  1. … 1 more file in changeset.
Remove a couple of TODOs

  1. … 1 more file in changeset.
Changed `LocalComponentArtifactIdentifier` -> `LocalComponentArtifactMetadata`

The 'file' property is no longer exposed in the artifact identifier: this removes

a bunch of casts.

  1. … 17 more files in changeset.
Add link to jira issue explaining the underlying problem

+review REVIEW-6136

  1. … 1 more file in changeset.
Add link to jira issue explaining the underlying problem

+review REVIEW-6136

  1. … 1 more file in changeset.
Remove unnecessary cast

+review REVIEW-6136

Remove unnecessary cast

+review REVIEW-6136

Ensure EclipseProject TAPI model is independent from explicit 'eclipse' plugin application

Some of the model information is set in an afterEvaluate block.

EclipseModelBuilder auto-applies the 'eclipse' plugin, but it's

too late, the afterEvaluate blocks are never called if the

plugin is not applied explicitly in the build script.

This commit is only a workaround, we should fix the underlying

problem in the next release.

+review REVIEW-6136

    • -0
    • +42
    ./eclipse/internal/AfterEvaluateHelper.java
  1. … 1 more file in changeset.
Ensure EclipseProject TAPI model is independent from explicit 'eclipse' plugin application

Some of the model information is set in an afterEvaluate block.

EclipseModelBuilder auto-applies the 'eclipse' plugin, but it's

too late, the afterEvaluate blocks are never called if the

plugin is not applied explicitly in the build script.

This commit is only a workaround, we should fix the underlying

problem in the next release.

+review REVIEW-6136

  1. … 1 more file in changeset.
Clean up a few TODOs

  1. … 5 more files in changeset.
Add isExported() method to EclipseClasspathContainer

  1. … 2 more files in changeset.
Revert "Add isExported() method to EclipseClasspathContainer"

This reverts commit a91c278af1186158308416ac7ba8e613d7323abe.

  1. … 2 more files in changeset.
Fix review items

+review REVIEW-6109

  1. … 1 more file in changeset.