Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace Buildship custom classpath filtering with the Eclipse 'test sources' feature

The custom classpath filtering is confusing to our users and prone

to errors. We decided to replace it with Eclipse's built-in test

source feature which was introduced in Eclipse Photon:

https://www.eclipse.org/eclipse/news/4.8/jdt.php#jdt-test-sources

    • -2
    • +6
    ./eclipse/EclipseClasspathFixture.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 16 more files in changeset.
Prototype for replacing Buildship custom classpath filtering with Eclipse test sources

    • -1
    • +9
    ./eclipse/EclipseClasspathFixture.groovy
    • -0
    • +2
    ./eclipse/EclipseIntegrationTest.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 14 more files in changeset.
Replace Buildship custom classpath filtering with the Eclipse 'test sources' feature

The custom classpath filtering is confusing to our users and prone

to errors. We decided to replace it with Eclipse's built-in test

source feature which was introduced in Eclipse Photon:

https://www.eclipse.org/eclipse/news/4.8/jdt.php#jdt-test-sources

    • -2
    • +6
    ./eclipse/EclipseClasspathFixture.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 16 more files in changeset.
Prototype for replacing Buildship custom classpath filtering with Eclipse test sources

    • -2
    • +6
    ./eclipse/EclipseClasspathFixture.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 16 more files in changeset.
Prototype for replacing Buildship custom classpath filtering with Eclipse test sources

    • -1
    • +9
    ./eclipse/EclipseClasspathFixture.groovy
    • -0
    • +2
    ./eclipse/EclipseIntegrationTest.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 14 more files in changeset.
Replace Buildship custom classpath filtering with the Eclipse 'test sources' feature

The custom classpath filtering is confusing to our users and prone

to errors. We decided to replace it with Eclipse's built-in test

source feature which was introduced in Eclipse Photon:

https://www.eclipse.org/eclipse/news/4.8/jdt.php#jdt-test-sources

    • -2
    • +6
    ./eclipse/EclipseClasspathFixture.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 16 more files in changeset.
Prototype for replacing Buildship custom classpath filtering with Eclipse test sources

    • -1
    • +9
    ./eclipse/EclipseClasspathFixture.groovy
    • -0
    • +2
    ./eclipse/EclipseIntegrationTest.groovy
    • -75
    • +0
    ./eclipse/EclipseSourceSetIntegrationSpec.groovy
    • -0
    • +46
    ./eclipse/EclipseTestSourcesIntegrationTest.groovy
  1. … 16 more files in changeset.
Fix IDE test expectations and mention breaking change

Mention that we no longer support Scala 2.9

  1. … 6 more files in changeset.
Fix IDEA module generation for overlapping resources

The test for this feature didn't actually test that a source

folder was there, so this was broken later on without noticing.

    • -0
    • +2
    ./idea/IdeaModuleIntegrationTest.groovy
  1. … 1 more file in changeset.
spelling: substitutes

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -1
    • +1
    ./eclipse/EclipseClasspathIntegrationTest.groovy
spelling: should

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -2
    • +2
    ./eclipse/EclipseIntegrationTest.groovy
    • -2
    • +2
    ./idea/ConfigurationHooksIntegrationTest.groovy
spelling: nonexistent

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -2
    • +2
    ./eclipse/EclipseWtpModelIntegrationTest.groovy
  1. … 11 more files in changeset.
spelling: failure

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

    • -1
    • +1
    ./eclipse/EclipseIntegrationTest.groovy
  1. … 1 more file in changeset.
In IDEA configuration ignore resource dir declaration if the target is a source dir

As explained at https://github.com/gradle/gradle/issues/654 if a

directory is both declared as a source and a resource directory, then

the resource flag was added to it. This makes IDEA unusable as the

source editing is disabled for the contained source files. To overcome

that, this commit makes the resource declaration omitted if the target

is a source directory.

    • -0
    • +44
    ./idea/IdeaModuleIntegrationTest.groovy
  1. … 1 more file in changeset.
Add settings file where required for integ tests

    • -0
    • +1
    ./idea/IdeaNestedBuildIntegrationTest.groovy
  1. … 7 more files in changeset.
Use global init script to set mirrors for buildSrc (#6627)

  1. … 50 more files in changeset.
Ensure that ide destroy tasks always run before generate tasks

    • -53
    • +1
    ./AbstractIdeDeduplicationIntegrationTest.groovy
    • -0
    • +99
    ./AbstractIdeLifecycleIntegrationTest.groovy
    • -0
    • +81
    ./AbstractIdeProjectIntegrationTest.groovy
    • -0
    • +44
    ./eclipse/EclipseLifecycleIntegrationTest.groovy
    • -0
    • +50
    ./idea/IdeaLifecycleIntegrationTest.groovy
  1. … 1 more file in changeset.
Make dependency locking failures lenient

Locking failures no longer cause an exception to be thrown, they are

instead recorded in the resolution result.

This enables lenient consumption of the resolution result to succeed

while preserving the failure behaviour for non lenient use cases.

This is done by recording artificial edges from the root component to

the different locking violations, either a missing module or an

unexpected one.

Issue #6383

    • -5
    • +1
    ./eclipse/EclipseDependencyLockingIntegrationTest.groovy
    • -4
    • +3
    ./idea/IdeaDependencyLockingIntegrationTest.groovy
  1. … 11 more files in changeset.
Add tests for IDE and locking integration

Issue #6383

    • -0
    • +101
    ./eclipse/EclipseDependencyLockingIntegrationTest.groovy
    • -0
    • +99
    ./idea/IdeaDependencyLockingIntegrationTest.groovy
Add test precondition for tests that rely on working dir modification

    • -3
    • +3
    ./eclipse/EclipseClasspathFixture.groovy
  1. … 6 more files in changeset.
Add test precondition for tests that rely on working dir modification

    • -3
    • +3
    ./eclipse/EclipseClasspathFixture.groovy
  1. … 6 more files in changeset.
Use external repository mirrors in build (#6094)

We've been bitten by external repository fluctuation for a long time.

This PR makes most of tests use repository mirrors set up by ourselves

via init script and system property.

There're still some tests not switching to mirrors, which would be fixed

in follow-up commits.

  1. … 99 more files in changeset.
Add some more test coverage to verify the IDE plugins are consistent in how they behave in composite builds. This just covers a couple of simple scenarios.

Change the `eclipse` task of the root project so that it generates the Eclipse projects for all builds, and so produces usable project files when there are included builds.

    • -3
    • +7
    ./eclipse/EclipseMultiBuildIntegrationTest.groovy
    • -1
    • +2
    ./eclipse/EclipseProjectFixture.groovy
    • -2
    • +4
    ./eclipse/EclipseWorkspaceFixture.groovy
    • -3
    • +10
    ./idea/IdeaMultiBuildIntegrationTest.groovy
  1. … 16 more files in changeset.
Add some test coverage to verify that each of the IDE plugins can be applied to `buildSrc`.

Start growing some cross-cutting test coverage for the IDE plugins, so the plugins can become less different to each other.

    • -0
    • +32
    ./eclipse/EclipseMultiBuildIntegrationTest.groovy
    • -0
    • +34
    ./eclipse/EclipseWorkspaceFixture.groovy
    • -0
    • +32
    ./idea/IdeaMultiBuildIntegrationTest.groovy
  1. … 10 more files in changeset.
Change `ProjectComponentIdentifier` and `ProjectComponentSelector` implementations to carry enough information to report the correct display name and project name. Change more places to delegate to the `BuildState` for a particular build to determine these values for a given project, rather than duplicating the logic to calculate these things.

    • -2
    • +1
    ./idea/IdeaMultiModuleIntegrationTest.groovy
  1. … 43 more files in changeset.
Register the projects of a build run using `GradleBuild` so they are visible to dependency resolution and other things that use the `ProjectStateRegistry` infrastructure, such as the IDE plugins.

    • -0
    • +36
    ./idea/IdeaNestedBuildIntegrationTest.groovy
  1. … 10 more files in changeset.
Synchronize access to the mutable project model when building the local component metadata to share across build boundaries. Previously, multiple threads could be attempting to query the outgoing artifacts of a project concurrently, triggering a bunch of lazy mutations to the project model concurrently.

This change reuses the infrastructure used in other parts of dependency resolution to allow safe access to the project state during parallel resolution. This infrastructure should eventually be used by all infrastructure (e.g. task graph construction, IDE model building, publishing, etc) that reaches across project boundaries, but isn't yet.

    • -3
    • +0
    ./idea/CompositeBuildIdeaProjectIntegrationTest.groovy
  1. … 4 more files in changeset.
Ignore noisy flaky test for now

    • -0
    • +3
    ./idea/CompositeBuildIdeaProjectIntegrationTest.groovy
Enable test.

    • -6
    • +1
    ./idea/CompositeBuildIdeaProjectIntegrationTest.groovy
Fix concurrency issue with lazy task getters

    • -3
    • +4
    ./idea/CompositeBuildIdeaProjectIntegrationTest.groovy
  1. … 2 more files in changeset.