Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Merge pull request #10907 from gradle/lacasseio/vs2019

Support for VS2019 and CI failure fix due to VS2019

  1. … 9 more files in changeset.
Add a last chance to locate MSBuild specifically for VS2019

Add a last chance to locate MSBuild specifically for VS2019

Add a last chance to locate MSBuild specifically for VS2019

Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 890 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 897 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Remove synthetic accessors for internal private symbol references

  1. … 902 more files in changeset.
Correctly handle when MSBuild doesn't generate output files

Always use first MSBuild output file when ignoring exit code

Ignore MSBuild return code when trying to build unbuildable project

MSBuild behaviour changed between pre-2017 and 2017. It used to fail on

pre-2017 if a project was requested and wasn't buildable. Starting with

2017, MSBuild doesn't fail anymore. The diagnostic message is the same

for all MSBuild version so we assert only on the message.

  1. … 1 more file in changeset.
Fix test failures on Windows

  1. … 4 more files in changeset.
Add support for architecture in Visual Studio IDE

    • -1
    • +5
    ./AbstractVisualStudioIntegrationSpec.groovy
  1. … 4 more files in changeset.
Update Apache Commons libraries to latest versions

- Replace `IOUtils.closeQuietly()` with try-with-resources

- Add Charset parameter to `FileUtils.writeStringToFile`,

`FileUtils.readFileToString` and `IOUtils.write`

  1. … 12 more files in changeset.
Add comment explaining why we need to use daemons in msbuild tests

    • -2
    • +16
    ./AbstractVisualStudioIntegrationSpec.groovy
Require daemon to be used when running Gradle via msbuild

We derive the Gradle environment used by msbuild when we generate the VS metadata.

When running from our embedded executor, we would experience 2 minute "hangs" where

msbuild waits for the Gradle daemon to exit.

    • -1
    • +1
    ./AbstractVisualStudioIntegrationSpec.groovy
Add diagnostic verbose

Force no-daemon during MSBuild

    • -1
    • +1
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix minor issue with MSBuild configuration

    • -10
    • +6
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix minor issue with MSBuild configuration

    • -10
    • +6
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix MSBuild output files for multiproject builds

    • -12
    • +21
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix MSBuild output files for multiproject builds

    • -12
    • +21
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix flakiness with MSBuild and plain console

The plain console prints the build failure on stderr. MSBuild

runs gradle in a subprocess, but then joins stdout and stderr

from that process onto stdout. It seems that it does some

buffering and sometimes stderr gets jumbled up with stdout in the

output. This can cause the output scraping to fail.

This changes `MSBuildExecutor` so that output from the

gradle command is redirected to separate stdout and stderr files

and then we parse the gradle build output for verification from

there.

    • -0
    • +33
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix flakiness with MSBuild and plain console

The plain console prints the build failure on stderr. MSBuild

runs gradle in a subprocess, but then joins stdout and stderr

from that process onto stdout. It seems that it does some

buffering and sometimes stderr gets jumbled up with stdout in the

output. This can cause the output scraping to fail.

This changes `MSBuildExecutor` so that output from the

gradle command is redirected to separate stdout and stderr files

and then we parse the gradle build output for verification from

there.

    • -0
    • +33
    ./AbstractVisualStudioIntegrationSpec.groovy
Fix MSBuild output scraping.

  1. … 2 more files in changeset.
Fix extraction of Gradle build result from MSBuild output.

  1. … 5 more files in changeset.
Change MSBuild test fixture to extract the result of zero or more Gradle invocations from MSBuild output.

  1. … 17 more files in changeset.
Added some test coverage for Visual Studio plugin, to ensure the right thing happens for multi-project and composite builds.

    • -0
    • +2
    ./AbstractVisualStudioIntegrationSpec.groovy
  1. … 3 more files in changeset.