internal

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Consolidate type validation

Use ValidateContext with a few standard implementations instead of the many different interfaces and implementations we used to collect valdiation problems before. This fixes issues with types being displayed inconsistently.

The implementation is not fully correct yet: we now fail to display the correct type for problems that are bound to a type instead of a property.

    • -6
    • +6
    ./execution/steps/ValidateStepTest.groovy
  1. … 47 more files in changeset.
Log whether work changes are incremental

    • -0
    • +1
    ./execution/steps/SkipUpToDateStepTest.groovy
  1. … 5 more files in changeset.
Allow ValidateStep to report validation warnings

    • -1
    • +40
    ./execution/steps/ValidateStepTest.groovy
  1. … 6 more files in changeset.
Emit validation warning in execution engine

    • -7
    • +27
    ./execution/steps/ValidateStepTest.groovy
  1. … 6 more files in changeset.
Do not follow symlinks when removing work outputs

    • -1
    • +1
    ./execution/steps/CacheStepTest.groovy
  1. … 18 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./execution/steps/CacheStepTest.groovy
  1. … 41 more files in changeset.
Move Deleter interface out of impl package

    • -1
    • +1
    ./execution/steps/CacheStepTest.groovy
  1. … 38 more files in changeset.
Use Deleter when removing outputs before execution

    • -2
    • +4
    ./execution/steps/CleanupOutputsStepTest.groovy
  1. … 5 more files in changeset.
Use Deleter when removing outputs before execution

    • -2
    • +4
    ./execution/steps/CleanupOutputsStepTest.groovy
  1. … 5 more files in changeset.
Use Deleter when removing outputs before execution

    • -2
    • +4
    ./execution/steps/CleanupOutputsStepTest.groovy
  1. … 5 more files in changeset.
Make FingerprinterFixture#outputFingerprinter private

    • -1
    • +1
    ./execution/steps/FingerprinterFixture.groovy
Rework FingerprinterFixture trait to not contain public fields

See: http://docs.groovy-lang.org/next/html/documentation/core-traits.html#_public_fields

    • -9
    • +13
    ./execution/steps/FingerprinterFixture.groovy
  1. … 2 more files in changeset.
Rework FingerprinterFixture to not contain public fields

See: http://docs.groovy-lang.org/next/html/documentation/core-traits.html#_public_fields

    • -9
    • +13
    ./execution/steps/FingerprinterFixture.groovy
  1. … 2 more files in changeset.
Rework FingerprinterFixture trait to not contain public fields

See: http://docs.groovy-lang.org/next/html/documentation/core-traits.html#_public_fields

    • -9
    • +13
    ./execution/steps/FingerprinterFixture.groovy
  1. … 2 more files in changeset.
Simplify Deleter API even more

    • -3
    • +2
    ./execution/steps/CacheStepTest.groovy
  1. … 6 more files in changeset.
Use Deleter to remove local state when loading from cache

    • -10
    • +15
    ./execution/steps/CacheStepTest.groovy
  1. … 2 more files in changeset.
Maintain history if and only if an execution history store is available

    • -2
    • +4
    ./execution/steps/CaptureStateBeforeExecutionStepTest.groovy
  1. … 4 more files in changeset.
Maintain history if and only if an execution history store is available

    • -2
    • +4
    ./execution/steps/CaptureStateBeforeExecutionStepTest.groovy
  1. … 3 more files in changeset.
Maintain history if and only if an execution history store is available

    • -2
    • +4
    ./execution/steps/CaptureStateBeforeExecutionStepTest.groovy
  1. … 3 more files in changeset.
Allow UnitOfWork to not specify an ExecutionHistoryStore

Non-incremental work won't benefit from this anyway.

    • -1
    • +1
    ./execution/steps/SkipEmptyWorkStepTest.groovy
    • -1
    • +1
    ./execution/steps/StoreExecutionStateStepTest.groovy
  1. … 7 more files in changeset.
Fail build on cache entry packing errors, too

    • -4
    • +8
    ./execution/steps/CacheStepTest.groovy
  1. … 2 more files in changeset.
Fix integration test

    • -3
    • +0
    ./execution/steps/CacheStepTest.groovy
  1. … 4 more files in changeset.
Fail on unpack failure

Previously we used to try a complicated dance to continue even if unpacking a cached result failed. We did this because wanted to avoid a corrupted cache entry breaking a build. However, with real-world usage it looks like hiding these problems causes more grief, and adds quite some complexity to the process. So we are removing this mitigation now.

    • -58
    • +7
    ./execution/steps/CacheStepTest.groovy
  1. … 2 more files in changeset.
Merge branch 'master' into lptr/execution/introduce-build-operations

    • -5
    • +24
    ./execution/steps/CancelExecutionStepTest.groovy
  1. … 1 more file in changeset.
Better names for execution state-related steps

Using LoadExecutionState and StoreExecutionState reflects the symmetry better than what we had before.

    • -0
    • +160
    ./execution/steps/StoreExecutionStateStepTest.groovy
    • -160
    • +0
    ./execution/steps/StoreSnapshotsStepTest.groovy
  1. … 9 more files in changeset.
Better names for execution state-related steps

Using LoadExecutionState and StoreExecutionState reflects the symmetry better than what we had before.

    • -0
    • +156
    ./execution/steps/StoreExecutionStateStepTest.groovy
    • -156
    • +0
    ./execution/steps/StoreSnapshotsStepTest.groovy
  1. … 9 more files in changeset.
Remove build operation around ExecutionStep for now

This messes up our test event detection currently, the fix is a bit more elaborate, so we backtrack here temporarily.

    • -16
    • +1
    ./execution/steps/ExecuteStepTest.groovy
  1. … 5 more files in changeset.
Interrupt task workers when build is cancelled

This allows arbitrary tasks to respond to cancellation, the same

way that task timouts are handled. The task only needs to respond

to interrupts in order to be cancellable. No additional public API

is required.

    • -3
    • +24
    ./execution/steps/CancelExecutionStepTest.groovy
  1. … 1 more file in changeset.
Interrupt task workers when build is cancelled

This allows arbitrary tasks to respond to cancellation, the same

way that task timouts are handled. The task only needs to respond

to interrupts in order to be cancellable. No additional public API

is required.

    • -4
    • +24
    ./execution/steps/CancelExecutionStepTest.groovy
  1. … 1 more file in changeset.
Clarify which step tests are context insensitive

    • -1
    • +1
    ./execution/steps/BroadcastChangingOutputsStepTest.groovy
    • -1
    • +1
    ./execution/steps/CancelExecutionStepTest.groovy
    • -1
    • +1
    ./execution/steps/CatchExceptionStepTest.groovy
    • -0
    • +26
    ./execution/steps/ContextInsensitiveStepSpec.groovy
    • -1
    • +1
    ./execution/steps/CreateOutputsStepTest.groovy
    • -1
    • +1
    ./execution/steps/RecordOutputsStepTest.groovy
    • -1
    • +1
    ./execution/steps/TimeoutStepTest.groovy
    • -1
    • +1
    ./execution/steps/ValidateStepTest.groovy