Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
(GRADLE-1446) Customizations within before/whenConfigured hooks are honored by the tooling api. Details:

- Added EclipseDomainModel that is accessible via EclipsePlugin. This will contain entire model for of eclipse plugin. Currently it is small but will grow.

- enabled and refactored integration test that validates that before/whenConfigured are honored by tooling api.

- ModelBuilder now uses the eclipse plugin model instead of eclipse generator tasks

- Rename job at GeneratorTask

    • -0
    • +26
    ./gradle/plugins/eclipse/model/EclipseDomainModel.groovy
  1. … 5 more files in changeset.
(GRADLE-1446) Refactored GeneratorTask to enable tooling api use some idea/eclipse plugins goodness. Details:

- GeneratorTask now allows 'preconfiguration' of the domain object. I'm not very happy with this implementation but it felt lesser evil given that I need to keep the api of GeneratorTask intact because it is a part of our public api.

- EclipseConfigurer and IdeaConfigurer task now run domain object configuration for relevant idea/eclipse GeneratorTasks. This way after configurer finishes his work we have the complete model of eclipse/idea (all subprojects).

- Added integration test for idea plugin. It checks if before/whenConfiguration hooks work ok.

  1. … 5 more files in changeset.
(GRADLE-1339) Added basic fix for the issue. Now the tooling api honors eclipse's projectName customizations and projectName deduplication logic. Details:

- EclipsePlugin now exposes the eclipseProject task. This is just a first step. In future it will expose the proper model object however it requires lots of refactoring.

- Added integration test for new features (tooling api handles deduplication & project name customizations)

- Changed slightly ToolingApiEclipseIntegrationTest.groovy so that it doesn't interfere with newly added project name deduplication

- Tooling api's ModelBuilder now applies the eclipse plugin for all projects and runs eclipseConfigurer

- Added necessary dependency from tooling-api to eclipse plugin

  1. … 4 more files in changeset.
Added more documentation to the DSL reference.

- examples related to EclipseProject/IdeaModule generation

- mentioned deduplication logic for eclipse project name

- added example related to 'provided' dependencies

  1. … 1 more file in changeset.
(GRADLE-1407) Next step in removing the duplication across eclipse & idea plugin. The duplication relates to module name deduplication logic.

- idea plugin uses the common deduplication logic

- some refactoring regarding names

- ideaModule task no longer exposes getCandidateNames

  1. … 14 more files in changeset.
(GRADLE-1407) First step in removing the duplication across eclipse & idea plugin. The duplication relates to module name deduplication logic.

- moved some logic to 'core'

- removed 'getCandidateNames()' from the task to avoid exposing our logic to users

- pending: make changes in idea accordingly

    • -4
    • +10
    ./gradle/plugins/eclipse/EclipseConfigurer.groovy
  1. … 4 more files in changeset.
(GRADLE-1407) Similarily as with idea plugin I added a configurer task that runs before eclipse generator tasks.

- eclipse plugin configures the configurer on root project and makes all generator tasks depend on it

- introduced marker interface that helps adding dependencies of configurer task

- added integration test

Pending:

- refactor to reduce duplication across eclipse/idea plugin and move unit tests accordingly

- document in the eclipse dsl guide the deduplication logic and effect on the projectName

    • -0
    • +22
    ./gradle/plugins/eclipse/DependsOnConfigurer.groovy
    • -0
    • +33
    ./gradle/plugins/eclipse/EclipseConfigurer.groovy
    • -1
    • +1
    ./gradle/plugins/eclipse/EclipseJdt.groovy
  1. … 1 more file in changeset.
Added a TODO

(GRADLE-1440) Fixed the problem with incorrect project dependencies in .classpath. It occurred when user had configured the eclipseProject.projectName property.

  1. … 2 more files in changeset.
updated some code comments

Changed declaration of property to match what code expects the contents to be

fixed GRADLE-1399: Incorrect contents generated for org.eclipse.wst.common.component file in Eclipse WTP Utility Module projects

    • -12
    • +14
    ./gradle/plugins/eclipse/EclipsePlugin.groovy
  1. … 2 more files in changeset.
replaced EclipseWtpComponent.sourceSets with EclipseWtpComponent.sourceDirs

  1. … 3 more files in changeset.
no longer generating java-output-path property because it has been obsolete ever since WTP 0.7

see http://www.ibm.com/support/docview.wss?uid=swg21312770

  1. … 3 more files in changeset.
small refactoring

fixed computation of transitive project dependencies in EclipsePlugin

  1. … 1 more file in changeset.
rewording of Eclipse task descriptions

more fixes for GRADLE-1275: EclipsePlugin does not properly support WTP project dependencies

  1. … 1 more file in changeset.
removed EclipseClasspath.entryConfigurers in favor of a regular whenConfigured {} hook test polishing

  1. … 1 more file in changeset.
turned Eclipse WTP tasks into XmlGeneratorTaskS

    • -53
    • +12
    ./gradle/plugins/eclipse/EclipseWtpFacet.groovy
    • -1
    • +1
    ./gradle/plugins/eclipse/model/BuildCommand.groovy
    • -70
    • +38
    ./gradle/plugins/eclipse/model/WtpComponent.groovy
    • -56
    • +22
    ./gradle/plugins/eclipse/model/WtpFacet.groovy
  1. … 18 more files in changeset.
partial fix for GRADLE-1275: EclipsePlugin does not properly support WTP project dependencies

    • -58
    • +149
    ./gradle/plugins/eclipse/EclipsePlugin.groovy
    • -187
    • +0
    ./gradle/plugins/eclipse/EclipseWtp.groovy
    • -0
    • +153
    ./gradle/plugins/eclipse/EclipseWtpComponent.groovy
    • -0
    • +98
    ./gradle/plugins/eclipse/EclipseWtpFacet.groovy
    • -4
    • +3
    ./gradle/plugins/eclipse/model/SourceFolder.groovy
    • -184
    • +0
    ./gradle/plugins/eclipse/model/Wtp.groovy
    • -0
    • +153
    ./gradle/plugins/eclipse/model/WtpComponent.groovy
    • -0
    • +112
    ./gradle/plugins/eclipse/model/WtpFacet.groovy
  1. … 28 more files in changeset.
Don't assume a particular implementation for the value of EclipseClasspath.sourceSets

fixed GRADLE-1330: StackOverflowError in Eclipse plugin in case of circular dependencies

  1. … 2 more files in changeset.
GRADLE-1248 - Added DomainObjectContainer.withType(Class, Closure) and withType(Class, Action) as a convenience for withType(Class).all(Closure)

  1. … 16 more files in changeset.
fixed GRADLE-1305, part 2: Eclipse plugin should configure the IDE to generate classes into the default location for the IDE, rather than into build/classes/$sourceSet

  1. … 7 more files in changeset.
groovyfied some Groovy code (minor syntactic changes)

    • -14
    • +14
    ./gradle/plugins/eclipse/EclipsePlugin.groovy
    • -9
    • +9
    ./gradle/plugins/eclipse/EclipseWtp.groovy
fixed GRADLE-1304, part 1: Eclipse plugin should replace the existing classpath when merging IDE configuration files

  1. … 1 more file in changeset.
fixed GRADLE-1080: Eclipse .project merging creates significant whitespace diffs changed codenarc rule to allow more expressive method names in Spock specs

    • -8
    • +11
    ./gradle/plugins/eclipse/model/Wtp.groovy
  1. … 30 more files in changeset.
GRADLE-1248 - Added DomainObjectContainer.all() as replacements for allObjects(). - Method all(Closure cl) treats the closure as a configuration closure. - Deprecated allObjects(), TaskCollection.allTasks() and PluginCollection.allPlugins().

  1. … 22 more files in changeset.
fixed GRADLE-1078: eclipse .classpath generation should order source folders per usual conventions

  1. … 1 more file in changeset.