Clone Tools
  • last updated a few seconds ago
Constraints: committers
Constraints: files
Constraints: dates
Merged idea & eclipse subprojects into 'ide' subproject. Pending: -package names changes? -move eclipse/idea integ tests to ide subproject

  1. … 203 more files in changeset.
(GRADLE-1449) Improved ToolingApi so that it honors user's customizations of source folders. ToolingApi is using eclipse plugin's domain model to get the proper source folders. This way the logic that understands gradle model and can translate it to eclipse model lives in single place (e.g. eclipse plugin). Details:

-since creation of eclipse model was getting complicated introduced a factory for that. It also improves testability

-eclipse plugin no longer need to keep state in eclipseProjectTask field (we can get it from parent's class project field)

-created / fixed corresponding integration tests

-creation of source folders in ToolingApi deserved a factory so it received one. Now it's cleaner & unit testing is possible

  1. … 6 more files in changeset.
Housekeeping. Added a fix of an edge case for idea plugin (when there was a dependency to a non-idea project the idea plugin could fail). Added corresponding integration test. Refactored names to make it more consistent.

  1. … 4 more files in changeset.
housekeeping & refactoring

  1. … 2 more files in changeset.
(GRADLE-1446) Refactored the intra-task dependencies between configurer & generator task for eclipse plugin. Made it more gradle-like by using dependency mechanism instead of implicit method call inside EclipseConfigurer. EclipseConfigurer no longer configures the domain objects for generator tasks, other tasks do it now. ModelBuilder needs to run extra tasks now (pending refactoring)


-documentation for GeneratorTask

  1. … 3 more files in changeset.
(GRADLE-1446) Customizations within before/whenConfigured hooks are honored by the tooling api. Details:

- Added EclipseDomainModel that is accessible via EclipsePlugin. This will contain entire model for of eclipse plugin. Currently it is small but will grow.

- enabled and refactored integration test that validates that before/whenConfigured are honored by tooling api.

- ModelBuilder now uses the eclipse plugin model instead of eclipse generator tasks

- Rename job at GeneratorTask

  1. … 4 more files in changeset.
(GRADLE-1446) Refactored GeneratorTask to enable tooling api use some idea/eclipse plugins goodness. Details:

- GeneratorTask now allows 'preconfiguration' of the domain object. I'm not very happy with this implementation but it felt lesser evil given that I need to keep the api of GeneratorTask intact because it is a part of our public api.

- EclipseConfigurer and IdeaConfigurer task now run domain object configuration for relevant idea/eclipse GeneratorTasks. This way after configurer finishes his work we have the complete model of eclipse/idea (all subprojects).

- Added integration test for idea plugin. It checks if before/whenConfiguration hooks work ok.

  1. … 5 more files in changeset.
(GRADLE-1339) Added basic fix for the issue. Now the tooling api honors eclipse's projectName customizations and projectName deduplication logic. Details:

- EclipsePlugin now exposes the eclipseProject task. This is just a first step. In future it will expose the proper model object however it requires lots of refactoring.

- Added integration test for new features (tooling api handles deduplication & project name customizations)

- Changed slightly ToolingApiEclipseIntegrationTest.groovy so that it doesn't interfere with newly added project name deduplication

- Tooling api's ModelBuilder now applies the eclipse plugin for all projects and runs eclipseConfigurer

- Added necessary dependency from tooling-api to eclipse plugin

  1. … 4 more files in changeset.
Added more documentation to the DSL reference.

- examples related to EclipseProject/IdeaModule generation

- mentioned deduplication logic for eclipse project name

- added example related to 'provided' dependencies

  1. … 1 more file in changeset.
(GRADLE-1407) Next step in removing the duplication across eclipse & idea plugin. The duplication relates to module name deduplication logic.

- idea plugin uses the common deduplication logic

- some refactoring regarding names

- ideaModule task no longer exposes getCandidateNames

  1. … 14 more files in changeset.
(GRADLE-1407) First step in removing the duplication across eclipse & idea plugin. The duplication relates to module name deduplication logic.

- moved some logic to 'core'

- removed 'getCandidateNames()' from the task to avoid exposing our logic to users

- pending: make changes in idea accordingly

  1. … 4 more files in changeset.
(GRADLE-1407) Added missing test

(GRADLE-1407) Similarily as with idea plugin I added a configurer task that runs before eclipse generator tasks.

- eclipse plugin configures the configurer on root project and makes all generator tasks depend on it

- introduced marker interface that helps adding dependencies of configurer task

- added integration test


- refactor to reduce duplication across eclipse/idea plugin and move unit tests accordingly

- document in the eclipse dsl guide the deduplication logic and effect on the projectName

  1. … 1 more file in changeset.
Added a TODO

(GRADLE-1440) Fixed the problem with incorrect project dependencies in .classpath. It occurred when user had configured the eclipseProject.projectName property.

  1. … 1 more file in changeset.
updated some code comments

Changed declaration of property to match what code expects the contents to be

fixed GRADLE-1399: Incorrect contents generated for org.eclipse.wst.common.component file in Eclipse WTP Utility Module projects

  1. … 2 more files in changeset.
replaced EclipseWtpComponent.sourceSets with EclipseWtpComponent.sourceDirs

  1. … 2 more files in changeset.
no longer generating java-output-path property because it has been obsolete ever since WTP 0.7


  1. … 3 more files in changeset.
small refactoring

fixed computation of transitive project dependencies in EclipsePlugin

  1. … 1 more file in changeset.
rewording of Eclipse task descriptions

more fixes for GRADLE-1275: EclipsePlugin does not properly support WTP project dependencies

  1. … 1 more file in changeset.
removed EclipseClasspath.entryConfigurers in favor of a regular whenConfigured {} hook test polishing

  1. … 1 more file in changeset.
turned Eclipse WTP tasks into XmlGeneratorTaskS

  1. … 11 more files in changeset.
partial fix for GRADLE-1275: EclipsePlugin does not properly support WTP project dependencies

    • -0
    • +112
  1. … 28 more files in changeset.
Don't assume a particular implementation for the value of EclipseClasspath.sourceSets

Some tidy-ups

  1. … 21 more files in changeset.
fixed GRADLE-1330: StackOverflowError in Eclipse plugin in case of circular dependencies

  1. … 2 more files in changeset.