Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Adjust test fixtures and test to ivy behavior changes

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 38 more files in changeset.
Remove special casing of pure ivy in resolve tests

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 11 more files in changeset.
Make selected variant accessible on dependency

For resolved dependency results, we now tell what

is the corresponding selected variant.

    • -2
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 24 more files in changeset.
Make selected variant accessible on dependency

For resolved dependency results, we now tell what

is the corresponding selected variant.

    • -2
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 24 more files in changeset.
Remove the singleton `NamedObjectInstantiator`. This is now available as a global service instead.

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 13 more files in changeset.
Remove the singleton `NamedObjectInstantiator`. This is now available as a global service instead.

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 13 more files in changeset.
Remove the singleton `NamedObjectInstantiator`. This is now available as a global service instead.

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 13 more files in changeset.
Remove the singleton `NamedObjectInstantiator`. This is now available as a global service instead.

    • -1
    • +1
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 13 more files in changeset.
Transition some static methods to a global service, so the implementation can be contextualized.

    • -0
    • +5
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 12 more files in changeset.
Transition some static methods to a global service, so the implementation can be contextualized.

    • -0
    • +5
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 12 more files in changeset.
Transition some static methods to a global service, so the implementation can be contextualized.

    • -0
    • +5
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 12 more files in changeset.
Transition some static methods to a global service, so the implementation can be contextualized.

    • -0
    • +5
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 11 more files in changeset.
Replace another usage of the `NamedObjectInstantiator` singleton with an injected service.

    • -0
    • +37
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 30 more files in changeset.
Replace another usage of the `NamedObjectInstantiator` singleton with an injected service.

    • -0
    • +37
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 32 more files in changeset.
Replace another usage of the `NamedObjectInstantiator` singleton with an injected service.

    • -0
    • +37
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 32 more files in changeset.
Replace another usage of the `NamedObjectInstantiator` singleton with an injected service.

    • -0
    • +37
    ./artifacts/DependencyManagementTestUtil.groovy
  1. … 32 more files in changeset.
Optimize `ModuleVersionResolveException`

During resolution, we may throw a lot of `ModuleVersionResolveException`

or `ModuleVersionNotFoundException`. Often, one per repository, when

a version is not found in that repository. But in the end, the version

may be found, or a different version may be selected, in which case we

don't care about the failure, which is only used if _no version_ could

be selected.

As a consequence, we had a lot of overhead in both generating a stack

trace **and** an error message, that would never be used.

This commit reworks those special exceptions used during resolution so

that we avoid filling the stack trace (we don't care) and we create

the message lazily (only if it will actually be used).

    • -1
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 23 more files in changeset.
Optimize `ModuleVersionResolveException`

During resolution, we may throw a lot of `ModuleVersionResolveException`

or `ModuleVersionNotFoundException`. Often, one per repository, when

a version is not found in that repository. But in the end, the version

may be found, or a different version may be selected, in which case we

don't care about the failure, which is only used if _no version_ could

be selected.

As a consequence, we had a lot of overhead in both generating a stack

trace **and** an error message, that would never be used.

This commit reworks those special exceptions used during resolution so

that we avoid filling the stack trace (we don't care) and we create

the message lazily (only if it will actually be used).

    • -1
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 23 more files in changeset.
Optimize `ModuleVersionResolveException`

During resolution, we may throw a lot of `ModuleVersionResolveException`

or `ModuleVersionNotFoundException`. Often, one per repository, when

a version is not found in that repository. But in the end, the version

may be found, or a different version may be selected, in which case we

don't care about the failure, which is only used if _no version_ could

be selected.

As a consequence, we had a lot of overhead in both generating a stack

trace **and** an error message, that would never be used.

This commit reworks those special exceptions used during resolution so

that we avoid filling the stack trace (we don't care) and we create

the message lazily (only if it will actually be used).

    • -1
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 24 more files in changeset.
Optimize `ModuleVersionResolveException`

During resolution, we may throw a lot of `ModuleVersionResolveException`

or `ModuleVersionNotFoundException`. Often, one per repository, when

a version is not found in that repository. But in the end, the version

may be found, or a different version may be selected, in which case we

don't care about the failure, which is only used if _no version_ could

be selected.

As a consequence, we had a lot of overhead in both generating a stack

trace **and** an error message, that would never be used.

This commit reworks those special exceptions used during resolution so

that we avoid filling the stack trace (we don't care) and we create

the message lazily (only if it will actually be used).

    • -1
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 24 more files in changeset.
Optimize `ModuleVersionResolveException`

During resolution, we may throw a lot of `ModuleVersionResolveException`

or `ModuleVersionNotFoundException`. Often, one per repository, when

a version is not found in that repository. But in the end, the version

may be found, or a different version may be selected, in which case we

don't care about the failure, which is only used if _no version_ could

be selected.

As a consequence, we had a lot of overhead in both generating a stack

trace **and** an error message, that would never be used.

This commit reworks those special exceptions used during resolution so

that we avoid filling the stack trace (we don't care) and we create

the message lazily (only if it will actually be used).

    • -1
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 24 more files in changeset.
Initial support for optional features

This commit introduces initial support for optional features, by

implementing a way for a dependency declaration (currently *only* in

the DSL) to request variants of the target component that provide one

or more capabilities.

Previously to this change, selection was (simplified) done like this:

1. find the target component

2. select the variant of the target component which matches the requested

attributes

Now, selection introduces another step:

1. find the target component

2. filter variants by eliminating those which do not provide the requested

capabilities

3. select the variant in this list which matches the requested attributes

Several changes had to be implemented:

First, component metadata rules calling `addCapability` will now return

a component which capabilities _include_ the default capability.

Second, attribute filtering is done in a secondary step, which means that

if there are no variant matching the requested capabilities, we will immediately

fail.

    • -1
    • +1
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 58 more files in changeset.
Support depending on multiple variants of the same component

This commit changes the resolution engine so that it is possible

to resolve multiple variants of the same component when using

variant-aware dependency management.

Before, in order to have 2 dependencies on the same component

but using different variants, one had to use explicit configuration

dependencies. Now, with this change, it is possible to have

two dependencies on the same component, but with different attributes.

Those components would resolve to different variants.

Special treatment is applied when attributes are declared on constraints:

in this case, we _merge_ the constraint attributes, and make sure that

the edge is computed using the merged attributes. Should they be

incompatible, the build would fail as before.

    • -1
    • +1
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 29 more files in changeset.
Add 'constraint' property to dependencies in ResolutionResult

It's important to be able to differentiate between hard dependencies and

dependency constraints when analysing the resolution result. This was done

by adding a simple boolean property to `DependencyResult`, indicating if

the source of the edge was a dependency or a constraint.

The new API is not yet used in any dependency reporting.

    • -5
    • +9
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 16 more files in changeset.
Split off value snapshotting and attributes related methods of TestUtil

    • -2
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 64 more files in changeset.
Renamed `VersionSelectionReasons` -> `ComponentSelectionReasons`

    • -3
    • +3
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 30 more files in changeset.
Add support for emitting information about repositories used during configuration resolution process, and sourced repository for a component (#5959)

- `ResolveConfigurationDependenciesBuildOperationType.Details` now contains a `List<Repository>` eventually provided by all `ResolutionAwareRepository` implementations

- `ResolvedComponentResult` has been subclassed to `ResolvedComponentResultInternal`, to provide the `repositoryName` used as source. This can be `null` in case of project dependency.

- Note that even when artifacts are resolved from the cache, they still convey the original repository that was used as source. The `name` of a repository is guaranteed to be unique inside a given repository container, and we use a single repository container to resolve a given configuration. Hence, the name can be safely used to uniquely identify which repository was used to source components.

- This commit also moves custom serialization logic to the owning type of `SerializedOperation` implementations to their owning types

    • -3
    • +2
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 52 more files in changeset.
Simplify construction of ModuleVersionSelector in unit tests

    • -1
    • +1
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 13 more files in changeset.
Rename to ArtifactCacheLockingManager

The name CacheLockingManager suggested it was used to manage locking of

caches in general instead of just for the artifacts cache.

Resolves gradle/gradle-private#1338.

    • -0
    • +57
    ./artifacts/ivyservice/ArtifactCacheLockingManagerStub.groovy
  1. … 27 more files in changeset.
Normalize `ModuleIdentifier`

This commit reworks the `ComponentModuleIdentifier`/`ComponentModuleSelector`/`ModuleVersionSelector`

classes to use `ModuleIdentifier` under the hood, instead of storing denormalized strings. This has

the advantage that we can reduce the use of the module identifier factory, which is called very

often during dependency resolution. Sharing instances reduces the need for conversions, and makes

comparisons faster.

    • -4
    • +5
    ./artifacts/result/ResolutionResultDataBuilder.groovy
  1. … 164 more files in changeset.