Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 10 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 10 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 8 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 8 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 11 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 11 more files in changeset.
Remove parameter support in ComponentSelectionRules

Previous parameters are available on `ComponentSelection` instead.

    • -10
    • +10
    ./DefaultRuleActionValidatorTest.groovy
  1. … 8 more files in changeset.
Upgrade Spock to Groovy 2.5-compatible variant

    • -3
    • +3
    ./DefaultRuleActionValidatorTest.groovy
  1. … 4 more files in changeset.
Stop using atomic types in non-thread-safe contexts (#5813)

- Replace AtomicReference with MutableReference

- Replace AtomicBoolean with MutableBoolean

    • -5
    • +4
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 17 more files in changeset.
Rework generics around RuleAction adapter and validator

The class itself does not need to be generic, only the methods.

  1. … 8 more files in changeset.
Improve fully qualified representation of nested model types

Use `.` instead of `$` to separate the enclosing type name from the

nested type name.

    • -1
    • +3
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 24 more files in changeset.
Some changes to apply consistent formatting for how methods are referred to in rule source validation error messages, plus applied consistent capitalization for the error messages.

+review REVIEW-5739

    • -11
    • +11
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 16 more files in changeset.
Extracted a type out of `RuleSourceBackedRuleAction` that can be used to collect up validation problems during type inspection.

Also tweaked the validation failure messages.

+review REVIEW-5739

    • -10
    • +10
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 7 more files in changeset.
Change model registry storage from being a table of opaque objects, to a graph of properties.

This doesn't quite satisfy the story goal of being able to target rules to nested properties, because we don't know about the nested properties until we create the objects. If we are using by-type bindings then we don't know that we need to create the parent object. To solve this we need to start populating the graph when something is registered (i.e. insert it in a kind of pending state, with its links also in a pending state) and then only populate the data when the node is “initialised”.

We are also only respecting one level of depth at the moment. That is, we treat (as far as the model graph is concerned) the properties of managed elements as unmanaged. Later stories will make this fully “transitive”.

+review

    • -1
    • +1
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 123 more files in changeset.
Improved error message for dependency rule with invalid input parameters.

+review REVIEW-5248

    • -2
    • +15
    ./DefaultRuleActionValidatorTest.groovy
  1. … 3 more files in changeset.
More improvements to error handling for component selection/metadata rules

+review REVIEW-5248

    • -7
    • +10
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 5 more files in changeset.
Improving error message handling for rule source based rule actions.

+review REVIEW-5248

    • -10
    • +32
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 3 more files in changeset.
Adding support for implicit and zero argument closures to component selection/metadata rules

+review REVIEW-5248

    • -4
    • +41
    ./ClosureBackedRuleActionTest.groovy
    • -16
    • +28
    ./DefaultRuleActionAdapterTest.groovy
  1. … 2 more files in changeset.
Update design spec for component selection rules Java API

    • -1
    • +1
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 2 more files in changeset.
Provide a rule source instance instead of class when defining component selection rules

    • -19
    • +43
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 7 more files in changeset.
Allow component selection rules to be defined with @Mutate

    • -0
    • +118
    ./RuleSourceBackedRuleActionTest.groovy
  1. … 8 more files in changeset.
Simplified unit test by using mock RuleActionAdapter

    • -11
    • +46
    ./DefaultRuleActionAdapterTest.groovy
  1. … 2 more files in changeset.
Moved contextualization of rule action validation exception inside RuleActionAdapter

    • -9
    • +13
    ./DefaultRuleActionAdapterTest.groovy
  1. … 3 more files in changeset.
Removed RuleAction from the public API: no replacement yet

    • -0
    • +112
    ./ClosureBackedRuleActionTest.groovy
    • -0
    • +84
    ./DefaultRuleActionAdapterTest.groovy
    • -0
    • +43
    ./DefaultRuleActionValidatorTest.groovy
    • -0
    • +60
    ./NoInputsRuleActionTest.groovy
  1. … 31 more files in changeset.