Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
GradlePomModuleDescriptorParser: resolve GAV after configuring parent in case POM inherits portions for name/group/version from the parent

Signed-off-by: Roberto Perez Alcolea <rperezalcolea@netflix.com>

    • -0
    • +45
    ./parser/GradlePomModuleDescriptorParserTest.groovy
  1. … 1 more file in changeset.
Rename inheritStrictVersions() -> endorseStrictVersions() (#10755)

This name change more clearly communicates the semantics of the

feature from a users point of view.

This commit also removes all mentions of 'inheriting' AND 'forSubgraph'.

There have been some leftovers in documentation/comments that

would have been misleading in the future. To make sure we catch all,

this also updates all variable/method/package names.

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 70 more files in changeset.
Rename inheritStrictVersions() -> endorseStrictVersions()

This is more clearly communicating the semantics of the feature

from a users point of view.

The commit also removes all mentions of 'inheriting' AND 'forSubgraph'.

There have been some leftovers in documentation/comments that

will be misleading in the future. To make sure we catch all,

I also updated all variable/method/package names.

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 70 more files in changeset.
Rename inheritStrictVersions() -> endorseStrictVersions()

This is more clearly communicating the semantics of the feature

from a users point of view.

The commit also removes all mentions of 'inheriting' AND 'forSubgraph'.

There have been some leftovers in documentation/comments that

will be misleading in the future. To make sure we catch all,

I also updated all variable/method/package names.

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 70 more files in changeset.
Rename inheritStrictVersions() -> endorseStrictVersions()

This is more clearly communicating the semantics of the feature

from a users point of view.

The commit also removes all mentions of 'inheriting' AND 'forSubgraph'.

There have been some leftovers in documentation/comments that

will be misleading in the future. To make sure we catch all,

I also updated all variable/method/package names.

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 70 more files in changeset.
Fix errors in the single version description

    • -10
    • +11
    ./strategy/DefaultVersionComparatorTest.groovy
  1. … 2 more files in changeset.
Fix errors in the single version description

    • -10
    • +11
    ./strategy/DefaultVersionComparatorTest.groovy
  1. … 2 more files in changeset.
Support prefix and latest selectors in strictly

This was basically just about adding test coverage.

The assumed behavior is that `latest.release` would

accept _any_ version when used in a reject selector,

so that we can iterate on rejected versions until

we find a match.

    • -19
    • +3
    ./strategy/DefaultVersionSelectorSchemeTest.groovy
    • -6
    • +2
    ./strategy/LatestVersionSelectorTest.groovy
  1. … 4 more files in changeset.
Support prefix and latest selectors in strictly

This was basically just about adding test coverage.

The assumed behavior is that `latest.release` would

accept _any_ version when used in a reject selector,

so that we can iterate on rejected versions until

we find a match.

    • -19
    • +3
    ./strategy/DefaultVersionSelectorSchemeTest.groovy
    • -6
    • +2
    ./strategy/LatestVersionSelectorTest.groovy
  1. … 4 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 31 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 31 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 31 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 31 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 31 more files in changeset.
Updates to terminology for clarity

- `inheritStrictConstraints` -> `inheritStrictVersions`

- `notInheritStrictConstraints` -> `doNotInheritStrictVersions`

    • -2
    • +2
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 30 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 77 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 79 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 77 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 77 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 77 more files in changeset.
Rework `forSubgraph` as implied by `strictly`

This commit removes a dedicated `forSubgraph` flag

on version constraints, so that it is _implied_ by

strict version constraints. This simplifies the behavior

of `strictly`, making it closer to the intuitive semantics,

while maintaining the ability to fail the build if a

consumer brings an incompatible version in the graph.

As a consequence, _strict dependencies_ now express that

the producer preference overrides whatever is found in

its own dependency graph. It is closer to the "nearest

first" semantics of Maven, while not having its drawbacks

(ordering in particular).

    • -14
    • +10
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 77 more files in changeset.
Ignore POM parent matching current POM

While Maven forbids creation of such a POM, it parses dependencies

defined that way fine.

Fixes #1084

    • -9
    • +5
    ./parser/GradlePomModuleDescriptorParserTest.groovy
  1. … 1 more file in changeset.
Ignore POM parent matching current POM

While Maven forbids creation of such a POM, it parses dependencies

defined that way fine.

Fixes #1084

    • -9
    • +5
    ./parser/GradlePomModuleDescriptorParserTest.groovy
  1. … 1 more file in changeset.
Ignore POM parent matching current POM

While Maven forbids creation of such a POM, it parses dependencies

defined that way fine.

Fixes #1084

    • -9
    • +5
    ./parser/GradlePomModuleDescriptorParserTest.groovy
  1. … 1 more file in changeset.
Ignore POM parent matching current POM

While Maven forbids creation of such a POM, it parses dependencies

defined that way fine.

    • -9
    • +5
    ./parser/GradlePomModuleDescriptorParserTest.groovy
  1. … 1 more file in changeset.
Add test coverage for artifact selectors in GMM

    • -32
    • +76
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 5 more files in changeset.
Add test coverage for artifact selectors in GMM

    • -32
    • +76
    ./parser/GradleModuleMetadataParserTest.groovy
  1. … 8 more files in changeset.
Align implementations of artifact identifier display names

DefaultModuleComponentArtifactIdentifier now behaves similar as

ComponentFileArtifactIdentifier (showing the full actual file name).

This means that the artifact name used during reporting now

contains the version at the usual position in the file name.

This way it shows the actual file name for artifacts originating

from pom-only maven repositories (except snapshots, which show the

SNAPSHOT placeholder) and ivy repositories with default pattern.

The motivation for this alignment is to get the same representation for

the same file, independent of whether it was sourced from traditional

or Gradle module metadata.

    • -4
    • +4
    ./parser/IvyModuleResolveMetadataBuilderTest.groovy
  1. … 32 more files in changeset.
Align implementations of artifact identifier display names

DefaultModuleComponentArtifactIdentifier now behaves similar as

ComponentFileArtifactIdentifier (showing the full actual file name).

This means that the artifact name used during reporting now

contains the version at the usual position in the file name.

This way it shows the actual file name for artifacts originating

from pom-only maven repositories (except snapshots, which show the

SNAPSHOT placeholder) and ivy repositories with default pattern.

The motivation for this alignment is to get the same representation for

the same file, independent of whether it was sourced from traditional

or Gradle module metadata.

    • -4
    • +4
    ./parser/IvyModuleResolveMetadataBuilderTest.groovy
  1. … 32 more files in changeset.
Only do maven artifact discovery for variants that require it

    • -2
    • +4
    ./CachingModuleComponentRepositoryTest.groovy
    • -5
    • +7
    ./ErrorHandlingModuleComponentRepositoryTest.groovy
  1. … 10 more files in changeset.