Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Spike generating an XML file with SHA512 checksums

    • -1
    • +1
    ./resolver/OriginArtifactSelector.java
  1. … 10 more files in changeset.
Spike generating an XML file with SHA512 checksums

    • -1
    • +1
    ./resolver/OriginArtifactSelector.java
  1. … 9 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +20
    ./ModuleVersionNotFoundException.java
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +20
    ./ModuleVersionNotFoundException.java
  1. … 6 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +20
    ./ModuleVersionNotFoundException.java
  1. … 12 more files in changeset.
Improve error message when build fails because of missing metadata

Gradle 6.0 removed the "artifact" metadata source by default.

This means that if a module is published _only_ with an artifact,

previous version of Gradle would find it, but 6.0 would fail with

a module missing exception.

The problem is that it's hard to realize that the issue comes

from the change of this default artifact sources.

This commit tries to improve the situation by recognizing that

a failure is related to not finding metadata, and in this case

would suggest that if the metadata is missing, it is still

possible that the jar is present.

The drawback of this approach is that we're unsure: if, for

some reason, the module is _really_ absent, then we gave a

wrong advice. This means, in particular, in case of wrong

coordinates.

    • -0
    • +20
    ./ModuleVersionNotFoundException.java
  1. … 12 more files in changeset.
Do not drop variant attributes in results based on maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

This is only affecting the attributes reported in the result. During

matching, which happens earlier, all attributes were already considered.

    • -1
    • +2
    ./resolver/DefaultArtifactSelector.java
  1. … 17 more files in changeset.
Do not drop variant attributes in results based on maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

This is only affecting the attributes reported in the result. During

matching, which happens earlier, all attributes were already considered.

    • -1
    • +1
    ./resolver/DefaultArtifactSelector.java
  1. … 17 more files in changeset.
Do not drop variant attributes in results based on maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

This is only affecting the attributes reported in the result. During

matching, which happens earlier, all attributes were already considered.

    • -1
    • +1
    ./resolver/DefaultArtifactSelector.java
  1. … 17 more files in changeset.
Do not drop variant attributes in results based on maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

This is only affecting the attributes reported in the result. During

matching, which happens earlier, all attributes were already considered.

    • -1
    • +1
    ./resolver/DefaultArtifactSelector.java
  1. … 17 more files in changeset.
Do not drop variant attributes for 'traditional' maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

    • -1
    • +1
    ./resolver/DefaultArtifactSelector.java
  1. … 27 more files in changeset.
Do not drop variant attributes for 'traditional' maven artifacts

FixedComponentArtifacts dropped the variant attributes (stored in

ConfigurationMetadata) for no clear reason. Because of this, the

attributes in the resolve result differed depending on whether the

variant was constructed from pom or GMM.

    • -1
    • +1
    ./resolver/DefaultArtifactSelector.java
  1. … 15 more files in changeset.
Address review feedback

    • -0
    • +2
    ./caching/ImplicitInputsCapturingInstantiator.java
  1. … 5 more files in changeset.
Apply `Anonymous type can be replaced with lambda` inspection the whole project

    • -17
    • +6
    ./caching/ComponentMetadataRuleExecutor.java
    • -15
    • +6
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 663 more files in changeset.
Apply `Explicit type can be replaced with <>` inspection the whole project

    • -3
    • +3
    ./caching/CrossBuildCachingRuleExecutor.java
    • -2
    • +2
    ./result/DefaultBuildableComponentIdResolveResult.java
  1. … 907 more files in changeset.
Revert new exclude rule merging

This is a temporary revert to allow ironing out some issues with

the newer implementation.

    • -6
    • +4
    ./resolver/DefaultArtifactSelector.java
    • -2
    • +2
    ./resolver/OriginArtifactSelector.java
  1. … 36 more files in changeset.
Revert new exclude rule merging

This is a temporary revert to allow ironing out some more issues with

the newer implementation.

    • -6
    • +4
    ./resolver/DefaultArtifactSelector.java
    • -2
    • +2
    ./resolver/OriginArtifactSelector.java
  1. … 36 more files in changeset.
Revert new exclude rule merging

This is a temporary revert to allow ironing out some issues with

the newer implementation.

    • -6
    • +4
    ./resolver/DefaultArtifactSelector.java
    • -2
    • +2
    ./resolver/OriginArtifactSelector.java
  1. … 36 more files in changeset.
Extract anonymous classes to static inner classes

    • -12
    • +22
    ./caching/CrossBuildCachingRuleExecutor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -12
    • +22
    ./caching/CrossBuildCachingRuleExecutor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -12
    • +22
    ./caching/CrossBuildCachingRuleExecutor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -12
    • +22
    ./caching/CrossBuildCachingRuleExecutor.java
  1. … 145 more files in changeset.
Extract anonymous classes to static inner classes

    • -12
    • +22
    ./caching/CrossBuildCachingRuleExecutor.java
  1. … 146 more files in changeset.
Use method reference, where applicable

    • -1
    • +1
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 169 more files in changeset.
Use method reference, where applicable

    • -1
    • +1
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 167 more files in changeset.
Organize imports

    • -3
    • +0
    ./caching/ComponentMetadataRuleExecutor.java
    • -1
    • +0
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 338 more files in changeset.
Replace anonymous classes with lambdas

    • -17
    • +6
    ./caching/ComponentMetadataRuleExecutor.java
    • -15
    • +6
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 708 more files in changeset.
Replace anonymous classes with lambdas

    • -14
    • +6
    ./caching/ComponentMetadataRuleExecutor.java
    • -14
    • +6
    ./caching/ComponentMetadataSupplierRuleExecutor.java
  1. … 692 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./caching/ComponentMetadataRuleExecutor.java
    • -4
    • +10
    ./caching/CrossBuildCachingRuleExecutor.java
    • -3
    • +3
    ./caching/ImplicitInputsCapturingInstantiator.java
  1. … 888 more files in changeset.
Remove synthetic accessors for internal private symbol references

    • -1
    • +1
    ./caching/ComponentMetadataRuleExecutor.java
    • -4
    • +10
    ./caching/CrossBuildCachingRuleExecutor.java
    • -3
    • +3
    ./caching/ImplicitInputsCapturingInstantiator.java
  1. … 895 more files in changeset.