Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Don't write in RO dependency cache when parent POM is missing

This commit works around a bug whenever the read-only dependency cache

used to contain a parent POM, but it has been cleaned up in between

(for example via the seeding build).

In this case, if a "consumer" build uses the read-only cache and

resolves a dependency which has the same parent POM, it will attempt

to write in the read-only dependency cache even if it shouldn't.

The ideal fix would be to avoid tweaking the failsafe cache, but it

appears that some read operations _may_ trigger a write operation

in between (as a cleanup side effect). This commit therefore makes

sure that we don't even attempt to call a write operation in this

case.

Fixes #12996

    • -1
    • +2
    ./artifacts/ReadOnlyModuleArtifactCache.java
  1. … 2 more files in changeset.
Don't write in RO dependency cache when parent POM is missing

This commit works around a bug whenever the read-only dependency cache

used to contain a parent POM, but it has been cleaned up in between

(for example via the seeding build).

In this case, if a "consumer" build uses the read-only cache and

resolves a dependency which has the same parent POM, it will attempt

to write in the read-only dependency cache even if it shouldn't.

The ideal fix would be to avoid tweaking the failsafe cache, but it

appears that some read operations _may_ trigger a write operation

in between (as a cleanup side effect). This commit therefore makes

sure that we don't even attempt to call a write operation in this

case.

Fixes #12996

    • -1
    • +2
    ./artifacts/ReadOnlyModuleArtifactCache.java
  1. … 2 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Clean up warnings

This includes cleaning up compilation warnings and other warnings from

IDE inspection.

One large area of changes was around having proper @Nullable /

@NonNullApi to clarify nullability.

    • -5
    • +1
    ./ModuleMetadataCacheEntrySerializer.java
    • -1
    • +1
    ./artifacts/AbstractArtifactsCache.java
    • -1
    • +1
    ./artifacts/ArtifactAtRepositoryKey.java
    • -1
    • +1
    ./artifacts/DefaultModuleArtifactsCache.java
    • -1
    • +1
    ./dynamicversions/DefaultModuleVersionsCache.java
    • -1
    • +1
    ./dynamicversions/ModuleAtRepositoryKey.java
    • -2
    • +2
    ./dynamicversions/ModuleVersionsCacheEntry.java
  1. … 319 more files in changeset.
Prefer encoding small integers for dirMode & fileMode

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Serialize scalar properties from CopySpec

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Serialize scalar properties from CopySpec

Signed-off-by: Paul Merlin <paul@gradle.com>

  1. … 6 more files in changeset.
Add `Encoder.encodeChunked()` and `Decode.decodeChunked()` and `skipChunked()` to allow a potentially large stream of bytes to be encoded and decoded or skipped.

  1. … 8 more files in changeset.
Add `Encoder.encodeChunked()` and `Decode.decodeChunked()` and `skipChunked()` to allow a potentially large stream of bytes to be encoded and decoded or skipped.

  1. … 7 more files in changeset.
Add `Encoder.encodeChunked()` and `Decode.decodeChunked()` and `skipChunked()` to allow a potentially large stream of bytes to be encoded and decoded or skipped.

  1. … 8 more files in changeset.
Add `Encoder.encodeChunked()` and `Decode.decodeChunked()` and `skipChunked()` to allow a potentially large stream of bytes to be encoded and decoded or skipped.

  1. … 8 more files in changeset.
Add `Encoder.encodeChunked()` and `Decode.decodeChunked()` and `skipChunked()` to allow a potentially large stream of bytes to be encoded and decoded or skipped.

  1. … 8 more files in changeset.
Move FileAccessTracker to :files

    • -1
    • +1
    ./artifacts/DefaultModuleArtifactCache.java
    • -1
    • +1
    ./artifacts/ReadOnlyModuleArtifactCache.java
  1. … 24 more files in changeset.
Move FileAccessTracker to :files

    • -1
    • +1
    ./artifacts/DefaultModuleArtifactCache.java
    • -1
    • +1
    ./artifacts/ReadOnlyModuleArtifactCache.java
  1. … 24 more files in changeset.
Move FileAccessTracker to :files

    • -1
    • +1
    ./artifacts/DefaultModuleArtifactCache.java
    • -1
    • +1
    ./artifacts/ReadOnlyModuleArtifactCache.java
  1. … 24 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Fix read-only cache for dynamic version listing

    • -0
    • +3
    ./dynamicversions/TwoStageModuleVersionsCache.java
  1. … 5 more files in changeset.
Add tests for read-only dependency cache

    • -1
    • +8
    ./artifacts/TwoStageModuleArtifactCache.java
  1. … 13 more files in changeset.
Add tests for read-only dependency cache

    • -1
    • +8
    ./artifacts/TwoStageModuleArtifactCache.java
  1. … 12 more files in changeset.
Add tests for read-only dependency cache

    • -1
    • +8
    ./artifacts/TwoStageModuleArtifactCache.java
  1. … 13 more files in changeset.
Add tests for read-only dependency cache

    • -1
    • +8
    ./artifacts/TwoStageModuleArtifactCache.java
  1. … 13 more files in changeset.