MavenHttpRepoResolveIntegrationTest.groovy

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 48 more files in changeset.
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 48 more files in changeset.
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 49 more files in changeset.
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 49 more files in changeset.
Annotate tests to account for new reported problems

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +1
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 49 more files in changeset.
Fixes for previous commits.

    • -6
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 5 more files in changeset.
Do not write the source paths for a `CopySpec` multiple times to the instant execution cache.

Previously, these were written once when the `CopySpec` was serialized and once when the associated input property spec was serialized.

This commit adds some special case handling for this case. It also preserves the identity of each `FileTree` and `FileCollection` instance for each task to enable short circuiting when the same file collections are referenced via multiple paths, such as in the `CopySpec` case.

    • -6
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 42 more files in changeset.
Do not write the source paths for a `CopySpec` multiple times to the instant execution cache.

Previously, these were written once when the `CopySpec` was serialized and once when the associated input property spec was serialized.

This commit adds some special case handling for this case. It also preserves the identity of each `FileTree` and `FileCollection` instance for each task to enable short circuiting when the same file collections are referenced via multiple paths, such as in the `CopySpec` case.

    • -6
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 42 more files in changeset.
Do not write the source paths for a `CopySpec` multiple times to the instant execution cache.

Previously, these were written once when the `CopySpec` was serialized and once when the associated input property spec was serialized.

This commit adds some special case handling for this case. It also preserves the identity of each `FileTree` and `FileCollection` instance for each task to enable short circuiting when the same file collections are referenced via multiple paths, such as in the `CopySpec` case.

    • -6
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 42 more files in changeset.
Rename @FailsWithInstantExecution to @ToBeFixedForInstantExecution

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -5
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 872 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 93 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 93 more files in changeset.
Annotate integ tests failing with instant execution in :dependencyManagement

Signed-off-by: Paul Merlin <paul@gradle.com>

    • -0
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 93 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -6
    • +2
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 95 more files in changeset.
wip - fix more tests

    • -2
    • +0
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 46 more files in changeset.
wip - fix more tests

    • -2
    • +0
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 46 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -4
    • +2
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -4
    • +2
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 15 more files in changeset.
Adjust tests and samples to new metadata sources defaults

    • -4
    • +2
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 15 more files in changeset.
Finalize the value of any task `@Input` property whose getter returns a property instance, at the start of execution of the task.

This means that the property value will not change once the task has started execution, so that the same value is always used during fingerprinting, cache key calculation, validation, when queried by a task action, and so on.

This behaviour only applies to `@Input` properties in this commit. This was just a place to start. Other properties will be added in later commits.

Changes to the property are ignored once the value is finalized implicitly in this way and generate a deprecation warning instead of failing, as would happen after `finalizeValue()` is called. This allows a migration path for task types that can add a new property to represent some input and keep their existing lenient (but now deprecated) behaviour for an existing property backed by the new property. It might prove better to flip this around, let's see.

    • -2
    • +3
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 61 more files in changeset.
Change int tests to use relevant fixture methods to express their expectations about the build log output.

    • -8
    • +8
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 30 more files in changeset.
Avoid Maven repository lookups for unsupported notations

A Maven repository always requires a group, name and version to

be specified. Asking without them will result in either a 400 or 404,

depending on the artifact server. This creates unnecessary network traffic,

so instead we don't even ask and report the module as missing.

This can happen when a user mixes a flatDir repository and a Maven

repository. Modules in the flatDir repository don't have a group.

Depending on the order of repositories, Gradle will end up asking the

Maven repository for things that can never be found there.

    • -0
    • +39
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 2 more files in changeset.
Treat various kinds of dependency resolution failures in more consistent ways.

- When a non-lenient view is used as a task input, then propagate any failure to select a configuration in the dependency graph during task graph calculation, rather than suppressing these kinds of failures and propagating later when the files happen to be queried. This now happens consistently whether fluid dependencies are used or not. The only difference between these is how much of the graph is traversed at task graph calculation time.

- When a lenient view is used as a task input, suppress configuration selection failures during task graph calculation and instead present them in `ArtifactCollection.failures`. Do this consistently regardless of whether fluid dependencies are used or not. Previously this kind of failure was propagated during task graph calculation for lenient views.

Also changed the error message on resolution failure to include what kind of query was being performed at the time to trigger the failure.

From an implementation point of view, separated the handling of selection failures from the code that produces the legacy resolution result so that this handling can be reused when the legacy result is not required (such as, say, when calculating the task graph).

    • -3
    • +3
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 34 more files in changeset.
Fix expected error messages

+review REVIEW-6478

    • -1
    • +2
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 1 more file in changeset.
Replace << by doLast in MavenHttpRepoResolveIntegrationTest

+review REVIEW-6237

    • -5
    • +5
    ./MavenHttpRepoResolveIntegrationTest.groovy
Use doLast instead of left shift operator

Made this change in preparation for deprecating the left shift operator.

+review REVIEW-6236

    • -8
    • +16
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 163 more files in changeset.
Improve error handling if Http Response has no content

We did get a NPE when an artifact repository returned `304`.

This should never happen but with this error handling we

at least see what went wrong.

    • -1
    • +35
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 1 more file in changeset.
add test coverage for attempting to use AwsCredentials with non-S3 repository

+review REVIEW-5361

    • -0
    • +32
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 1 more file in changeset.
Renamed subprojects/core-impl to subprojects/dependency-management.

    • -0
    • +359
    ./MavenHttpRepoResolveIntegrationTest.groovy
  1. … 1384 more files in changeset.